[Security Solution] Show proper icon for termination status of all processes #73235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
kqualters-elastic
changed the title
michaelolo24
approved these changes
Jul 27, 2020
bkimmel
reviewed
Jul 27, 2020
| }) { | ||
| const processName = event.eventName(processEvent); | ||
| const entityId = event.entityId(processEvent); | ||
| const isProcessTerminated = useSelector(selectors.isProcessTerminated)(entityId); |
Contributor
There was a problem hiding this comment.
❔ Does this have to run the .has every time it renders? Could it avoid that if it were memoized?
bkimmel
reviewed
Jul 27, 2020
| * During user testing, one user indicated they wanted to see stronger visual relationships between | ||
| * Nodes on the graph and what's in the table. Using the same symbol in both places (as below) could help with that. | ||
| */ | ||
| export const CubeForProcess = memo(function CubeForProcess({ |
Contributor
There was a problem hiding this comment.
❔ Not related to this PR, but I'm having trouble understanding why this file isn't part of assets
james-elastic
approved these changes
Jul 27, 2020
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
kqualters-elastic
added a commit
to kqualters-elastic/kibana
that referenced
this pull request
Jul 28, 2020
…ocesses (elastic#73235) * Show proper icon for termination status of all processes * Add basic test for isProcessTerminated selector
kqualters-elastic
added a commit
to kqualters-elastic/kibana
that referenced
this pull request
Jul 28, 2020
…ocesses (elastic#73235) * Show proper icon for termination status of all processes * Add basic test for isProcessTerminated selector
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 28, 2020
* master: (44 commits) [Search] add server logs (elastic#72454) [SIEM][Timelines] Updates timeline template callout text (elastic#73334) Fix App status flaky test (elastic#72853) [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243) Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468) fix dashboard index pattern race condition (elastic#72899) [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255) [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238) updates cypress to v4.11.0 (elastic#73327) [Metrics UI] Saved views bugs (elastic#72518) [Ingest Manager] Convert select agent config step to use combo box (elastic#73172) Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128) [Security Solution][ML] Updates siem group name to security (elastic#73218) [Security Solution] Show proper icon for termination status of all processes (elastic#73235) [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313) [Security solution] Threat hunting test coverage improvements (elastic#73276) [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129) [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324) [dev/build/docker_generator] convert to typescript (elastic#73339) [APM] Fix focus map link on service map (elastic#73338) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where all processes are shown as terminated, because of an improper selector. Adds a new one that checks if a given entity id is in the set of terminated processes, and this is used in the appropriate components.
Checklist
For maintainers