Skip to content

[Metrics UI] Fix Alert Preview Error design #71005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zacqary merged 8 commits into from
Jul 20, 2020
Merged

[Metrics UI] Fix Alert Preview Error design #71005

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dc9afd
[Metrics UI] Fix Alert Preview Error design
Zacqary Jul 7, 2020
61a0776
Merge branch 'master' into 70505-preview-error-fix
elasticmachine Jul 7, 2020
252bc25
Merge branch 'master' into 70505-preview-error-fix
elasticmachine Jul 7, 2020
461556e
Update text size and spacing
Zacqary Jul 9, 2020
0f42418
Merge branch '70505-preview-error-fix' of github.com:Zacqary/kibana i…
Zacqary Jul 9, 2020
08f29ed
Merge branch 'master' into 70505-preview-error-fix
elasticmachine Jul 9, 2020
2a18d5d
Merge branch 'master' into 70505-preview-error-fix
elasticmachine Jul 14, 2020
57a77c6
Merge branch 'master' into 70505-preview-error-fix
elasticmachine Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 19 additions & 33 deletions x-pack/plugins/infra/public/alerting/common/components/alert_preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,8 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiCallOut,
EuiOverlayMask,
EuiModal,
EuiModalHeader,
EuiModalHeaderTitle,
EuiModalBody,
EuiAccordion,
EuiCodeBlock,
EuiLink,
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -61,9 +56,6 @@ export const AlertPreview: React.FC<Props> = (props) => {
const [previewResult, setPreviewResult] = useState<
(AlertPreviewSuccessResponsePayload & Record<string, any>) | null
>(null);
const [isErrorModalVisible, setIsErrorModalVisible] = useState<boolean>(false);
const onOpenModal = useCallback(() => setIsErrorModalVisible(true), [setIsErrorModalVisible]);
const onCloseModal = useCallback(() => setIsErrorModalVisible(false), [setIsErrorModalVisible]);

const onSelectPreviewLookbackInterval = useCallback((e) => {
setPreviewLookbackInterval(e.target.value);
Expand Down Expand Up @@ -271,33 +263,27 @@ export const AlertPreview: React.FC<Props> = (props) => {
iconType="alert"
>
{previewError.body && (
<FormattedMessage
id="xpack.infra.metrics.alertFlyout.alertPreviewErrorDesc"
defaultMessage="Try again later, or {viewTheError}."
values={{
viewTheError: <EuiLink onClick={onOpenModal}>view the error</EuiLink>,
}}
/>
<>
<FormattedMessage
id="xpack.infra.metrics.alertFlyout.alertPreviewErrorDesc"
defaultMessage="Please try again later or see details for more information."
/>
<EuiSpacer size={'s'} />
<EuiAccordion
id="alertErrorDetailsAccordion"
buttonContent={i18n.translate(
Copy link
Contributor

@hbharding hbharding Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change buttonContent so that it uses <EuiText size="s"> so that it matches the font size of other text in the callout

'xpack.infra.metrics.alertFlyout.errorDetails',
{
defaultMessage: 'Details',
}
)}
>
<EuiCodeBlock>{previewError.body.message}</EuiCodeBlock>
Copy link
Contributor

@hbharding hbharding Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <EuiSpacer size={'s'} /> before the codeblock so that there is space between the codeblock and accordion toggle. You may need to wrap this in a fragment.

</EuiAccordion>
</>
)}
</EuiCallOut>
)}
{isErrorModalVisible && (
<EuiOverlayMask>
<EuiModal onClose={onCloseModal}>
<EuiModalHeader>
<EuiModalHeaderTitle>
<FormattedMessage
id="xpack.infra.metrics.alertFlyout.alertPreviewErrorModalTitle"
defaultMessage="Alert preview error"
/>
</EuiModalHeaderTitle>
</EuiModalHeader>
<EuiModalBody>
<EuiCodeBlock>{previewError.body.message}</EuiCodeBlock>
</EuiModalBody>
</EuiModal>
</EuiOverlayMask>
)}
</>
)}
</>
Expand Down