[7.x] [Watcher] Fix logic that determines watch error state (#67952)

[alisonelizabeth]

Backports the following commits to 7.x:

• [Watcher] Fix logic that determines watch error state ([Watcher] Fix logic that determines watch error state #67952)

[kibanamachine]

💛 Build succeeded, but was flaky

• continuous-integration/kibana-ci/pull-request
• Commit: 919aaec
• Flaky suites:
  • kibana-firefoxSmoke

---

Test Failures

Kibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/home/_home·js.homepage app Kibana takes you home clicking on kibana logo should take you to home page

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:11:56]         └-: homepage app
[00:11:56]           └-> "before all" hook
[00:11:56]           └-> "before all" hook
[00:11:56]           └-: Kibana takes you home
[00:11:56]             └-> "before all" hook
[00:11:56]             └-> clicking on kibana logo should take you to home page
[00:11:56]               └-> "before each" hook: global before each
[00:11:56]               │ debg navigating to settings url: http://localhost:6111/app/management
[00:11:56]               │ debg navigate to: http://localhost:6111/app/management
[00:11:56]               │ debg browser[log] "^ A single error about an inline script not firing due to content security policy is expected!"
[00:11:56]               │ debg ... sleep(700) start
[00:11:57]               │ debg ... sleep(700) end
[00:11:57]               │ debg returned from get, calling refresh
[00:11:58]               │ debg browser[info] "INFO: 2020-06-12T14:56:17Z\n  Adding connection to http://localhost:6111/elasticsearch\n\n"
[00:11:58]               │ERROR browser[error] (new TypeError("NetworkError when attempting to fetch resource.", ""))
[00:11:58]               │ debg browser[log] "^ A single error about an inline script not firing due to content security policy is expected!"
[00:11:59]               │ debg currentUrl = http://localhost:6111/app/management
[00:11:59]               │          appUrl = http://localhost:6111/app/management
[00:11:59]               │ debg TestSubjects.find(kibanaChrome)
[00:11:59]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:12:02]               │ debg browser[info] "INFO: 2020-06-12T14:56:21Z\n  Adding connection to http://localhost:6111/elasticsearch\n\n"
[00:12:02]               │ debg ... sleep(501) start
[00:12:03]               │ debg ... sleep(501) end
[00:12:03]               │ debg in navigateTo url = http://localhost:6111/app/management
[00:12:03]               │ debg TestSubjects.exists(statusPageContainer)
[00:12:03]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:12:06]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:12:06]               │ debg TestSubjects.click(headerGlobalNav > logo)
[00:12:06]               │ debg Find.clickByCssSelector('[data-test-subj="headerGlobalNav"] [data-test-subj="logo"]') with timeout=10000
[00:12:06]               │ debg Find.findByCssSelector('[data-test-subj="headerGlobalNav"] [data-test-subj="logo"]') with timeout=10000
[00:12:06]               │ERROR browser[error] (new Error("ScopedHistory instance has fell out of navigation scope for basePath: /app/management", "http://localhost:6111/32384/bundles/core/core.entry.js", 76))
[00:12:06]               │ERROR browser[error] (new Error("ScopedHistory instance has fell out of navigation scope for basePath: /app/management", "http://localhost:6111/32384/bundles/core/core.entry.js", 76))
[00:12:06]               │ debg isGlobalLoadingIndicatorVisible
[00:12:06]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:12:06]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:12:06]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:12:06]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:13:46]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/homepage app Kibana takes you home clicking on kibana logo should take you to home page.png"
[00:13:46]               │ info Current URL is: http://localhost:6111/app/home#/
[00:13:46]               │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/homepage app Kibana takes you home clicking on kibana logo should take you to home page.html
[00:13:46]               └- ✖ fail: "homepage app Kibana takes you home clicking on kibana logo should take you to home page"
[00:13:46]               │

Stack Trace

Error: expected testSubject(globalLoadingIndicator-hidden) to exist
    at TestSubjects.existOrFail (test/functional/services/common/test_subjects.ts:62:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream