[ML] Fixes anomaly charts for rare detectors when model plot is enabled #66075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jgowdyelastic
approved these changes
May 12, 2020
| 'info_content', | ||
| 'high_info_content', | ||
| 'low_info_content', | ||
| ].includes(functionName) === true); |
Member
There was a problem hiding this comment.
this could be converted to use the constants from kibana/x-pack/plugins/ml/common/constants/aggregation_types.ts
Contributor
Author
There was a problem hiding this comment.
Agreed, although will save this for a follow-up as I wanted to keep the code churn in this fix to a minimum. I suspect there are a lot of places in the code where we use hard-coded function names which could be switched to the constants from kibana/x-pack/plugins/ml/common/constants/aggregation_types.ts.
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 12, 2020
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 12, 2020
peteharverson
added a commit
that referenced
this pull request
May 12, 2020
peteharverson
added a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65080, hiding the charts in the Anomaly Explorer, and the link to the Single Metric Viewer, for
rare by mlcategorydetectors where model plot is enabled. Charting for this combination of detector and model plot is not supported.Also adds an extra check into the Single Metric Viewer, to use the underlying metric data for
raredetectors (when not split bymlcategory) even when model plot is enabled for the job, since model plot results are not generated by the back-end forraredetectors.Note there is existing issue with the entity dropdown(s) in the Single Metric Viewer, which are currently not populated for
raredetectors when model plot is enabled. This will be fixed in a follow-up.Checklist
Fixes #65080