From b270146b0a4e0762b6adeb45f599c9cc13a700bc Mon Sep 17 00:00:00 2001
From: Jimmy Jones <jimmyjones2@gmx.co.uk>
Date: Tue, 9 Feb 2016 20:03:30 +0000
Subject: [PATCH 1/4] Add field exists filter button to doc table

---
 src/plugins/kbn_doc_views/public/views/table.html | 9 +++++++++
 src/plugins/kbn_doc_views/public/views/table.js   | 3 ++-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/plugins/kbn_doc_views/public/views/table.html b/src/plugins/kbn_doc_views/public/views/table.html
index b08a66f781365..e308e69c6be54 100644
--- a/src/plugins/kbn_doc_views/public/views/table.html
+++ b/src/plugins/kbn_doc_views/public/views/table.html
@@ -27,6 +27,15 @@
             tooltip-append-to-body="1"
             class="fa fa-columns"></i>
         </span>
+        <span ng-if="!indexPattern.metaFields.includes(field)">
+          <i ng-click="updateFilterInQuery('_exists_', field, '+')"
+            tooltip="Filter for field present"
+            tooltip-append-to-body="1"
+            class="fa fa-check-square-o"></i>
+        </span>
+        <span ng-if="indexPattern.metaFields.includes(field)" tooltip="Unable to filter for presence of meta fields">
+          <i class="fa fa-check-square-o text-muted"></i>
+        </span>
       </td>
 
       <td>
diff --git a/src/plugins/kbn_doc_views/public/views/table.js b/src/plugins/kbn_doc_views/public/views/table.js
index c0ebc4b8edf6b..bbaf0cc650b70 100644
--- a/src/plugins/kbn_doc_views/public/views/table.js
+++ b/src/plugins/kbn_doc_views/public/views/table.js
@@ -13,7 +13,8 @@ docViewsRegistry.register(function () {
         hit: '=',
         indexPattern: '=',
         filter: '=',
-        columns: '='
+        columns: '=',
+        updateFilterInQuery: '=filter'
       },
       controller: function ($scope) {
         $scope.mapping = $scope.indexPattern.fields.byName;

From ebadcaa94568ed13fb573be4ea1f8e8023d732a0 Mon Sep 17 00:00:00 2001
From: Jimmy Jones <jimmyjones2@gmx.co.uk>
Date: Sat, 13 Feb 2016 15:17:44 +0000
Subject: [PATCH 2/4] Switch to asterisk as suggested by @spalger

---
 src/plugins/kbn_doc_views/public/views/table.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/kbn_doc_views/public/views/table.html b/src/plugins/kbn_doc_views/public/views/table.html
index e308e69c6be54..d10f7b6f3eb64 100644
--- a/src/plugins/kbn_doc_views/public/views/table.html
+++ b/src/plugins/kbn_doc_views/public/views/table.html
@@ -31,10 +31,10 @@
           <i ng-click="updateFilterInQuery('_exists_', field, '+')"
             tooltip="Filter for field present"
             tooltip-append-to-body="1"
-            class="fa fa-check-square-o"></i>
+            class="fa fa-asterisk"></i>
         </span>
         <span ng-if="indexPattern.metaFields.includes(field)" tooltip="Unable to filter for presence of meta fields">
-          <i class="fa fa-check-square-o text-muted"></i>
+          <i class="fa fa-asterisk text-muted"></i>
         </span>
       </td>
 

From 65feedb90aa9572c3eb80b138f21c892131c53cc Mon Sep 17 00:00:00 2001
From: Jimmy Jones <jimmyjones2@gmx.co.uk>
Date: Sat, 16 Apr 2016 22:09:48 +0100
Subject: [PATCH 3/4] Add testcases for field exists filter

---
 src/plugins/kbn_doc_views/public/__tests__/doc_views.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/plugins/kbn_doc_views/public/__tests__/doc_views.js b/src/plugins/kbn_doc_views/public/__tests__/doc_views.js
index 76643b9baa6d1..c931996d53a22 100644
--- a/src/plugins/kbn_doc_views/public/__tests__/doc_views.js
+++ b/src/plugins/kbn_doc_views/public/__tests__/doc_views.js
@@ -106,6 +106,8 @@ describe('docViews', function () {
         expect($scope.filter.calledOnce).to.be(true);
         cell.find('.fa-search-minus').first().click();
         expect($scope.filter.calledTwice).to.be(true);
+        cell.find('.fa-asterisk').first().click();
+        expect($scope.filter.calledThrice).to.be(true);
       });
 
       it('should NOT apply a filter when clicking non-filterable fields', function () {
@@ -115,6 +117,8 @@ describe('docViews', function () {
         expect($scope.filter.calledOnce).to.be(false);
         cell.find('.fa-search-minus').first().click();
         expect($scope.filter.calledTwice).to.be(false);
+        cell.find('.fa-asterisk').first().click();
+        expect($scope.filter.calledOnce).to.be(true);
       });
     });
 

From 729f37567e06ac13827d971fc0f80651c88b0dab Mon Sep 17 00:00:00 2001
From: Jimmy Jones <jimmyjones2@gmx.co.uk>
Date: Sun, 1 May 2016 14:30:06 +0100
Subject: [PATCH 4/4] Use filter directly

---
 src/plugins/kbn_doc_views/public/views/table.html | 2 +-
 src/plugins/kbn_doc_views/public/views/table.js   | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/plugins/kbn_doc_views/public/views/table.html b/src/plugins/kbn_doc_views/public/views/table.html
index d10f7b6f3eb64..e3e474b21f5f5 100644
--- a/src/plugins/kbn_doc_views/public/views/table.html
+++ b/src/plugins/kbn_doc_views/public/views/table.html
@@ -28,7 +28,7 @@
             class="fa fa-columns"></i>
         </span>
         <span ng-if="!indexPattern.metaFields.includes(field)">
-          <i ng-click="updateFilterInQuery('_exists_', field, '+')"
+          <i ng-click="filter('_exists_', field, '+')"
             tooltip="Filter for field present"
             tooltip-append-to-body="1"
             class="fa fa-asterisk"></i>
diff --git a/src/plugins/kbn_doc_views/public/views/table.js b/src/plugins/kbn_doc_views/public/views/table.js
index 734436d06d114..af201f39c3539 100644
--- a/src/plugins/kbn_doc_views/public/views/table.js
+++ b/src/plugins/kbn_doc_views/public/views/table.js
@@ -13,8 +13,7 @@ docViewsRegistry.register(function () {
         hit: '=',
         indexPattern: '=',
         filter: '=',
-        columns: '=',
-        updateFilterInQuery: '=filter'
+        columns: '='
       },
       controller: function ($scope) {
         $scope.mapping = $scope.indexPattern.fields.byName;