Default duration to minutes, only show alerting on metrics explorer #61058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipb
added
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
Zacqary
approved these changes
Mar 24, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Mar 24, 2020
phillipb
added a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The alert flyout doesn't make sense on the inventory page. That page will likely require a different alert type that we'll be introducing in 7.8.
Also, since none of our metrics report at the "seconds" level, default the flyout to minutes. In the future, we should add a check that queries the backend to find the minimum duration for the metrics in the alert condition.