[NP] Remove ui/agg_types dependencies and move paginated table to kibana_legacy

src/dev/jest/config.js

@@ -49,8 +49,6 @@ export default {
     '!packages/kbn-ui-framework/src/services/**/*/index.js',
     'src/legacy/core_plugins/**/*.{js,jsx,ts,tsx}',
     '!src/legacy/core_plugins/**/{__test__,__snapshots__}/**/*',
-    'src/legacy/ui/public/{agg_types,vis}/**/*.{ts,tsx}',
-    '!src/legacy/ui/public/{agg_types,vis}/**/*.d.ts',
   ],
   moduleNameMapper: {
     '@elastic/eui$': '<rootDir>/node_modules/@elastic/eui/test-env',

src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_state.test.ts

@@ -25,13 +25,6 @@ import { InputTimeRange, TimefilterContract, TimeRange } from 'src/plugins/data/
 import { ViewMode } from 'src/plugins/embeddable/public';
 import { createKbnUrlStateStorage } from 'src/plugins/kibana_utils/public';
 
-jest.mock('ui/agg_types', () => ({
-  aggTypes: {
-    metrics: [],
-    buckets: [],
-  },
-}));
-
 describe('DashboardState', function() {
   let dashboardState: DashboardStateManager;
   const savedDashboard = getSavedDashboardMock();

src/legacy/core_plugins/kibana/public/discover/kibana_services.ts

@@ -53,7 +53,6 @@ export { wrapInI18nContext } from 'ui/i18n';
 import { search } from '../../../../../plugins/data/public';
 export const { getRequestInspectorStats, getResponseInspectorStats, tabifyAggResponse } = search;
 // @ts-ignore
-export { intervalOptions } from 'ui/agg_types';
 export { subscribeWithScope } from '../../../../../plugins/kibana_legacy/public';
 // @ts-ignore
 export { timezoneProvider } from 'ui/vis/lib/timezone';

src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

@@ -44,7 +44,6 @@ import {
   getRequestInspectorStats,
   getResponseInspectorStats,
   getServices,
-  intervalOptions,
   unhashUrl,
   subscribeWithScope,
   tabifyAggResponse,
@@ -76,6 +75,7 @@ import {
   connectToQueryState,
   syncQueryStateWithUrl,
   getDefaultQuery,
+  search,
 } from '../../../../../../../plugins/data/public';
 import { getIndexPatternId } from '../helpers/get_index_pattern_id';
 import { addFatalError } from '../../../../../../../plugins/kibana_legacy/public';
@@ -286,7 +286,7 @@ function discoverController(
       mode: 'absolute',
     });
   };
-  $scope.intervalOptions = intervalOptions;
+  $scope.intervalOptions = search.aggs.intervalOptions;
   $scope.minimumVisibleRows = 50;
   $scope.fetchStatus = fetchStatuses.UNINITIALIZED;
   $scope.showSaveQuery = uiCapabilities.discover.saveQuery;

src/legacy/core_plugins/kibana/public/kibana.js

@@ -48,7 +48,6 @@ import './dashboard/legacy';
 import './management';
 import './dev_tools';
 import 'ui/agg_response';
-import 'ui/agg_types';
 import { showAppRedirectNotification } from '../../../../plugins/kibana_legacy/public';
 import 'leaflet';
 import { localApplicationService } from './local_application_service';

src/legacy/core_plugins/region_map/public/region_map_type.js

@@ -18,12 +18,12 @@
  */
 import React from 'react';
 import { i18n } from '@kbn/i18n';
-import { Schemas } from 'ui/agg_types';
 import { mapToLayerWithId } from './util';
 import { createRegionMapVisualization } from './region_map_visualization';
 import { Status } from '../../visualizations/public';
 import { RegionMapOptions } from './components/region_map_options';
 import { truncatedColorSchemas } from '../../../../plugins/charts/public';
+import { Schemas } from '../../vis_default_editor/public';
 
 // TODO: reference to TILE_MAP plugin should be removed
 import { ORIGIN } from '../../tile_map/common/origin';

src/legacy/core_plugins/tile_map/public/tile_map_type.js

@@ -21,8 +21,8 @@ import React from 'react';
 import { i18n } from '@kbn/i18n';
 
 import { convertToGeoJson } from 'ui/vis/map/convert_to_geojson';
-import { Schemas } from 'ui/agg_types';
 
+import { Schemas } from '../../vis_default_editor/public';
 import { Status } from '../../visualizations/public';
 import { createTileMapVisualization } from './tile_map_visualization';
 import { TileMapOptions } from './components/tile_map_options';

src/legacy/core_plugins/vis_default_editor/public/components/agg.test.tsx

@@ -21,17 +21,14 @@ import React from 'react';
 import { mount, shallow } from 'enzyme';
 import { act } from 'react-dom/test-utils';
 
-import { IndexPattern } from 'src/plugins/data/public';
+import { IndexPattern, IAggType, AggGroupNames } from 'src/plugins/data/public';
 import { VisState } from 'src/legacy/core_plugins/visualizations/public';
 
-import { IAggType, AggGroupNames } from '../legacy_imports';
 import { DefaultEditorAgg, DefaultEditorAggProps } from './agg';
 import { DefaultEditorAggParams } from './agg_params';
 import { AGGS_ACTION_KEYS } from './agg_group_state';
 import { Schema } from '../schemas';
 
-jest.mock('ui/new_platform');
-
 jest.mock('./agg_params', () => ({
   DefaultEditorAggParams: () => null,
 }));

src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx

@@ -28,7 +28,7 @@ import {
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
-import { IAggConfig } from '../legacy_imports';
+import { IAggConfig } from 'src/plugins/data/public';
 import { DefaultEditorAggParams } from './agg_params';
 import { DefaultEditorAggCommonProps } from './agg_common_props';
 import { AGGS_ACTION_KEYS, AggsAction } from './agg_group_state';

src/legacy/core_plugins/vis_default_editor/public/components/agg_add.tsx

@@ -29,7 +29,7 @@ import {
 } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
-import { IAggConfig, AggGroupNames } from '../legacy_imports';
+import { IAggConfig, AggGroupNames } from '../../../../../plugins/data/public';
 import { Schema } from '../schemas';
 
 interface DefaultEditorAggAddProps {

src/legacy/core_plugins/vis_default_editor/public/components/agg_common_props.ts

@@ -18,7 +18,7 @@
  */
 
 import { VisState, VisParams } from 'src/legacy/core_plugins/visualizations/public';
-import { IAggType, IAggConfig, IAggGroupNames } from '../legacy_imports';
+import { IAggType, IAggConfig, IAggGroupNames } from 'src/plugins/data/public';
 import { Schema } from '../schemas';
 
 type AggId = IAggConfig['id'];

src/legacy/core_plugins/vis_default_editor/public/components/agg_group.test.tsx

@@ -21,7 +21,7 @@ import React from 'react';
 import { mount, shallow } from 'enzyme';
 import { act } from 'react-dom/test-utils';
 import { VisState } from 'src/legacy/core_plugins/visualizations/public';
-import { IAggConfigs, IAggConfig } from '../legacy_imports';
+import { IAggConfigs, IAggConfig } from 'src/plugins/data/public';
 import { DefaultEditorAggGroup, DefaultEditorAggGroupProps } from './agg_group';
 import { DefaultEditorAgg } from './agg';
 import { DefaultEditorAggAdd } from './agg_add';
@@ -36,17 +36,6 @@ jest.mock('@elastic/eui', () => ({
   EuiPanel: 'eui-panel',
 }));
 
-jest.mock('../legacy_imports', () => ({
-  aggGroupNamesMap: () => ({
-    metrics: 'Metrics',
-    buckets: 'Buckets',
-  }),
-  AggGroupNames: {
-    Metrics: 'metrics',
-    Buckets: 'buckets',
-  },
-}));
-
 jest.mock('./agg', () => ({
   DefaultEditorAgg: () => <div />,
 }));

src/legacy/core_plugins/vis_default_editor/public/components/agg_group.tsx

@@ -30,7 +30,7 @@ import {
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
-import { IAggConfig, aggGroupNamesMap, AggGroupNames } from '../legacy_imports';
+import { AggGroupNames, search, IAggConfig } from '../../../../../plugins/data/public';
 import { DefaultEditorAgg } from './agg';
 import { DefaultEditorAggAdd } from './agg_add';
 import { AddSchema, ReorderAggs, DefaultEditorAggCommonProps } from './agg_common_props';
@@ -68,7 +68,7 @@ function DefaultEditorAggGroup({
   setTouched,
   setValidity,
 }: DefaultEditorAggGroupProps) {
-  const groupNameLabel = (aggGroupNamesMap() as any)[groupName];
+  const groupNameLabel = (search.aggs.aggGroupNamesMap() as any)[groupName];
   // e.g. buckets can have no aggs
   const schemaNames = getSchemasByGroup(schemas, groupName).map(s => s.name);
   const group: IAggConfig[] = useMemo(

src/legacy/core_plugins/vis_default_editor/public/components/agg_group_helper.test.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { IAggConfig } from '../legacy_imports';
+import { IAggConfig } from 'src/plugins/data/public';
 import {
   isAggRemovable,
   calcAggIsTooLow,

src/legacy/core_plugins/vis_default_editor/public/components/agg_group_helper.tsx

@@ -18,7 +18,7 @@
  */
 
 import { findIndex, isEmpty } from 'lodash';
-import { IAggConfig } from '../legacy_imports';
+import { IAggConfig } from 'src/plugins/data/public';
 import { AggsState } from './agg_group_state';
 import { Schema, getSchemaByName } from '../schemas';
 

src/legacy/core_plugins/vis_default_editor/public/components/agg_group_state.tsx

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { IAggConfig } from '../legacy_imports';
+import { IAggConfig } from 'src/plugins/data/public';
 
 export enum AGGS_ACTION_KEYS {
   TOUCHED = 'aggsTouched',

src/legacy/core_plugins/vis_default_editor/public/components/agg_param_props.ts

@@ -17,9 +17,8 @@
  * under the License.
  */
 
-import { IndexPatternField } from 'src/plugins/data/public';
+import { IAggConfig, AggParam, IndexPatternField } from 'src/plugins/data/public';
 import { VisState } from 'src/legacy/core_plugins/visualizations/public';
-import { IAggConfig, AggParam } from '../legacy_imports';
 import { ComboBoxGroupedOptions } from '../utils';
 import { EditorConfig } from './utils';
 import { Schema } from '../schemas';

src/legacy/core_plugins/vis_default_editor/public/components/agg_params.test.tsx

@@ -21,9 +21,8 @@ import React from 'react';
 import { mount, shallow } from 'enzyme';
 
 import { VisState } from 'src/legacy/core_plugins/visualizations/public';
-import { IndexPattern } from 'src/plugins/data/public';
+import { IndexPattern, IAggConfig, AggGroupNames } from 'src/plugins/data/public';
 import { DefaultEditorAggParams, DefaultEditorAggParamsProps } from './agg_params';
-import { IAggConfig, AggGroupNames } from '../legacy_imports';
 
 const mockEditorConfig = {
   useNormalizedEsInterval: { hidden: false, fixedValue: false },
@@ -35,7 +34,6 @@ const mockEditorConfig = {
   },
 };
 
-jest.mock('ui/new_platform');
 jest.mock('./utils', () => ({
   getEditorConfig: jest.fn(() => mockEditorConfig),
 }));
@@ -70,6 +68,27 @@ jest.mock('./agg_select', () => ({
 jest.mock('./agg_param', () => ({
   DefaultEditorAggParam: () => null,
 }));
+jest.mock('../../../../../plugins/kibana_react/public', () => ({
+  useKibana: () => ({
+    services: {
+      data: {
+        search: {
+          aggs: {
+            types: {
+              getAll: () => [],
+            },
+          },
+          __LEGACY: {
+            aggTypeFieldFilters: {
+              filter: () => [],
+            },
+          },
+        },
+      },
+    },
+  }),
+  withKibana: (x: any) => x,
+}));
 
 describe('DefaultEditorAggParams component', () => {
   let setAggParamValue: jest.Mock;

src/legacy/core_plugins/vis_default_editor/public/components/agg_params.tsx

@@ -22,8 +22,7 @@ import { EuiForm, EuiAccordion, EuiSpacer } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import useUnmount from 'react-use/lib/useUnmount';
 
-import { IndexPattern } from 'src/plugins/data/public';
-import { IAggConfig, AggGroupNames } from '../legacy_imports';
+import { IAggConfig, IndexPattern, AggGroupNames } from '../../../../../plugins/data/public';
 
 import { DefaultEditorAggSelect } from './agg_select';
 import { DefaultEditorAggParam } from './agg_param';
@@ -41,6 +40,8 @@ import {
 import { DefaultEditorCommonProps } from './agg_common_props';
 import { EditorParamConfig, TimeIntervalParam, FixedParam, getEditorConfig } from './utils';
 import { Schema, getSchemaByName } from '../schemas';
+import { useKibana } from '../../../../../plugins/kibana_react/public';
+import { VisDefaultEditorKibanaServices } from '../types';
 
 const FIXED_VALUE_PROP = 'fixedValue';
 const DEFAULT_PROP = 'default';
@@ -83,18 +84,24 @@ function DefaultEditorAggParams({
   allowedAggs = [],
   hideCustomLabel = false,
 }: DefaultEditorAggParamsProps) {
-  const schema = getSchemaByName(schemas, agg.schema);
-  const { title } = schema;
-  const aggFilter = [...allowedAggs, ...(schema.aggFilter || [])];
+  const schema = useMemo(() => getSchemaByName(schemas, agg.schema), [agg.schema, schemas]);
+  const aggFilter = useMemo(() => [...allowedAggs, ...(schema.aggFilter || [])], [
+    allowedAggs,
+    schema.aggFilter,
+  ]);
+  const { services } = useKibana<VisDefaultEditorKibanaServices>();
+  const aggTypes = useMemo(() => services.data.search.aggs.types.getAll(), [
+    services.data.search.aggs.types,
+  ]);
   const groupedAggTypeOptions = useMemo(
-    () => getAggTypeOptions(agg, indexPattern, groupName, aggFilter),
-    [agg, indexPattern, groupName, aggFilter]
+    () => getAggTypeOptions(aggTypes, agg, indexPattern, groupName, aggFilter),
+    [aggTypes, agg, indexPattern, groupName, aggFilter]
   );
 
   const error = aggIsTooLow
     ? i18n.translate('visDefaultEditor.aggParams.errors.aggWrongRunOrderErrorMessage', {
         defaultMessage: '"{schema}" aggs must run before all other buckets!',
-        values: { schema: title },
+        values: { schema: schema.title },
       })
     : '';
   const aggTypeName = agg.type?.name;
@@ -105,8 +112,20 @@ function DefaultEditorAggParams({
     fieldName,
   ]);
   const params = useMemo(
-    () => getAggParamsToRender({ agg, editorConfig, metricAggs, state, schemas, hideCustomLabel }),
-    [agg, editorConfig, metricAggs, state, schemas, hideCustomLabel]
+    () =>
+      getAggParamsToRender(
+        { agg, editorConfig, metricAggs, state, schemas, hideCustomLabel },
+        services.data.search.__LEGACY.aggTypeFieldFilters
+      ),
+    [
+      agg,
+      editorConfig,
+      metricAggs,
+      state,
+      schemas,
+      hideCustomLabel,
+      services.data.search.__LEGACY.aggTypeFieldFilters,
+    ]
   );
   const allParams = [...params.basic, ...params.advanced];
   const [paramsState, onChangeParamsState] = useReducer(