diff --git a/.eslintrc b/.eslintrc index 6a291608cdf50..080d8cff32fc5 100644 --- a/.eslintrc +++ b/.eslintrc @@ -30,6 +30,7 @@ rules: no-bitwise: 0 no-caller: 2 no-cond-assign: 0 + no-const-assign: 2 no-debugger: 2 no-empty: 2 no-eval: 2 diff --git a/src/plugins/devMode/public/ngMock.js b/src/plugins/devMode/public/ngMock.js index 1b884163e85a9..edfa8f8345287 100644 --- a/src/plugins/devMode/public/ngMock.js +++ b/src/plugins/devMode/public/ngMock.js @@ -1,4 +1,4 @@ -var angular = require('angular'); +const angular = require('angular'); if (angular.mocks) { throw new Error( 'Don\'t require angular-mocks directly or the tests ' + diff --git a/src/plugins/elasticsearch/lib/__tests__/check_es_version.js b/src/plugins/elasticsearch/lib/__tests__/check_es_version.js index 6518d8ff193c5..4af5dc0b4422d 100644 --- a/src/plugins/elasticsearch/lib/__tests__/check_es_version.js +++ b/src/plugins/elasticsearch/lib/__tests__/check_es_version.js @@ -1,17 +1,17 @@ -var _ = require('lodash'); -var Promise = require('bluebird'); -var sinon = require('sinon'); +const _ = require('lodash'); +const Promise = require('bluebird'); +const sinon = require('sinon'); -var checkEsVersion = require('../check_es_version'); +const checkEsVersion = require('../check_es_version'); describe('plugins/elasticsearch', function () { describe('lib/check_es_version', function () { - var server; - var plugin; + let server; + let plugin; beforeEach(function () { - var get = sinon.stub().withArgs('elasticsearch.engineVersion').returns('^1.4.3'); - var config = function () { return { get: get }; }; + const get = sinon.stub().withArgs('elasticsearch.engineVersion').returns('^1.4.3'); + const config = function () { return { get: get }; }; server = { log: _.noop, config: config, @@ -30,15 +30,15 @@ describe('plugins/elasticsearch', function () { }); function setNodes(/* ...versions */) { - var versions = _.shuffle(arguments); - var nodes = {}; - var i = 0; + const versions = _.shuffle(arguments); + const nodes = {}; + let i = 0; while (versions.length) { - var name = 'node-' + (++i); - var version = versions.shift(); + const name = 'node-' + (++i); + const version = versions.shift(); - var node = { + const node = { version: version, http_address: 'http_address', ip: 'ip' @@ -48,7 +48,7 @@ describe('plugins/elasticsearch', function () { nodes[name] = node; } - var client = server.plugins.elasticsearch.client; + const client = server.plugins.elasticsearch.client; client.nodes.info = sinon.stub().returns(Promise.resolve({ nodes: nodes })); } diff --git a/src/plugins/elasticsearch/lib/__tests__/create_kibana_index.js b/src/plugins/elasticsearch/lib/__tests__/create_kibana_index.js index 8e2648b7dc0a7..18d0061282312 100644 --- a/src/plugins/elasticsearch/lib/__tests__/create_kibana_index.js +++ b/src/plugins/elasticsearch/lib/__tests__/create_kibana_index.js @@ -1,21 +1,21 @@ -var _ = require('lodash'); -var sinon = require('sinon'); -var expect = require('expect.js'); -var Promise = require('bluebird'); +const _ = require('lodash'); +const sinon = require('sinon'); +const expect = require('expect.js'); +const Promise = require('bluebird'); -var createKibanaIndex = require('../create_kibana_index'); -var SetupError = require('../setup_error'); +const createKibanaIndex = require('../create_kibana_index'); +const SetupError = require('../setup_error'); describe('plugins/elasticsearch', function () { describe('lib/create_kibana_index', function () { - var server; - var client; + let server; + let client; beforeEach(function () { server = {}; client = {}; - var config = { kibana: { index: '.my-kibana' } }; - var get = sinon.stub(); + let config = { kibana: { index: '.my-kibana' } }; + const get = sinon.stub(); get.returns(config); get.withArgs('kibana.index').returns(config.kibana.index); config = function () { return { get: get }; }; @@ -33,16 +33,16 @@ describe('plugins/elasticsearch', function () { }); it('should check cluster.health upon successful index creation', function () { - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.then(function () { sinon.assert.calledOnce(client.cluster.health); }); }); it('should be created with mappings for config.buildNum', function () { - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.then(function () { - var params = client.indices.create.args[0][0]; + const params = client.indices.create.args[0][0]; expect(params) .to.have.property('body'); expect(params.body) @@ -61,9 +61,9 @@ describe('plugins/elasticsearch', function () { }); it('should be created with 1 shard and default replica', function () { - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.then(function () { - var params = client.indices.create.args[0][0]; + const params = client.indices.create.args[0][0]; expect(params) .to.have.property('body'); expect(params.body) @@ -76,9 +76,9 @@ describe('plugins/elasticsearch', function () { }); it('should be created with index name set in the config', function () { - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.then(function () { - var params = client.indices.create.args[0][0]; + const params = client.indices.create.args[0][0]; expect(params) .to.have.property('index', '.my-kibana'); }); @@ -89,18 +89,18 @@ describe('plugins/elasticsearch', function () { describe('failure requests', function () { it('should reject with a SetupError', function () { - var error = new Error('Oops!'); + const error = new Error('Oops!'); client.indices.create.returns(Promise.reject(error)); - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.catch(function (err) { expect(err).to.be.a(SetupError); }); }); it('should reject with an error if index creation fails', function () { - var error = new Error('Oops!'); + const error = new Error('Oops!'); client.indices.create.returns(Promise.reject(error)); - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.catch(function (err) { expect(err.message).to.be('Unable to create Kibana index ".my-kibana"'); expect(err).to.have.property('origError', error); @@ -109,10 +109,10 @@ describe('plugins/elasticsearch', function () { it('should reject with an error if health check fails', function () { - var error = new Error('Oops!'); + const error = new Error('Oops!'); client.indices.create.returns(Promise.resolve()); client.cluster.health.returns(Promise.reject(error)); - var fn = createKibanaIndex(server); + const fn = createKibanaIndex(server); return fn.catch(function (err) { expect(err.message).to.be('Waiting for Kibana index ".my-kibana" to come online failed.'); expect(err).to.have.property('origError', error); diff --git a/src/plugins/elasticsearch/lib/__tests__/findPort.js b/src/plugins/elasticsearch/lib/__tests__/findPort.js index 1448058586e68..b346ac805aeac 100644 --- a/src/plugins/elasticsearch/lib/__tests__/findPort.js +++ b/src/plugins/elasticsearch/lib/__tests__/findPort.js @@ -1,5 +1,5 @@ -var Promise = require('bluebird'); -var portscanner = require('portscanner'); +const Promise = require('bluebird'); +const portscanner = require('portscanner'); module.exports = function findPort(start, end, host) { host = host || 'localhost'; diff --git a/src/plugins/elasticsearch/lib/__tests__/health_check.js b/src/plugins/elasticsearch/lib/__tests__/health_check.js index 87b9cf6e916a6..da66b836832df 100644 --- a/src/plugins/elasticsearch/lib/__tests__/health_check.js +++ b/src/plugins/elasticsearch/lib/__tests__/health_check.js @@ -1,18 +1,18 @@ -var Promise = require('bluebird'); -var sinon = require('sinon'); -var expect = require('expect.js'); -var NoConnections = require('elasticsearch').errors.NoConnections; +const Promise = require('bluebird'); +const sinon = require('sinon'); +const expect = require('expect.js'); +const NoConnections = require('elasticsearch').errors.NoConnections; -var healthCheck = require('../health_check'); +const healthCheck = require('../health_check'); describe('plugins/elasticsearch', function () { describe('lib/health_check', function () { - var health; - var plugin; - var server; - var get; - var client; + let health; + let plugin; + let server; + let get; + let client; beforeEach(function () { // setup the plugin stub diff --git a/src/plugins/elasticsearch/lib/__tests__/routes.js b/src/plugins/elasticsearch/lib/__tests__/routes.js index aa07af2dc3848..e5534c478d6b1 100644 --- a/src/plugins/elasticsearch/lib/__tests__/routes.js +++ b/src/plugins/elasticsearch/lib/__tests__/routes.js @@ -1,15 +1,15 @@ -var expect = require('expect.js'); -var util = require('util'); -var requireFromTest = require('requirefrom')('test'); -var kbnTestServer = requireFromTest('utils/kbn_server'); +const expect = require('expect.js'); +const util = require('util'); +const requireFromTest = require('requirefrom')('test'); +const kbnTestServer = requireFromTest('utils/kbn_server'); -var format = util.format; +const format = util.format; describe('plugins/elasticsearch', function () { describe('routes', function () { - var kbnServer; + let kbnServer; before(function () { kbnServer = kbnTestServer.createServer(); @@ -28,7 +28,7 @@ describe('plugins/elasticsearch', function () { options.payload = JSON.stringify(options.payload); } - var statusCode = options.statusCode || 200; + const statusCode = options.statusCode || 200; describe(format('%s %s', options.method, options.url), function () { it('should should return ' + statusCode, function (done) { kbnTestServer.makeRequest(kbnServer, options, function (res) { diff --git a/src/plugins/elasticsearch/lib/__tests__/setup_error.js b/src/plugins/elasticsearch/lib/__tests__/setup_error.js index 15f8f73129dc7..2047d93893108 100644 --- a/src/plugins/elasticsearch/lib/__tests__/setup_error.js +++ b/src/plugins/elasticsearch/lib/__tests__/setup_error.js @@ -1,10 +1,10 @@ -var SetupError = require('../setup_error'); -var expect = require('expect.js'); +const SetupError = require('../setup_error'); +const expect = require('expect.js'); describe('plugins/elasticsearch', function () { describe('lib/setup_error', function () { - var server = { + const server = { config: function () { return { get: function () { @@ -14,7 +14,7 @@ describe('plugins/elasticsearch', function () { } }; - var err = new SetupError(server, 'Oops! <%= kibana.index %>'); + const err = new SetupError(server, 'Oops! <%= kibana.index %>'); it('should allow config values in the message template', function () { expect(err).to.have.property('message', 'Oops! .my-kibana'); @@ -30,19 +30,19 @@ describe('plugins/elasticsearch', function () { }); it('should return the passed error if it is a SetupError', function () { - var error = new SetupError(server, 'Oh Boy!', err); + const error = new SetupError(server, 'Oh Boy!', err); expect(error).to.have.property('message', 'Oops! .my-kibana'); }); it('should store the original error', function () { - var origError = new Error('Boom!'); - var error = new SetupError(server, 'Oh Boy!', origError); + const origError = new Error('Boom!'); + const error = new SetupError(server, 'Oh Boy!', origError); expect(error).to.have.property('origError', origError); }); it('should copy the stack from the origError', function () { - var origError = new Error('Boom!'); - var error = new SetupError(server, 'Oh Boy!', origError); + const origError = new Error('Boom!'); + const error = new SetupError(server, 'Oh Boy!', origError); expect(error).to.have.property('stack', origError.stack); }); diff --git a/src/plugins/elasticsearch/lib/__tests__/upgrade_config.js b/src/plugins/elasticsearch/lib/__tests__/upgrade_config.js index fcd5903c0c631..debe242ee8919 100644 --- a/src/plugins/elasticsearch/lib/__tests__/upgrade_config.js +++ b/src/plugins/elasticsearch/lib/__tests__/upgrade_config.js @@ -1,17 +1,17 @@ -var _ = require('lodash'); -var Promise = require('bluebird'); -var sinon = require('sinon'); -var expect = require('expect.js'); +const _ = require('lodash'); +const Promise = require('bluebird'); +const sinon = require('sinon'); +const expect = require('expect.js'); -var upgradeConfig = require('../upgrade_config'); +const upgradeConfig = require('../upgrade_config'); describe('plugins/elasticsearch', function () { describe('lib/upgrade_config', function () { - var get; - var server; - var client; - var config; - var upgrade; + let get; + let server; + let client; + let config; + let upgrade; beforeEach(function () { get = sinon.stub(); @@ -32,7 +32,7 @@ describe('plugins/elasticsearch', function () { }); describe('nothing is found', function () { - var response = { hits: { hits:[] } }; + const response = { hits: { hits:[] } }; beforeEach(function () { client.create.returns(Promise.resolve()); @@ -48,14 +48,14 @@ describe('plugins/elasticsearch', function () { it('should resolve buildNum to pkg.buildNum config', function () { return upgrade(response).then(function (resp) { sinon.assert.calledOnce(client.create); - var params = client.create.args[0][0]; + const params = client.create.args[0][0]; expect(params.body).to.have.property('buildNum', get('pkg.buildNum')); }); }); it('should resolve version to pkg.version config', function () { return upgrade(response).then(function (resp) { - var params = client.create.args[0][0]; + const params = client.create.args[0][0]; expect(params).to.have.property('id', get('pkg.version')); }); }); @@ -70,14 +70,14 @@ describe('plugins/elasticsearch', function () { it('should resolve buildNum to pkg.buildNum config', function () { return upgrade(response).then(function (resp) { - var params = client.create.args[0][0]; + const params = client.create.args[0][0]; expect(params.body).to.have.property('buildNum', get('pkg.buildNum')); }); }); it('should resolve version to pkg.version config', function () { return upgrade(response).then(function (resp) { - var params = client.create.args[0][0]; + const params = client.create.args[0][0]; expect(params).to.have.property('id', get('pkg.version')); }); }); @@ -85,14 +85,14 @@ describe('plugins/elasticsearch', function () { }); it('should resolve with undefined if the current version is found', function () { - var response = { hits: { hits: [ { _id: '4.0.1' } ] } }; + const response = { hits: { hits: [ { _id: '4.0.1' } ] } }; return upgrade(response).then(function (resp) { expect(resp).to.be(undefined); }); }); it('should resolve with undefined if the nothing is upgradeable', function () { - var response = { hits: { hits: [ { _id: '4.0.1-beta1' }, { _id: '4.0.0-snapshot1' } ] } }; + const response = { hits: { hits: [ { _id: '4.0.1-beta1' }, { _id: '4.0.0-snapshot1' } ] } }; return upgrade(response).then(function (resp) { expect(resp).to.be(undefined); }); @@ -101,10 +101,10 @@ describe('plugins/elasticsearch', function () { it('should update the build number on the new config', function () { get.withArgs('pkg.buildNum').returns(5801); client.create.returns(Promise.resolve()); - var response = { hits: { hits: [ { _id: '4.0.0', _source: { buildNum: 1 } } ] } }; + const response = { hits: { hits: [ { _id: '4.0.0', _source: { buildNum: 1 } } ] } }; return upgrade(response).then(function (resp) { sinon.assert.calledOnce(client.create); - var params = client.create.args[0][0]; + const params = client.create.args[0][0]; expect(params).to.have.property('body'); expect(params.body).to.have.property('buildNum', 5801); expect(params).to.have.property('index', '.my-kibana'); @@ -116,11 +116,11 @@ describe('plugins/elasticsearch', function () { it('should log a message for upgrades', function () { get.withArgs('pkg.buildNum').returns(5801); client.create.returns(Promise.resolve()); - var response = { hits: { hits: [ { _id: '4.0.0', _source: { buildNum: 1 } } ] } }; + const response = { hits: { hits: [ { _id: '4.0.0', _source: { buildNum: 1 } } ] } }; return upgrade(response).then(function (resp) { sinon.assert.calledOnce(server.log); expect(server.log.args[0][0]).to.eql(['plugin', 'elasticsearch']); - var msg = server.log.args[0][1]; + const msg = server.log.args[0][1]; expect(msg).to.have.property('prevVersion', '4.0.0'); expect(msg).to.have.property('newVersion', '4.0.1'); expect(msg.tmpl).to.contain('Upgrade'); @@ -130,10 +130,10 @@ describe('plugins/elasticsearch', function () { it('should copy attributes from old config', function () { get.withArgs('pkg.buildNum').returns(5801); client.create.returns(Promise.resolve()); - var response = { hits: { hits: [ { _id: '4.0.0', _source: { buildNum: 1, defaultIndex: 'logstash-*' } } ] } }; + const response = { hits: { hits: [ { _id: '4.0.0', _source: { buildNum: 1, defaultIndex: 'logstash-*' } } ] } }; return upgrade(response).then(function (resp) { sinon.assert.calledOnce(client.create); - var params = client.create.args[0][0]; + const params = client.create.args[0][0]; expect(params).to.have.property('body'); expect(params.body).to.have.property('defaultIndex', 'logstash-*'); }); diff --git a/src/plugins/elasticsearch/lib/__tests__/version_satisfies.js b/src/plugins/elasticsearch/lib/__tests__/version_satisfies.js index 9b1b72d298817..20438a445d887 100644 --- a/src/plugins/elasticsearch/lib/__tests__/version_satisfies.js +++ b/src/plugins/elasticsearch/lib/__tests__/version_satisfies.js @@ -1,7 +1,7 @@ -var versionSatisfies = require('../version_satisfies'); -var expect = require('expect.js'); +const versionSatisfies = require('../version_satisfies'); +const expect = require('expect.js'); -var versionChecks = [ +const versionChecks = [ // order is: ['actual version', 'match expression', satisfied (true/false)] ['0.90.0', '>=0.90.0', true], ['1.2.0', '>=1.2.1 <2.0.0', false], @@ -30,10 +30,10 @@ var versionChecks = [ describe('plugins/elasticsearch', function () { describe('lib/version_satisfies', function () { versionChecks.forEach(function (spec) { - var actual = spec[0]; - var match = spec[1]; - var satisfied = spec[2]; - var desc = actual + ' satisfies ' + match; + const actual = spec[0]; + const match = spec[1]; + const satisfied = spec[2]; + const desc = actual + ' satisfies ' + match; describe(desc, function () { it('should be ' + satisfied, function () { diff --git a/src/plugins/elasticsearch/lib/check_es_version.js b/src/plugins/elasticsearch/lib/check_es_version.js index a3372a8c83cb9..c06c5e4c34cba 100644 --- a/src/plugins/elasticsearch/lib/check_es_version.js +++ b/src/plugins/elasticsearch/lib/check_es_version.js @@ -1,19 +1,19 @@ -var _ = require('lodash'); -var esBool = require('./es_bool'); -var versionSatisfies = require('./version_satisfies'); -var SetupError = require('./setup_error'); +const _ = require('lodash'); +const esBool = require('./es_bool'); +const versionSatisfies = require('./version_satisfies'); +const SetupError = require('./setup_error'); module.exports = function (server) { server.log(['plugin', 'debug'], 'Checking Elasticsearch version'); - var client = server.plugins.elasticsearch.client; - var engineVersion = server.config().get('elasticsearch.engineVersion'); + const client = server.plugins.elasticsearch.client; + const engineVersion = server.config().get('elasticsearch.engineVersion'); return client.nodes.info() .then(function (info) { - var badNodes = _.filter(info.nodes, function (node) { + const badNodes = _.filter(info.nodes, function (node) { // remove client nodes (Logstash) - var isClient = _.get(node, 'attributes.client'); + const isClient = _.get(node, 'attributes.client'); if (isClient != null && esBool(isClient) === true) { return false; } @@ -24,11 +24,11 @@ module.exports = function (server) { if (!badNodes.length) return true; - var badNodeNames = badNodes.map(function (node) { + const badNodeNames = badNodes.map(function (node) { return 'Elasticsearch v' + node.version + ' @ ' + node.http_address + ' (' + node.ip + ')'; }); - var message = `This version of Kibana requires Elasticsearch ` + + const message = `This version of Kibana requires Elasticsearch ` + `${engineVersion} on all nodes. I found ` + `the following incompatible nodes in your cluster: ${badNodeNames.join(',')}`; diff --git a/src/plugins/elasticsearch/lib/create_agent.js b/src/plugins/elasticsearch/lib/create_agent.js index 5fd7afc56be24..a7fc8c2b6b448 100644 --- a/src/plugins/elasticsearch/lib/create_agent.js +++ b/src/plugins/elasticsearch/lib/create_agent.js @@ -1,16 +1,16 @@ -var url = require('url'); -var _ = require('lodash'); -var readFile = (file) => require('fs').readFileSync(file, 'utf8'); -var http = require('http'); -var https = require('https'); +const url = require('url'); +const _ = require('lodash'); +const readFile = (file) => require('fs').readFileSync(file, 'utf8'); +const http = require('http'); +const https = require('https'); module.exports = _.memoize(function (server) { - var config = server.config(); - var target = url.parse(config.get('elasticsearch.url')); + const config = server.config(); + const target = url.parse(config.get('elasticsearch.url')); if (!/^https/.test(target.protocol)) return new http.Agent(); - var agentOptions = { + const agentOptions = { rejectUnauthorized: config.get('elasticsearch.ssl.verify') }; diff --git a/src/plugins/elasticsearch/lib/create_kibana_index.js b/src/plugins/elasticsearch/lib/create_kibana_index.js index d224afd3fb546..3d18eecf38490 100644 --- a/src/plugins/elasticsearch/lib/create_kibana_index.js +++ b/src/plugins/elasticsearch/lib/create_kibana_index.js @@ -1,8 +1,8 @@ -var SetupError = require('./setup_error'); -var format = require('util').format; +const SetupError = require('./setup_error'); +const format = require('util').format; module.exports = function (server) { - var client = server.plugins.elasticsearch.client; - var index = server.config().get('kibana.index'); + const client = server.plugins.elasticsearch.client; + const index = server.config().get('kibana.index'); function handleError(message) { return function (err) { diff --git a/src/plugins/elasticsearch/lib/create_proxy.js b/src/plugins/elasticsearch/lib/create_proxy.js index 90f8bde10f70b..29f613aa80475 100644 --- a/src/plugins/elasticsearch/lib/create_proxy.js +++ b/src/plugins/elasticsearch/lib/create_proxy.js @@ -1,10 +1,10 @@ -var createAgent = require('./create_agent'); -var mapUri = require('./map_uri'); -var { resolve } = require('url'); +const createAgent = require('./create_agent'); +const mapUri = require('./map_uri'); +const { resolve } = require('url'); function createProxy(server, method, route, config) { - var options = { + const options = { method: method, path: createProxy.createPath(route), handler: { diff --git a/src/plugins/elasticsearch/lib/es_bool.js b/src/plugins/elasticsearch/lib/es_bool.js index 4d9b679a69a6a..353520f3fea32 100644 --- a/src/plugins/elasticsearch/lib/es_bool.js +++ b/src/plugins/elasticsearch/lib/es_bool.js @@ -1,4 +1,4 @@ -var map = { +const map = { 'false': false, 'off': false, 'no': false, @@ -9,7 +9,7 @@ var map = { '1': true }; module.exports = function (str) { - var bool = map[String(str)]; + const bool = map[String(str)]; if (typeof bool !== 'boolean') { throw new TypeError('"' + str + '" does not map to an esBool'); } diff --git a/src/plugins/elasticsearch/lib/expose_client.js b/src/plugins/elasticsearch/lib/expose_client.js index 467081aef3f48..c45e6ce6167b6 100644 --- a/src/plugins/elasticsearch/lib/expose_client.js +++ b/src/plugins/elasticsearch/lib/expose_client.js @@ -1,12 +1,12 @@ -var elasticsearch = require('elasticsearch'); -var _ = require('lodash'); -var readFile = (file) => require('fs').readFileSync(file, 'utf8'); -var util = require('util'); -var url = require('url'); -var callWithRequest = require('./call_with_request'); +const elasticsearch = require('elasticsearch'); +const _ = require('lodash'); +const readFile = (file) => require('fs').readFileSync(file, 'utf8'); +const util = require('util'); +const url = require('url'); +const callWithRequest = require('./call_with_request'); module.exports = function (server) { - var config = server.config(); + const config = server.config(); function createClient(options) { options = _.defaults(options || {}, { @@ -22,14 +22,14 @@ module.exports = function (server) { auth: true }); - var uri = url.parse(options.url); + const uri = url.parse(options.url); - var authorization; + let authorization; if (options.auth && options.username && options.password) { uri.auth = util.format('%s:%s', options.username, options.password); } - var ssl = { rejectUnauthorized: options.verifySsl }; + const ssl = { rejectUnauthorized: options.verifySsl }; if (options.clientCrt && options.clientKey) { ssl.cert = readFile(options.clientCrt); ssl.key = readFile(options.clientKey); @@ -59,10 +59,10 @@ module.exports = function (server) { }); } - var client = createClient(); + const client = createClient(); server.on('close', _.bindKey(client, 'close')); - var noAuthClient = createClient({ auth: false }); + const noAuthClient = createClient({ auth: false }); server.on('close', _.bindKey(noAuthClient, 'close')); server.expose('client', client); diff --git a/src/plugins/elasticsearch/lib/health_check.js b/src/plugins/elasticsearch/lib/health_check.js index c15987d161c40..15fc7b686a656 100644 --- a/src/plugins/elasticsearch/lib/health_check.js +++ b/src/plugins/elasticsearch/lib/health_check.js @@ -1,23 +1,23 @@ -var _ = require('lodash'); -var Promise = require('bluebird'); -var elasticsearch = require('elasticsearch'); -var exposeClient = require('./expose_client'); -var migrateConfig = require('./migrate_config'); -var createKibanaIndex = require('./create_kibana_index'); -var checkEsVersion = require('./check_es_version'); -var NoConnections = elasticsearch.errors.NoConnections; -var util = require('util'); -var format = util.format; - -var NO_INDEX = 'no_index'; -var INITIALIZING = 'initializing'; -var READY = 'ready'; - -var REQUEST_DELAY = 2500; +const _ = require('lodash'); +const Promise = require('bluebird'); +const elasticsearch = require('elasticsearch'); +const exposeClient = require('./expose_client'); +const migrateConfig = require('./migrate_config'); +const createKibanaIndex = require('./create_kibana_index'); +const checkEsVersion = require('./check_es_version'); +const NoConnections = elasticsearch.errors.NoConnections; +const util = require('util'); +const format = util.format; + +const NO_INDEX = 'no_index'; +const INITIALIZING = 'initializing'; +const READY = 'ready'; + +const REQUEST_DELAY = 2500; module.exports = function (plugin, server) { - var config = server.config(); - var client = server.plugins.elasticsearch.client; + const config = server.config(); + const client = server.plugins.elasticsearch.client; plugin.status.yellow('Waiting for Elasticsearch'); @@ -90,12 +90,12 @@ module.exports = function (plugin, server) { .catch(err => plugin.status.red(err)); } - var timeoutId = null; + let timeoutId = null; function scheduleCheck(ms) { if (timeoutId) return; - var myId = setTimeout(function () { + const myId = setTimeout(function () { check().finally(function () { if (timeoutId === myId) startorRestartChecking(); }); diff --git a/src/plugins/elasticsearch/lib/is_upgradeable.js b/src/plugins/elasticsearch/lib/is_upgradeable.js index 3629faaa0b4ca..bb43aac87169d 100644 --- a/src/plugins/elasticsearch/lib/is_upgradeable.js +++ b/src/plugins/elasticsearch/lib/is_upgradeable.js @@ -1,19 +1,19 @@ -var semver = require('semver'); -var utils = require('requirefrom')('src/utils'); -var rcVersionRegex = /(\d+\.\d+\.\d+)\-rc(\d+)/i; +const semver = require('semver'); +const utils = require('requirefrom')('src/utils'); +const rcVersionRegex = /(\d+\.\d+\.\d+)\-rc(\d+)/i; module.exports = function (server, doc) { - var config = server.config(); + const config = server.config(); if (/beta|snapshot/i.test(doc._id)) return false; if (!doc._id) return false; if (doc._id === config.get('pkg.version')) return false; - var packageRcRelease = Infinity; - var rcRelease = Infinity; - var packageVersion = config.get('pkg.version'); - var version = doc._id; - var matches = doc._id.match(rcVersionRegex); - var packageMatches = config.get('pkg.version').match(rcVersionRegex); + let packageRcRelease = Infinity; + let rcRelease = Infinity; + let packageVersion = config.get('pkg.version'); + let version = doc._id; + const matches = doc._id.match(rcVersionRegex); + const packageMatches = config.get('pkg.version').match(rcVersionRegex); if (matches) { version = matches[1]; diff --git a/src/plugins/elasticsearch/lib/map_uri.js b/src/plugins/elasticsearch/lib/map_uri.js index de78529c05638..f7b1b327ee59e 100644 --- a/src/plugins/elasticsearch/lib/map_uri.js +++ b/src/plugins/elasticsearch/lib/map_uri.js @@ -1,15 +1,15 @@ -var querystring = require('querystring'); -var resolve = require('url').resolve; +const querystring = require('querystring'); +const resolve = require('url').resolve; module.exports = function mapUri(server, prefix) { - var config = server.config(); + const config = server.config(); return function (request, done) { - var path = request.path.replace('/elasticsearch', ''); - var url = config.get('elasticsearch.url'); + const path = request.path.replace('/elasticsearch', ''); + let url = config.get('elasticsearch.url'); if (path) { if (/\/$/.test(url)) url = url.substring(0, url.length - 1); url += path; } - var query = querystring.stringify(request.query); + const query = querystring.stringify(request.query); if (query) url += '?' + query; done(null, url); }; diff --git a/src/plugins/elasticsearch/lib/migrate_config.js b/src/plugins/elasticsearch/lib/migrate_config.js index 3d32bb2137908..632c7e69166c6 100644 --- a/src/plugins/elasticsearch/lib/migrate_config.js +++ b/src/plugins/elasticsearch/lib/migrate_config.js @@ -1,9 +1,9 @@ -var upgrade = require('./upgrade_config'); +const upgrade = require('./upgrade_config'); module.exports = function (server) { - var config = server.config(); - var client = server.plugins.elasticsearch.client; - var options = { + const config = server.config(); + const client = server.plugins.elasticsearch.client; + const options = { index: config.get('kibana.index'), type: 'config', body: { diff --git a/src/plugins/elasticsearch/lib/setup_error.js b/src/plugins/elasticsearch/lib/setup_error.js index 25c93badd3964..483b592c7a592 100644 --- a/src/plugins/elasticsearch/lib/setup_error.js +++ b/src/plugins/elasticsearch/lib/setup_error.js @@ -1,8 +1,8 @@ -var _ = require('lodash'); -var util = require('util'); +const _ = require('lodash'); +const util = require('util'); function SetupError(server, template, err) { - var config = server.config().get(); + const config = server.config().get(); // don't override other setup errors if (err && err instanceof SetupError) return err; Error.captureStackTrace(this, this.constructor); diff --git a/src/plugins/elasticsearch/lib/upgrade_config.js b/src/plugins/elasticsearch/lib/upgrade_config.js index 4defb84589da5..f8ff58334de3a 100644 --- a/src/plugins/elasticsearch/lib/upgrade_config.js +++ b/src/plugins/elasticsearch/lib/upgrade_config.js @@ -1,18 +1,18 @@ -var Promise = require('bluebird'); -var isUpgradeable = require('./is_upgradeable'); -var _ = require('lodash'); -var format = require('util').format; +const Promise = require('bluebird'); +const isUpgradeable = require('./is_upgradeable'); +const _ = require('lodash'); +const format = require('util').format; -var utils = require('requirefrom')('src/utils'); +const utils = require('requirefrom')('src/utils'); module.exports = function (server) { - var MAX_INTEGER = Math.pow(2, 53) - 1; + const MAX_INTEGER = Math.pow(2, 53) - 1; - var client = server.plugins.elasticsearch.client; - var config = server.config(); + const client = server.plugins.elasticsearch.client; + const config = server.config(); return function (response) { - var newConfig = {}; + const newConfig = {}; // Check to see if there are any doc. If not then we set the build number and id if (response.hits.hits.length === 0) { @@ -25,7 +25,7 @@ module.exports = function (server) { } // if we already have a the current version in the index then we need to stop - var devConfig = _.find(response.hits.hits, function currentVersion(hit) { + const devConfig = _.find(response.hits.hits, function currentVersion(hit) { return hit._id !== '@@version' && hit._id === config.get('pkg.version'); }); @@ -33,7 +33,7 @@ module.exports = function (server) { // Look for upgradeable configs. If none of them are upgradeable // then resolve with null. - var body = _.find(response.hits.hits, isUpgradeable.bind(null, server)); + const body = _.find(response.hits.hits, isUpgradeable.bind(null, server)); if (!body) return Promise.resolve(); // if the build number is still the template string (which it wil be in development) diff --git a/src/plugins/elasticsearch/lib/version_satisfies.js b/src/plugins/elasticsearch/lib/version_satisfies.js index b95956d5d3c06..eac84e2942c1c 100644 --- a/src/plugins/elasticsearch/lib/version_satisfies.js +++ b/src/plugins/elasticsearch/lib/version_satisfies.js @@ -1,15 +1,15 @@ -var semver = require('semver'); +const semver = require('semver'); module.exports = function (actual, expected) { try { - var ver = cleanVersion(actual); + const ver = cleanVersion(actual); return semver.satisfies(ver, expected); } catch (err) { return false; } function cleanVersion(version) { - var match = version.match(/\d+\.\d+\.\d+/); + const match = version.match(/\d+\.\d+\.\d+/); if (!match) return version; return match[0]; } diff --git a/src/plugins/kbn_vislib_vis_types/public/area.js b/src/plugins/kbn_vislib_vis_types/public/area.js index 9f94093e45627..e12b1b72ccafd 100644 --- a/src/plugins/kbn_vislib_vis_types/public/area.js +++ b/src/plugins/kbn_vislib_vis_types/public/area.js @@ -1,7 +1,7 @@ define(function (require) { return function HistogramVisType(Private) { - var VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); - var Schemas = Private(require('ui/Vis/Schemas')); + const VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); + const Schemas = Private(require('ui/Vis/Schemas')); return new VislibVisType({ name: 'area', diff --git a/src/plugins/kbn_vislib_vis_types/public/controls/line_interpolation_option.js b/src/plugins/kbn_vislib_vis_types/public/controls/line_interpolation_option.js index 23aac4bdaaf63..b9ee57748263e 100644 --- a/src/plugins/kbn_vislib_vis_types/public/controls/line_interpolation_option.js +++ b/src/plugins/kbn_vislib_vis_types/public/controls/line_interpolation_option.js @@ -1,7 +1,7 @@ define(function (require) { - var _ = require('lodash'); - var $ = require('jquery'); - var module = require('ui/modules').get('kibana'); + const _ = require('lodash'); + const $ = require('jquery'); + const module = require('ui/modules').get('kibana'); module.directive('lineInterpolationOption', function ($parse, $compile) { return { diff --git a/src/plugins/kbn_vislib_vis_types/public/controls/point_series_options.js b/src/plugins/kbn_vislib_vis_types/public/controls/point_series_options.js index 8fac50be538ca..b0d6e337fbc7b 100644 --- a/src/plugins/kbn_vislib_vis_types/public/controls/point_series_options.js +++ b/src/plugins/kbn_vislib_vis_types/public/controls/point_series_options.js @@ -1,7 +1,7 @@ define(function (require) { - var _ = require('lodash'); - var $ = require('jquery'); - var module = require('ui/modules').get('kibana'); + const _ = require('lodash'); + const $ = require('jquery'); + const module = require('ui/modules').get('kibana'); require('ui/directives/inequality'); module.directive('pointSeriesOptions', function ($parse, $compile) { diff --git a/src/plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.js b/src/plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.js index 1d7b9d6d06d97..92c0cca39413d 100644 --- a/src/plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.js +++ b/src/plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.js @@ -1,7 +1,7 @@ define(function (require) { - var _ = require('lodash'); - var $ = require('jquery'); - var module = require('ui/modules').get('kibana'); + const _ = require('lodash'); + const $ = require('jquery'); + const module = require('ui/modules').get('kibana'); module.directive('vislibBasicOptions', function ($parse, $compile) { return { diff --git a/src/plugins/kbn_vislib_vis_types/public/histogram.js b/src/plugins/kbn_vislib_vis_types/public/histogram.js index aeb01ef7d7990..3a87179b045e7 100644 --- a/src/plugins/kbn_vislib_vis_types/public/histogram.js +++ b/src/plugins/kbn_vislib_vis_types/public/histogram.js @@ -1,7 +1,7 @@ define(function (require) { return function HistogramVisType(Private) { - var VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); - var Schemas = Private(require('ui/Vis/Schemas')); + const VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); + const Schemas = Private(require('ui/Vis/Schemas')); return new VislibVisType({ name: 'histogram', diff --git a/src/plugins/kbn_vislib_vis_types/public/kbn_vislib_vis_types.js b/src/plugins/kbn_vislib_vis_types/public/kbn_vislib_vis_types.js index 6aa4e07a0230f..a1712742393ef 100644 --- a/src/plugins/kbn_vislib_vis_types/public/kbn_vislib_vis_types.js +++ b/src/plugins/kbn_vislib_vis_types/public/kbn_vislib_vis_types.js @@ -1,5 +1,5 @@ define(function (require) { - var visTypes = require('ui/registry/vis_types'); + const visTypes = require('ui/registry/vis_types'); visTypes.register(require('plugins/kbn_vislib_vis_types/histogram')); visTypes.register(require('plugins/kbn_vislib_vis_types/line')); visTypes.register(require('plugins/kbn_vislib_vis_types/pie')); diff --git a/src/plugins/kbn_vislib_vis_types/public/line.js b/src/plugins/kbn_vislib_vis_types/public/line.js index dbc9fdc8dc2da..bab825dfb0874 100644 --- a/src/plugins/kbn_vislib_vis_types/public/line.js +++ b/src/plugins/kbn_vislib_vis_types/public/line.js @@ -1,7 +1,7 @@ define(function (require) { return function HistogramVisType(Private) { - var VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); - var Schemas = Private(require('ui/Vis/Schemas')); + const VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); + const Schemas = Private(require('ui/Vis/Schemas')); return new VislibVisType({ name: 'line', diff --git a/src/plugins/kbn_vislib_vis_types/public/pie.js b/src/plugins/kbn_vislib_vis_types/public/pie.js index 04714ef260ee9..c69ed934af61a 100644 --- a/src/plugins/kbn_vislib_vis_types/public/pie.js +++ b/src/plugins/kbn_vislib_vis_types/public/pie.js @@ -1,7 +1,7 @@ define(function (require) { return function HistogramVisType(Private) { - var VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); - var Schemas = Private(require('ui/Vis/Schemas')); + const VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); + const Schemas = Private(require('ui/Vis/Schemas')); return new VislibVisType({ name: 'pie', diff --git a/src/plugins/kbn_vislib_vis_types/public/tileMap.js b/src/plugins/kbn_vislib_vis_types/public/tileMap.js index 0b7860a5147ca..668ee2320ce2a 100644 --- a/src/plugins/kbn_vislib_vis_types/public/tileMap.js +++ b/src/plugins/kbn_vislib_vis_types/public/tileMap.js @@ -1,10 +1,10 @@ define(function (require) { return function TileMapVisType(Private, getAppState, courier, config) { - var VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); - var Schemas = Private(require('ui/Vis/Schemas')); - var geoJsonConverter = Private(require('ui/agg_response/geo_json/geo_json')); - var _ = require('lodash'); - var supports = require('ui/utils/supports'); + const VislibVisType = Private(require('ui/vislib_vis_type/VislibVisType')); + const Schemas = Private(require('ui/Vis/Schemas')); + const geoJsonConverter = Private(require('ui/agg_response/geo_json/geo_json')); + const _ = require('lodash'); + const supports = require('ui/utils/supports'); return new VislibVisType({ name: 'tile_map', @@ -30,41 +30,41 @@ define(function (require) { }, listeners: { rectangle: function (event) { - var agg = _.get(event, 'chart.geohashGridAgg'); + const agg = _.get(event, 'chart.geohashGridAgg'); if (!agg) return; - var pushFilter = Private(require('ui/filter_bar/push_filter'))(getAppState()); - var indexPatternName = agg.vis.indexPattern.id; - var field = agg.fieldName(); - var filter = {geo_bounding_box: {}}; + const pushFilter = Private(require('ui/filter_bar/push_filter'))(getAppState()); + const indexPatternName = agg.vis.indexPattern.id; + const field = agg.fieldName(); + const filter = {geo_bounding_box: {}}; filter.geo_bounding_box[field] = event.bounds; pushFilter(filter, false, indexPatternName); }, mapMoveEnd: function (event) { - var agg = _.get(event, 'chart.geohashGridAgg'); + const agg = _.get(event, 'chart.geohashGridAgg'); if (!agg) return; agg.params.mapZoom = event.zoom; agg.params.mapCenter = [event.center.lat, event.center.lng]; - var editableVis = agg.vis.getEditableVis(); + const editableVis = agg.vis.getEditableVis(); if (!editableVis) return; - var editableAgg = editableVis.aggs.byId[agg.id]; + const editableAgg = editableVis.aggs.byId[agg.id]; if (editableAgg) { editableAgg.params.mapZoom = event.zoom; editableAgg.params.mapCenter = [event.center.lat, event.center.lng]; } }, mapZoomEnd: function (event) { - var agg = _.get(event, 'chart.geohashGridAgg'); + const agg = _.get(event, 'chart.geohashGridAgg'); if (!agg || !agg.params.autoPrecision) return; // zoomPrecision maps event.zoom to a geohash precision value // event.limit is the configurable max geohash precision // default max precision is 7, configurable up to 12 - var zoomPrecision = { + const zoomPrecision = { 1: 2, 2: 2, 3: 2, @@ -85,7 +85,7 @@ define(function (require) { 18: 12 }; - var precision = config.get('visualization:tileMap:maxPrecision'); + const precision = config.get('visualization:tileMap:maxPrecision'); agg.params.precision = Math.min(zoomPrecision[event.zoom], precision); courier.fetch(); diff --git a/src/plugins/kibana/public/dashboard/components/panel/lib/load_panel.js b/src/plugins/kibana/public/dashboard/components/panel/lib/load_panel.js index b7d7b42554be2..b954c88fea005 100644 --- a/src/plugins/kibana/public/dashboard/components/panel/lib/load_panel.js +++ b/src/plugins/kibana/public/dashboard/components/panel/lib/load_panel.js @@ -1,8 +1,8 @@ define(function (require) { - var _ = require('lodash'); + const _ = require('lodash'); return function loadPanelFunction(Private) { // Inject services here return function (panel, $scope) { // Function parameters here - var panelTypes = { + const panelTypes = { visualization: Private(require('plugins/kibana/dashboard/components/panel/lib/visualization')), search: Private(require('plugins/kibana/dashboard/components/panel/lib/search')) }; diff --git a/src/plugins/kibana/public/dashboard/components/panel/lib/visualization.js b/src/plugins/kibana/public/dashboard/components/panel/lib/visualization.js index e811f18f2dfd9..2e4415f42b7cc 100644 --- a/src/plugins/kibana/public/dashboard/components/panel/lib/visualization.js +++ b/src/plugins/kibana/public/dashboard/components/panel/lib/visualization.js @@ -1,7 +1,7 @@ define(function (require) { return function visualizationLoader(savedVisualizations, Private) { // Inject services here - var brushEvent = Private(require('ui/utils/brush_event')); - var filterBarClickHandler = Private(require('ui/filter_bar/filter_bar_click_handler')); + const brushEvent = Private(require('ui/utils/brush_event')); + const filterBarClickHandler = Private(require('ui/filter_bar/filter_bar_click_handler')); return function (panel, $scope) { // Function parameters here return savedVisualizations.get(panel.id) diff --git a/src/plugins/kibana/public/dashboard/components/panel/panel.js b/src/plugins/kibana/public/dashboard/components/panel/panel.js index 9ec79dcc244c1..9dce83395c8ae 100644 --- a/src/plugins/kibana/public/dashboard/components/panel/panel.js +++ b/src/plugins/kibana/public/dashboard/components/panel/panel.js @@ -1,16 +1,16 @@ define(function (require) { - var moment = require('moment'); - var $ = require('jquery'); + const moment = require('moment'); + const $ = require('jquery'); require('ui/modules') .get('app/dashboard') .directive('dashboardPanel', function (savedVisualizations, savedSearches, Notifier, Private, $injector) { - var _ = require('lodash'); - var loadPanel = Private(require('plugins/kibana/dashboard/components/panel/lib/load_panel')); - var filterManager = Private(require('ui/filter_manager')); - var notify = new Notifier(); + const _ = require('lodash'); + const loadPanel = Private(require('plugins/kibana/dashboard/components/panel/lib/load_panel')); + const filterManager = Private(require('ui/filter_manager')); + const notify = new Notifier(); - var services = require('plugins/kibana/settings/saved_object_registry').all().map(function (serviceObj) { - var service = $injector.get(serviceObj.service); + const services = require('plugins/kibana/settings/saved_object_registry').all().map(function (serviceObj) { + const service = $injector.get(serviceObj.service); return { type: service.type, name: serviceObj.service @@ -20,9 +20,9 @@ define(function (require) { require('ui/visualize'); require('ui/doc_table'); - var brushEvent = Private(require('ui/utils/brush_event')); + const brushEvent = Private(require('ui/utils/brush_event')); - var getPanelId = function (panel) { + const getPanelId = function (panel) { return ['P', panel.panelIndex].join('-'); }; @@ -32,7 +32,7 @@ define(function (require) { requires: '^dashboardGrid', link: function ($scope, $el) { // using $scope inheritance, panels are available in AppState - var $state = $scope.state; + const $state = $scope.state; // receives $scope.panel from the dashboard grid directive, seems like should be isolate? $scope.$watch('id', function () { @@ -49,11 +49,11 @@ define(function (require) { }); // create child ui state from the savedObj - var uiState = panelConfig.uiState || {}; + const uiState = panelConfig.uiState || {}; $scope.uiState = $scope.parentUiState.createChild(getPanelId(panelConfig.panel), uiState, true); $scope.filter = function (field, value, operator) { - var index = $scope.savedObj.searchSource.get('index').id; + const index = $scope.savedObj.searchSource.get('index').id; filterManager.add(field, value, operator, index); }; }) @@ -63,12 +63,12 @@ define(function (require) { // If the savedObjectType matches the panel type, this means the object itself has been deleted, // so we shouldn't even have an edit link. If they don't match, it means something else is wrong // with the object (but the object still exists), so we link to the object editor instead. - var objectItselfDeleted = e.savedObjectType === $scope.panel.type; + const objectItselfDeleted = e.savedObjectType === $scope.panel.type; if (objectItselfDeleted) return; - var type = $scope.panel.type; - var id = $scope.panel.id; - var service = _.find(services, { type: type }); + const type = $scope.panel.type; + const id = $scope.panel.id; + const service = _.find(services, { type: type }); if (!service) return; $scope.editUrl = '#settings/objects/' + service.name + '/' + id + '?notFound=' + e.savedObjectType; diff --git a/src/plugins/kibana/public/dashboard/directives/grid.js b/src/plugins/kibana/public/dashboard/directives/grid.js index c66d7af5b9576..da93a5b5a271a 100644 --- a/src/plugins/kibana/public/dashboard/directives/grid.js +++ b/src/plugins/kibana/public/dashboard/directives/grid.js @@ -1,38 +1,38 @@ define(function (require) { - var _ = require('lodash'); - var $ = require('jquery'); - var Binder = require('ui/Binder'); + const _ = require('lodash'); + const $ = require('jquery'); + const Binder = require('ui/Binder'); require('gridster'); - var app = require('ui/modules').get('app/dashboard'); + const app = require('ui/modules').get('app/dashboard'); app.directive('dashboardGrid', function ($compile, Notifier) { return { restrict: 'E', require: '^dashboardApp', // must inherit from the dashboardApp link: function ($scope, $el) { - var notify = new Notifier(); - var $container = $el; + const notify = new Notifier(); + const $container = $el; $el = $('