Skip to content

Fix failing snapshot artifact tests when using env var #56063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianseeders merged 2 commits into from
Jan 28, 2020
Merged

Fix failing snapshot artifact tests when using env var #56063

brianseeders merged 2 commits into from
Jan 28, 2020

Conversation

@brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Jan 27, 2020

No description provided.

@brianseeders brianseeders added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:CI Continuous integration v7.7.0 v6.8.6 v7.6.1 labels Jan 27, 2020
@brianseeders brianseeders requested a review from a team as a code owner January 27, 2020 20:24
tylersmalley
tylersmalley approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested.

@brianseeders brianseeders changed the title Fix failing snapshort artifact tests when using env var Fix failing snapshot artifact tests when using env var Jan 27, 2020
@brianseeders
Copy link
Contributor Author

brianseeders commented Jan 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 27, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit e792292 into elastic:master Jan 28, 2020
@brianseeders brianseeders deleted the fix/artifact-snapshot-tests branch January 28, 2020 02:45
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 28, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into np/console/mo…
5f76f38 
…ve-out-legacy

* 'master' of github.com:elastic/kibana: (187 commits)
  [ML] Reseting categorization validation if category field is cleared (elastic#56029)
  [SIEM] Fields browser readable (elastic#56000)
  [docs] Remove unused callout (elastic#56032)
  Refactor saved object management registry usage (elastic#54155)
  [SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (elastic#56090)
  Fix failing snapshot artifact tests when using env var (elastic#56063)
  Fix Github PR comment formatting (elastic#56078)
  [Maps] fix join metric field selection bugs (elastic#56044)
  Create a new menu for observability links (elastic#54847)
  [SIEM] [Detection Engine] Fixes histogram intervals  (elastic#55969)
  make test less flaky by retrying if list is re-rendered (elastic#55949)
  Remove matrix build support (elastic#54202)
  Add animation to service map layout (elastic#56042)
  [Canvas] Remove Angular and unnecessary reporting config from Canvas (elastic#54050)
  [Uptime] Simplify snapshot max to Infinity (elastic#55931)
  [Uptime] Reintroduce a column for url (elastic#55451)
  Cleanup action task params objects after successful execution (elastic#55227)
  [CI] Retry flaky tests (elastic#53961)
  Expose NP FieldFormats service to server side (elastic#55419)
  [Endpoint] EMT-65: make endpoint data types common, restructure (elastic#54772)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel.tsx
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/context.tsx
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/index.ts
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/split_panel.test.tsx
#	src/legacy/ui/public/vis/editors/default/default_editor.tsx
#	src/plugins/console/public/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap
#	src/plugins/console/public/application/components/split_panel/components/resizer.tsx
#	src/plugins/console/public/application/components/split_panel/containers/panel.tsx
#	src/plugins/console/public/application/components/split_panel/containers/panel_container.tsx
#	src/plugins/console/public/application/components/split_panel/context.tsx
#	src/plugins/console/public/application/components/split_panel/index.ts
#	src/plugins/console/public/application/components/split_panel/registry.ts
#	src/plugins/console/public/application/components/split_panel/split_panel.test.tsx
#	src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap
#	src/plugins/kibana_react/public/split_panel/containers/panel.tsx
#	src/plugins/kibana_react/public/split_panel/context.tsx
#	src/plugins/kibana_react/public/split_panel/index.ts
#	src/plugins/kibana_react/public/split_panel/split_panel.test.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 28, 2020
@gmmorris
Merge branch 'master' into alerting/details-ui
c011aa9 
* master: (77 commits)
  [ML] Reseting categorization validation if category field is cleared (elastic#56029)
  [SIEM] Fields browser readable (elastic#56000)
  [docs] Remove unused callout (elastic#56032)
  Refactor saved object management registry usage (elastic#54155)
  [SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (elastic#56090)
  Fix failing snapshot artifact tests when using env var (elastic#56063)
  Fix Github PR comment formatting (elastic#56078)
  [Maps] fix join metric field selection bugs (elastic#56044)
  Create a new menu for observability links (elastic#54847)
  [SIEM] [Detection Engine] Fixes histogram intervals  (elastic#55969)
  make test less flaky by retrying if list is re-rendered (elastic#55949)
  Remove matrix build support (elastic#54202)
  Add animation to service map layout (elastic#56042)
  [Canvas] Remove Angular and unnecessary reporting config from Canvas (elastic#54050)
  [Uptime] Simplify snapshot max to Infinity (elastic#55931)
  [Uptime] Reintroduce a column for url (elastic#55451)
  Cleanup action task params objects after successful execution (elastic#55227)
  [CI] Retry flaky tests (elastic#53961)
  Expose NP FieldFormats service to server side (elastic#55419)
  [Endpoint] EMT-65: make endpoint data types common, restructure (elastic#54772)
  ...
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jan 28, 2020
@brianseeders
Fix failing snapshot artifact tests when using env var (elastic#56063)
8d30341
@brianseeders brianseeders mentioned this pull request Jan 28, 2020
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jan 28, 2020
@brianseeders
Fix failing snapshot artifact tests when using env var (elastic#56063)
460d80d
@brianseeders brianseeders mentioned this pull request Jan 28, 2020
Merged
brianseeders added a commit to brianseeders/kibana that referenced this pull request Jan 28, 2020
@brianseeders
Fix failing snapshot artifact tests when using env var (elastic#56063)
8a8efdf
@brianseeders brianseeders mentioned this pull request Jan 28, 2020
Merged
brianseeders added a commit that referenced this pull request Jan 28, 2020
@brianseeders
Fix failing snapshot artifact tests when using env var (#56063) (#56173)
85b02e2
brianseeders added a commit that referenced this pull request Jan 28, 2020
@brianseeders
Fix failing snapshot artifact tests when using env var (#56063) (#56174)
c540890
brianseeders added a commit that referenced this pull request Jan 28, 2020
@brianseeders
Fix failing snapshot artifact tests when using env var (#56063) (#56175)
832d0ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees

No one assigned

Labels

Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v6.8.6 v7.6.1 v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brianseeders @kibanamachine @tylersmalley @elasticmachine