From be97216465324c2661bc4cac10499ec45341540f Mon Sep 17 00:00:00 2001
From: Jean-Louis Leysens <jloleysens@gmail.com>
Date: Fri, 24 Jan 2020 13:10:59 +0100
Subject: [PATCH] Move SplitPanel to kibana_react (#55529)

* split_panel component -> kibana_react

* Update useEffect for console warning

* `console` -> `kibana-react` i18n namespace

* Update when warning about children is emitted in split panel component

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
---
 .../np_ready/application/components/index.ts    |  1 -
 .../application/containers/editor/editor.tsx    |  2 +-
 .../vis/editors/default/default_editor.tsx      |  5 +----
 src/plugins/kibana_react/public/index.ts        |  1 +
 .../__snapshots__/split_panel.test.tsx.snap     |  0
 .../public}/split_panel/components/resizer.tsx  |  2 +-
 .../public}/split_panel/containers/panel.tsx    |  0
 .../split_panel/containers/panel_container.tsx  | 17 +++++++++++++++--
 .../public}/split_panel/context.tsx             |  0
 .../kibana_react/public}/split_panel/index.ts   |  0
 .../public}/split_panel/registry.ts             |  4 ----
 .../public}/split_panel/split_panel.test.tsx    |  0
 12 files changed, 19 insertions(+), 13 deletions(-)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/__snapshots__/split_panel.test.tsx.snap (100%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/components/resizer.tsx (94%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/containers/panel.tsx (100%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/containers/panel_container.tsx (89%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/context.tsx (100%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/index.ts (100%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/registry.ts (92%)
 rename src/{legacy/core_plugins/console/public/np_ready/application/components => plugins/kibana_react/public}/split_panel/split_panel.test.tsx (100%)

diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts b/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts
index 4669e210e7c2d..eccde899a2640 100644
--- a/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts
+++ b/src/legacy/core_plugins/console/public/np_ready/application/components/index.ts
@@ -17,7 +17,6 @@
  * under the License.
  */
 
-export * from './split_panel';
 export { SomethingWentWrongCallout } from './something_went_wrong_callout';
 export { TopNavMenuItem, TopNavMenu } from './top_nav_menu';
 export { ConsoleMenu } from './console_menu';
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx b/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx
index 7be1382760eb9..b42d791e5acd8 100644
--- a/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx
+++ b/src/legacy/core_plugins/console/public/np_ready/application/containers/editor/editor.tsx
@@ -21,7 +21,7 @@ import React, { useCallback } from 'react';
 import { debounce } from 'lodash';
 
 import { EditorContentSpinner } from '../../components';
-import { Panel, PanelsContainer } from '../../components/split_panel';
+import { Panel, PanelsContainer } from '../../../../../../../../plugins/kibana_react/public';
 import { Editor as EditorUI, EditorOutput } from './legacy/console_editor';
 import { StorageKeys } from '../../../services';
 import { useEditorReadContext, useServicesContext } from '../../contexts';
diff --git a/src/legacy/ui/public/vis/editors/default/default_editor.tsx b/src/legacy/ui/public/vis/editors/default/default_editor.tsx
index 3e99bb83d224f..efe5a79cd027e 100644
--- a/src/legacy/ui/public/vis/editors/default/default_editor.tsx
+++ b/src/legacy/ui/public/vis/editors/default/default_editor.tsx
@@ -23,10 +23,7 @@ import { start as embeddables } from '../../../../../core_plugins/embeddable_api
 import { EditorRenderProps } from '../../../../../core_plugins/kibana/public/visualize/np_ready/types';
 import { VisualizeEmbeddable } from '../../../../../core_plugins/visualizations/public/embeddable';
 import { VisualizeEmbeddableFactory } from '../../../../../core_plugins/visualizations/public/embeddable/visualize_embeddable_factory';
-import {
-  PanelsContainer,
-  Panel,
-} from '../../../../../core_plugins/console/public/np_ready/application/components/split_panel';
+import { PanelsContainer, Panel } from '../../../../../../plugins/kibana_react/public';
 
 import './vis_type_agg_filter';
 import { DefaultEditorSideBar } from './components/sidebar';
diff --git a/src/plugins/kibana_react/public/index.ts b/src/plugins/kibana_react/public/index.ts
index cfe89f16e99dd..81f2e694e8e5b 100644
--- a/src/plugins/kibana_react/public/index.ts
+++ b/src/plugins/kibana_react/public/index.ts
@@ -25,5 +25,6 @@ export * from './overlays';
 export * from './ui_settings';
 export * from './field_icon';
 export * from './table_list_view';
+export * from './split_panel';
 export { useUrlTracker } from './use_url_tracker';
 export { toMountPoint } from './util';
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap b/src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap
similarity index 100%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap
rename to src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/components/resizer.tsx b/src/plugins/kibana_react/public/split_panel/components/resizer.tsx
similarity index 94%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/components/resizer.tsx
rename to src/plugins/kibana_react/public/split_panel/components/resizer.tsx
index 67fe92b7eb03a..306db4c7d9a63 100644
--- a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/components/resizer.tsx
+++ b/src/plugins/kibana_react/public/split_panel/components/resizer.tsx
@@ -35,7 +35,7 @@ export function Resizer(props: Props) {
     <button
       {...props}
       data-test-subj="splitPanelResizer"
-      aria-label={i18n.translate('console.splitPanel.adjustPanelSizeAriaLabel', {
+      aria-label={i18n.translate('kibana-react.splitPanel.adjustPanelSizeAriaLabel', {
         defaultMessage: 'Press left/right to adjust panels size',
       })}
     >
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel.tsx b/src/plugins/kibana_react/public/split_panel/containers/panel.tsx
similarity index 100%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel.tsx
rename to src/plugins/kibana_react/public/split_panel/containers/panel.tsx
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel_container.tsx b/src/plugins/kibana_react/public/split_panel/containers/panel_container.tsx
similarity index 89%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel_container.tsx
rename to src/plugins/kibana_react/public/split_panel/containers/panel_container.tsx
index c9d7b01f87967..edd6a4145a1cc 100644
--- a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel_container.tsx
+++ b/src/plugins/kibana_react/public/split_panel/containers/panel_container.tsx
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import React, { Children, ReactNode, useRef, useState, useCallback } from 'react';
+import React, { Children, ReactNode, useRef, useState, useCallback, useEffect } from 'react';
 
 import { keyCodes } from '@elastic/eui';
 import { PanelContextProvider } from '../context';
@@ -46,7 +46,8 @@ export function PanelsContainer({
   onPanelWidthChange,
   resizerClassName,
 }: Props) {
-  const [firstChild, secondChild] = Children.toArray(children);
+  const childrenArray = Children.toArray(children);
+  const [firstChild, secondChild] = childrenArray;
 
   const registryRef = useRef(new PanelRegistry());
   const containerRef = useRef<HTMLDivElement>(null);
@@ -91,6 +92,18 @@ export function PanelsContainer({
     [onPanelWidthChange]
   );
 
+  useEffect(() => {
+    if (process.env.NODE_ENV !== 'production') {
+      // For now we only support bi-split
+      if (childrenArray.length > 2) {
+        // eslint-disable-next-line no-console
+        console.warn(
+          '[Split Panels Container] Detected more than two children; ignoring additional children.'
+        );
+      }
+    }
+  }, [childrenArray.length]);
+
   const childrenWithResizer = [
     firstChild,
     <Resizer
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/context.tsx b/src/plugins/kibana_react/public/split_panel/context.tsx
similarity index 100%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/context.tsx
rename to src/plugins/kibana_react/public/split_panel/context.tsx
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/index.ts b/src/plugins/kibana_react/public/split_panel/index.ts
similarity index 100%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/index.ts
rename to src/plugins/kibana_react/public/split_panel/index.ts
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/registry.ts b/src/plugins/kibana_react/public/split_panel/registry.ts
similarity index 92%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/registry.ts
rename to src/plugins/kibana_react/public/split_panel/registry.ts
index e275da9e2ac74..c052deb095733 100644
--- a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/registry.ts
+++ b/src/plugins/kibana_react/public/split_panel/registry.ts
@@ -30,10 +30,6 @@ export class PanelRegistry {
     this.panels.push(panel);
   }
 
-  getResizerNeighbours(idx: number) {
-    return [this.panels[idx], this.panels[idx + 1]];
-  }
-
   getPanels() {
     return this.panels;
   }
diff --git a/src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/split_panel.test.tsx b/src/plugins/kibana_react/public/split_panel/split_panel.test.tsx
similarity index 100%
rename from src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/split_panel.test.tsx
rename to src/plugins/kibana_react/public/split_panel/split_panel.test.tsx