removes CTA from Task Manager info message #55334

gmmorris · 2020-01-20T16:02:39Z

Summary

Remove the call to action from a TaskManager info message as we don't want to encourage this behaviour.

Done in reference to #54920 (comment)

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

* upstream/master: (26 commits) Take page offset into account too (elastic#54567) [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577) Np migration tsvb route validation (elastic#51850) [ML] MML calculator enhancements for multi-metric job wizard (elastic#54573) [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223) Fix chromeless NP apps not using full page width (elastic#54550) Remove extraneous public import to prevent failing Kibana startup (elastic#54676) [Uptime] Temporarily skip flakey tests (elastic#54675) Skip failing uptime tests Create UI for alerting and actions plugin (elastic#48959) [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654) [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521) Support "Deprecated" label in advanced settings (elastic#54539) [Maps] add text halo color and width style properties (elastic#53827) Service Map Data API at Runtime (elastic#54027) [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442) Skip flaky test [Canvas] Enable Embeddable maps (elastic#53971) [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628) uiSettings - use validation field for image field maxSize (elastic#54522) ...

* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...

* upstream/master: (83 commits) [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137) [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451) resolves elastic#53038 - remove references to specific license levels (elastic#53858) highlighting rules should still know about url parts when in sql state (elastic#55200) [Metric] convert mocha tests to jest (elastic#54054) [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087) Fix enable API to schedule task after alert is updated (elastic#55095) chore(NA): add 7.6 branch to the list of backport branches (elastic#54998) Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023) [ML] Accessibility fix for structural markup on table rows (elastic#55075) [Mappings editor] include/exclude fields only support custom options (elastic#54949) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) ...

* upstream/master: (24 commits) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags update local (elastic#55177) ...

* upstream/master: [ML] Single Metric Viewer: Fix job check. (elastic#55191)

* upstream/master: [ML] Correctly pass on severity value to anomaly explorer charts. (elastic#55207)

elasticmachine · 2020-01-20T16:03:07Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

mikecote

LGTM

peterschretlen · 2020-01-20T16:11:36Z

@FrankHassanabad FYI we're going to remove the part of that log message that talks about adjusting max_workers for 7.6

pmuellr

LGTM

I wonder about logging anything in this case, as it isn't necessarily an indication of a problem. But will be a nice diagnostic until we have better ones :-). We can tweak more in a 7.6.1 if we get a bunch of customer questions about it.

FrankHassanabad · 2020-01-20T16:15:23Z

Sounds good @peterschretlen, thanks for the ping.

removes CTA from Task Manager info message

kibanamachine · 2020-01-20T18:44:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c80ec25

History

💚 Build #21432 succeeded c80ec25

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

removes CTA from Task Manager info message

* master: [State Management] remove AppState from Dashboard app (elastic#54105) Expose fatalErrors API from the Start contract (elastic#55300) [BUG] Data fetching twice on discover timefilter change (elastic#55279) [Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (elastic#55161) [Logs UI] Fix z-index of logs page toolbar (elastic#54469) removes CTA from Task Manager info message (elastic#55334)

gmmorris added 8 commits January 13, 2020 19:04

fixed snapshots broken by merge

f9e63f7

Merge remote-tracking branch 'upstream/master'

e50378d

* upstream/master: [ML] Single Metric Viewer: Fix job check. (elastic#55191)

Merge remote-tracking branch 'upstream/master'

4b6aedf

* upstream/master: [ML] Correctly pass on severity value to anomaly explorer charts. (elastic#55207)

remove CTA from TM info m,essage

c80ec25

gmmorris added Feature:Alerting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.6.0 v7.7.0 v8.0.0 labels Jan 20, 2020

gmmorris added release_note:skip Skip the PR/issue when compiling release notes and removed v7.7.0 labels Jan 20, 2020

gmmorris mentioned this pull request Jan 20, 2020

Improve task manager warning log messaging when all workers are used #54920

Closed

mikecote approved these changes Jan 20, 2020

View reviewed changes

mikecote added v7.7.0 and removed v7.7.0 labels Jan 20, 2020

pmuellr approved these changes Jan 20, 2020

View reviewed changes

gmmorris merged commit 638792a into elastic:master Jan 20, 2020

gmmorris mentioned this pull request Jan 20, 2020

[7.x] removes CTA from Task Manager info message (#55334) #55343

Merged

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020

removes CTA from Task Manager info message (elastic#55334)

a275bd2

removes CTA from Task Manager info message

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020

removes CTA from Task Manager info message (elastic#55334)

e375ec8

removes CTA from Task Manager info message

gmmorris mentioned this pull request Jan 20, 2020

[7.6] removes CTA from Task Manager info message (#55334) #55344

Merged

gmmorris deleted the task-manager/cta branch January 20, 2020 17:25

gmmorris added a commit that referenced this pull request Jan 20, 2020

removes CTA from Task Manager info message (#55334) (#55343)

1f1a0da

removes CTA from Task Manager info message

gmmorris added a commit that referenced this pull request Jan 20, 2020

removes CTA from Task Manager info message (#55334) (#55344)

052fbae

removes CTA from Task Manager info message

gmmorris added the backported label Jan 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

removes CTA from Task Manager info message #55334

removes CTA from Task Manager info message #55334

Uh oh!

gmmorris commented Jan 20, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 20, 2020

Uh oh!

mikecote left a comment

Uh oh!

peterschretlen commented Jan 20, 2020

Uh oh!

pmuellr left a comment

Uh oh!

FrankHassanabad commented Jan 20, 2020

Uh oh!

kibanamachine commented Jan 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

removes CTA from Task Manager info message #55334

removes CTA from Task Manager info message #55334

Uh oh!

Conversation

gmmorris commented Jan 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 20, 2020

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

peterschretlen commented Jan 20, 2020

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad commented Jan 20, 2020

Uh oh!

kibanamachine commented Jan 20, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gmmorris commented Jan 20, 2020 •

edited

Loading