From 5187cd9866a4d1b4fe3a0e781fb7b65bc6a5114c Mon Sep 17 00:00:00 2001 From: Stacey Gammon Date: Thu, 12 Dec 2019 14:35:12 -0500 Subject: [PATCH] Fix and turn back on legacy embeddable tests --- test/plugin_functional/config.js | 13 +------------ .../public/np_ready/public/legacy.ts | 2 ++ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/test/plugin_functional/config.js b/test/plugin_functional/config.js index d8ce12d1fc612..4ca3d86f7043c 100644 --- a/test/plugin_functional/config.js +++ b/test/plugin_functional/config.js @@ -33,18 +33,7 @@ export default async function ({ readConfigFile }) { require.resolve('./test_suites/app_plugins'), require.resolve('./test_suites/custom_visualizations'), require.resolve('./test_suites/panel_actions'), - - /** - * @todo Work on re-enabling this test suite after this is merged. These tests pass - * locally but on CI they fail. The error on CI says "TypeError: Cannot read - * property 'overlays' of null". Possibly those are `overlays` from - * `npStart.core.overlays`, possibly `npStart.core` is `null` on CI, but - * available when this test suite is executed locally. - * - * See issue: https://github.com/elastic/kibana/issues/43087 - */ - // require.resolve('./test_suites/embeddable_explorer'), - + require.resolve('./test_suites/embeddable_explorer'), require.resolve('./test_suites/core_plugins'), ], services: { diff --git a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/legacy.ts b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/legacy.ts index 1928d7ac72313..57b5ad086e6a7 100644 --- a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/legacy.ts +++ b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/public/np_ready/public/legacy.ts @@ -18,6 +18,8 @@ */ /* eslint-disable @kbn/eslint/no-restricted-paths */ import 'ui/autoload/all'; + +import 'uiExports/interpreter'; import 'uiExports/embeddableFactories'; import 'uiExports/embeddableActions';