Change session timeout values to use duration instead of number #52520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jportner
force-pushed
the
session-config-duration
branch
2 times, most recently
from
700a8b6 to
92fdedc
Compare
Now these can be formatted in the config file as human-readable strings.
jportner
force-pushed
the
session-config-duration
branch
from
92fdedc to
909ead2
Compare
jportner
added
the
release_note:skip
Member
|
ACK: reviewing... |
azasypkin
reviewed
Dec 10, 2019
The plugin now uses Duration natively instead of converting these values to numbers. Also removed unused vars from legacyCompat.
jportner
commented
Dec 12, 2019
jportner
commented
Dec 12, 2019
Even though `session.lifespan` should be `null` by default, the `session` object is undefined by default. When the config is parsed we want to make sure that both `session.idleTimeout` and `session.lifespan` are null by default.
azasypkin
approved these changes
Dec 13, 2019
Member
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
Looks great, just a couple of nits.
azasypkin
added
chore
Feature:Security/Authentication
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
We had some unnecessary complexity in the config to satisfy test mocks as they were written. Chagned the tests and simplified said config.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Dec 13, 2019
jportner
added a commit
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change based on feedback after #49855 was merged.