From 28fd701a17d2e6883b77b97a65846be6787acb43 Mon Sep 17 00:00:00 2001 From: Dima Arnautov Date: Fri, 6 Dec 2019 14:49:09 +0100 Subject: [PATCH 1/3] [ML] add sorting support --- .../components/job_messages/job_messages.tsx | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx b/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx index aedb8b6d17d06..679ff5e6e91ef 100644 --- a/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx +++ b/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx @@ -6,7 +6,7 @@ import React, { FC } from 'react'; -import { EuiSpacer, EuiBasicTable } from '@elastic/eui'; +import { EuiSpacer, EuiInMemoryTable } from '@elastic/eui'; // @ts-ignore import { formatDate } from '@elastic/eui/lib/services/format'; import { i18n } from '@kbn/i18n'; @@ -31,15 +31,17 @@ export const JobMessages: FC = ({ messages, loading, error }) const columns = [ { name: '', - render: (message: JobMessage) => , + render: (msg: JobMessage) => , width: `${theme.euiSizeL}`, }, { + field: 'timestamp', name: i18n.translate('xpack.ml.jobMessages.timeLabel', { defaultMessage: 'Time', }), - render: (message: any) => formatDate(message.timestamp, TIME_FORMAT), + render: (timestamp: number) => formatDate(timestamp, TIME_FORMAT), width: '120px', + sortable: true, }, { field: 'node_name', @@ -57,13 +59,22 @@ export const JobMessages: FC = ({ messages, loading, error }) }, ]; + const defaultSorting = { + sort: { + field: 'timestamp', + direction: 'asc', + }, + }; + return ( <> - Date: Fri, 6 Dec 2019 15:03:31 +0100 Subject: [PATCH 2/3] [ML] change fetch sort to desc for anomaly detection jobs --- .../ml/server/models/job_audit_messages/job_audit_messages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/legacy/plugins/ml/server/models/job_audit_messages/job_audit_messages.js b/x-pack/legacy/plugins/ml/server/models/job_audit_messages/job_audit_messages.js index 3b666cad7d8eb..16328a9cd5e93 100644 --- a/x-pack/legacy/plugins/ml/server/models/job_audit_messages/job_audit_messages.js +++ b/x-pack/legacy/plugins/ml/server/models/job_audit_messages/job_audit_messages.js @@ -90,7 +90,7 @@ export function jobAuditMessagesProvider(callWithRequest) { body: { sort: [ - { timestamp: { order: 'asc' } }, + { timestamp: { order: 'desc' } }, { job_id: { order: 'asc' } } ], query From e733d877f43cab565648a1d0ed0f627a4b4af02e Mon Sep 17 00:00:00 2001 From: Dima Arnautov Date: Fri, 6 Dec 2019 15:11:34 +0100 Subject: [PATCH 3/3] [ML] rename param --- .../public/application/components/job_messages/job_messages.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx b/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx index 679ff5e6e91ef..5fb3ab95e4ea0 100644 --- a/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx +++ b/x-pack/legacy/plugins/ml/public/application/components/job_messages/job_messages.tsx @@ -31,7 +31,7 @@ export const JobMessages: FC = ({ messages, loading, error }) const columns = [ { name: '', - render: (msg: JobMessage) => , + render: (message: JobMessage) => , width: `${theme.euiSizeL}`, }, {