-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Migrate instance uuid logic to new platform #52060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
732ccf2
move and migrate uuid code to new platform
pgayvallet bb7c5f0
create and wire uuid service
pgayvallet 958b28e
handle legacy compatibility
pgayvallet 3ed08c5
update generated docs
pgayvallet 6964d1e
add `set` to LegacyConfig interface
pgayvallet 88f9790
Fix types
pgayvallet c8a808d
fix config access
pgayvallet 81a0dc0
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet 7bbd025
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet b850444
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet a499ff1
respect naming conventions for uuid
pgayvallet afcdf9a
remove hardcoded config paths
pgayvallet 6c0c880
rename manageInstanceUuid to resolveInstanceUuid
pgayvallet 6139832
moves legacy config uuid set from uuid to legacy service
pgayvallet 26719cb
log specific message depending on how uuid was resolved
pgayvallet 1783d71
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet ba3a23f
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet 8bcc718
resolve merge conflicts
pgayvallet f4b11d8
use fs.promises
pgayvallet fa6ea93
add forgotten @public in uuid contract
pgayvallet a6f5980
add explicit errors and tests
pgayvallet 1844093
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet 83eb19f
ensure uuid is valid in configuration
pgayvallet 1b8e6b6
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet 8767b73
fix read/write tests
pgayvallet 9f27f5a
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet 16e9a2f
Merge remote-tracking branch 'upstream/master' into kbn-48956-uuid-NP
pgayvallet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
docs/development/core/server/kibana-plugin-server.coresetup.uuid.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
|
||
| [Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [CoreSetup](./kibana-plugin-server.coresetup.md) > [uuid](./kibana-plugin-server.coresetup.uuid.md) | ||
|
|
||
| ## CoreSetup.uuid property | ||
|
|
||
| [UuidServiceSetup](./kibana-plugin-server.uuidservicesetup.md) | ||
|
|
||
| <b>Signature:</b> | ||
|
|
||
| ```typescript | ||
| uuid: UuidServiceSetup; | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...evelopment/core/server/kibana-plugin-server.uuidservicesetup.getinstanceuuid.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
|
||
| [Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [UuidServiceSetup](./kibana-plugin-server.uuidservicesetup.md) > [getInstanceUuid](./kibana-plugin-server.uuidservicesetup.getinstanceuuid.md) | ||
|
|
||
| ## UuidServiceSetup.getInstanceUuid() method | ||
|
|
||
| Retrieve the Kibana instance uuid. | ||
|
|
||
| <b>Signature:</b> | ||
|
|
||
| ```typescript | ||
| getInstanceUuid(): string; | ||
| ``` | ||
| <b>Returns:</b> | ||
|
|
||
| `string` | ||
|
|
20 changes: 20 additions & 0 deletions
20
docs/development/core/server/kibana-plugin-server.uuidservicesetup.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <!-- Do not edit this file. It is automatically generated by API Documenter. --> | ||
|
|
||
| [Home](./index.md) > [kibana-plugin-server](./kibana-plugin-server.md) > [UuidServiceSetup](./kibana-plugin-server.uuidservicesetup.md) | ||
|
|
||
| ## UuidServiceSetup interface | ||
|
|
||
| APIs to access the application's instance uuid. | ||
|
|
||
| <b>Signature:</b> | ||
|
|
||
| ```typescript | ||
| export interface UuidServiceSetup | ||
| ``` | ||
|
|
||
| ## Methods | ||
|
|
||
| | Method | Description | | ||
| | --- | --- | | ||
| | [getInstanceUuid()](./kibana-plugin-server.uuidservicesetup.getinstanceuuid.md) | Retrieve the Kibana instance uuid. | | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,6 +91,7 @@ export const config = { | |
| ) | ||
| ), | ||
| }), | ||
| uuid: schema.maybe(schema.string()), | ||
| }, | ||
| { | ||
| validate: rawConfig => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/core/server/legacy/config/__snapshots__/legacy_object_to_config_adapter.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { LegacyServiceDiscoverPlugins } from './legacy_service'; | ||
|
|
||
| const createDiscoverMock = () => { | ||
| const setupContract: DeeplyMockedKeys<LegacyServiceDiscoverPlugins> = { | ||
| pluginSpecs: [], | ||
| disabledPluginSpecs: [], | ||
| uiExports: {} as any, | ||
| settings: {}, | ||
| pluginExtendedConfig: { | ||
| get: jest.fn(), | ||
| has: jest.fn(), | ||
| set: jest.fn(), | ||
| } as any, | ||
| }; | ||
| return setupContract; | ||
| }; | ||
|
|
||
| export const legacyServiceMock = { | ||
| createDiscover: createDiscoverMock, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| export { UuidService, UuidServiceSetup } from './uuid_service'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like having to add this here, as the
serverconfig namespace is now more like only thehttpconfig, However the current property isserver.uuid, so I don't really see another way.We could deprecates/rename that once the config deprecation PR lands if we want to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note to the config refactoring issue just so we don't forget?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the legacy config, we validated this as a valid guid. Can we add that validation here as well? Should be able to specify a custom
validateoption toschema.string()There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch, totally forgot about that