[services/remote] wrap up clearing browser storage with try/catch #50840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
release_note:skip
Contributor
💚 Build Succeeded |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
wayneseymour
suggested changes
Nov 18, 2019
wayneseymour
approved these changes
Nov 18, 2019
…clear-session-storage
…mlemeshko/kibana into fix/ftr-fails-to-clear-session-storage
spalger
reviewed
Nov 19, 2019
| try { | ||
| await driver.executeScript(`window.${storageType}.clear();`); | ||
| } catch (error) { | ||
| if (!error.message.includes(`Failed to read the ${storageType} property from 'Window'`)) { |
Contributor
There was a problem hiding this comment.
This used to have single quotes around the storage type, which one is correct?
Member
Author
There was a problem hiding this comment.
You are right Spencer, I actually tested with quotes 😫
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Nov 19, 2019
…astic#50840) * [services/remote] wrap up clearing storage with try/catch * improve error handling on clearing storage * apply awesome idea * fix exception message
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Nov 19, 2019
…astic#50840) * [services/remote] wrap up clearing storage with try/catch * improve error handling on clearing storage * apply awesome idea * fix exception message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the error
WebDriverError: <unknown>: Failed to read the 'sessionStorage' property from 'Window': Storage is disabled inside 'data:' URLs.that occurs while storage clearing when it is actually emptyCurrently, if the session or local storage clearing fails, WebDriver throws an error like
This PR wraps operations with try/catch and do not fail operation unless different error message is returned. This message won't be logged into console output.