Skip to content

[ML] Add tests to create transforms #49760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 18, 2019
Merged

[ML] Add tests to create transforms #49760

merged 14 commits into from
Nov 18, 2019

Conversation

@pheyos
Copy link
Member

@pheyos pheyos commented Oct 30, 2019 •
edited
Loading

Summary

This PR add tests to create transforms.

High level test steps

  • Navigate to transform UI
  • Use the wizard to create a new batch transform
  • Run the transform and wait for processing to finish
  • Validate transform creation in the transform management list

Note: The transform suite has the transform label attached, so transform only tests can be executed via --include-tag transform

@pheyos pheyos self-assigned this Oct 30, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2019

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos marked this pull request as ready for review November 13, 2019 09:07
@pheyos pheyos requested a review from a team as a code owner November 13, 2019 09:07
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2019

💔 Build Failed

@pheyos
Copy link
Member Author

pheyos commented Nov 13, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2019

💔 Build Failed

peteharverson
peteharverson approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Nov 14, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2019

💚 Build Succeeded

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@pheyos
Copy link
Member Author

pheyos commented Nov 18, 2019 •
edited
Loading

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 18, 2019

💔 Build Failed

@pheyos
Copy link
Member Author

pheyos commented Nov 18, 2019

retest

walterra
walterra approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is great! Just added two minor suggestions.

...nsform/public/app/sections/create_transform/components/step_details/step_details_summary.tsx Outdated
: '';

return (
<Fragment>
Copy link
Contributor

@walterra walterra Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's now a wrapping div element, you can remove the Fragment tag.

Copy link
Member Author

@pheyos pheyos Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Removed in 9e4e6c8

...nsform/public/app/sections/transform_management/components/transform_list/transform_list.tsx Outdated
};

return (
<Fragment>
Copy link
Contributor

@walterra walterra Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's now a wrapping div element, you can remove the Fragment tag.

Copy link
Member Author

@pheyos pheyos Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Removed in 9e4e6c8

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 18, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 18, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 18, 2019

💚 Build Succeeded

@pheyos pheyos merged commit dca8c24 into elastic:master Nov 18, 2019
@pheyos pheyos deleted the transform_tests branch November 18, 2019 11:54
@pheyos pheyos mentioned this pull request Nov 18, 2019
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 18, 2019
@pheyos
[ML] Add tests to create transforms (elastic#49760)
cafdb54
pheyos added a commit that referenced this pull request Nov 18, 2019
@pheyos
[ML] Add tests to create transforms (#49760) (#50898)
9e84174
@pheyos pheyos mentioned this pull request Dec 3, 2019
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Dec 3, 2019
@pheyos
[ML] Add tests to create transforms (elastic#49760)
9beee52
pheyos added a commit that referenced this pull request Dec 4, 2019
@pheyos
[7.5] [ML] Add tests to create transforms (#49760) (#52080)
785807f 
* [ML] Add tests to create transforms (#49760)

* Apply #51066 to backport

* Adjust eui switch handling for 7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@pheyos pheyos

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.5.1 v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pheyos @elasticmachine @walterra @alvarezmelissa87 @peteharverson