[Uptime] Update breadcrumb generator for monitor -> overview. #49428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💚 Build Succeeded |
justinkambic
changed the title
shahzad31
reviewed
Oct 29, 2019
| name: string, | ||
| search?: string, | ||
| basepath?: string | ||
| ): ChromeBreadcrumb[] => [makeOverviewBreadcrumb(search, basepath), { text: name }]; |
Contributor
There was a problem hiding this comment.
does it make sense to have href for monitor page breadcrumb as well?
Contributor
Author
There was a problem hiding this comment.
Well I think at this time that the monitor page can only be a "leaf" in the navigation, so if you're on a monitor page there's nowhere further down to drill. We could add an href but as far as I understand it, we'd only link people back to the page they're already on.
shahzad31
reviewed
Oct 29, 2019
|
|
||
| const makeOverviewBreadcrumb = (search?: string): ChromeBreadcrumb => ({ | ||
| const makeOverviewBreadcrumb = (search?: string, basepath?: string): ChromeBreadcrumb => ({ | ||
| text: i18n.translate('xpack.uptime.breadcrumbs.overviewBreadcrumbText', { |
Contributor
There was a problem hiding this comment.
Can you please follow camelCase for basePath?
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
…kibana into uptime_overview-breadcrumb
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
Contributor
Author
|
Closing this in favor of #50095. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #49391.
Updates the breadcrumb generator in the Uptime app to more accurately reflect the destination of someone returning to the Uptime home page.
Testing
Also be sure to test with base paths.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers