fixing issue with dashboard csv download #42964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcconaghy
added
zDeprecated Feature:Reporting
Contributor
|
Pinging @elastic/kibana-stack-services |
Contributor
💔 Build Failed |
Contributor
Author
|
this behavior is due to a bug in saved searches, ignore this PR |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
bmcconaghy
added
the
release_note:skip
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 12, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (22 commits) [Code]: downgrade the log level of error message from subprocess (elastic#42925) [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890) Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580) [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042) Skip flaky es_ui_shared/request tests. Pass uiSettings to all data plugin services (elastic#42159) [SIEM] Upgrades react-redux and utilize React.memo for performance gains (elastic#43029) [skip-ci][Maps] add maki icon sheet to docs (elastic#43063) Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305) Update dependency commander to v3 (elastic#43041) Update dependency @percy/agent to ^0.10.0 (elastic#40517) [Maps] only show top hits checkbox if index has date fields (elastic#43056) run chained_controls on Firefox to catch regression (elastic#43044) fixing issue with dashboard csv download (elastic#42964) Expose task manager as plugin instead of server argument (elastic#42966) Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686) [Code] disk watermark supports percentage and absolute modes (elastic#42987) [apps/dashboard] skip part of filtering tests on FF (elastic#43047) [ML] Kibana management jobs list (elastic#42570) [ML] Fix check for watcher being enabled (elastic#43025) ...
Member
|
I'm afraid there's still a bug that exists with saved searches migrated from an earlier version of Kibana: #43230 Unless my saved search object was supposed to go through a migration to have the |
Contributor
Author
|
@tsullivan, when did you test this? @Bargs just merged this: #43038 so please confirm that you are seeing the bug with his code. |
Member
|
@bmcconaghy confirmed my issue is fixed. We're good! Thanks. |
Contributor
|
@bmcconaghy could you backport this to 7.x? I think #43234 will fail until it is backported. |
Contributor
Author
|
@Bargs sorry about that, totally forgot to backport. Got a PR up to do so now and will merge when it goes green. |
bmcconaghy
added a commit
that referenced
this pull request
Aug 14, 2019
Contributor
|
Thanks @bmcconaghy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42963
Pretty sure this will work with multisorted saved searches too. Not sure why this broke as it seems to have worked fine on 7.3 (see #42945).