Add Kibana App specific URL to the help menu (#34739) #42580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
Author
|
@timroes Hey Tim! What do you think? |
timroes
added
release_note:enhancement
review
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
cchaos
approved these changes
Aug 5, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks for adding these in @VassilisAsteriou!
It currently matches the patterns used in Maps and Code but I'm noticing that we have some larger consistency issues throughout the rest of the features. I'll make a note to create a more rigid pattern for 7.5. But for now, this is great.
I think someone from the @elastic/kibana-app team also needs to do a review for JS accuracy.
VassilisAsteriou
changed the title
Member
|
jenkins test this |
Contributor
💚 Build Succeeded |
VassilisAsteriou
force-pushed
the
doc-links
branch
from
bf3c4e3 to
33deab1
Compare
Member
|
jenkins test this |
kertal
approved these changes
Aug 12, 2019
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally with Chrome + IE
Contributor
💚 Build Succeeded |
Member
|
Dear @VassilisAsteriou, thanks a lot for your valuable contribution! Hurray for your first kibana commit! What a nice debut! 👍 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 12, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (22 commits) [Code]: downgrade the log level of error message from subprocess (elastic#42925) [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890) Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580) [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042) Skip flaky es_ui_shared/request tests. Pass uiSettings to all data plugin services (elastic#42159) [SIEM] Upgrades react-redux and utilize React.memo for performance gains (elastic#43029) [skip-ci][Maps] add maki icon sheet to docs (elastic#43063) Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305) Update dependency commander to v3 (elastic#43041) Update dependency @percy/agent to ^0.10.0 (elastic#40517) [Maps] only show top hits checkbox if index has date fields (elastic#43056) run chained_controls on Firefox to catch regression (elastic#43044) fixing issue with dashboard csv download (elastic#42964) Expose task manager as plugin instead of server argument (elastic#42966) Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686) [Code] disk watermark supports percentage and absolute modes (elastic#42987) [apps/dashboard] skip part of filtering tests on FF (elastic#43047) [ML] Kibana management jobs list (elastic#42570) [ML] Fix check for watcher being enabled (elastic#43025) ...
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 1, 2019
…#42580) * Add Dashboard help menu * Add Discover help menu * Add Visualize help menu
maryia-lapata
added a commit
that referenced
this pull request
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addition of links in the help menus of Dashboard, Discover and Visualize pointing to their respective documentation pages.
Checklist
- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately