From 9d9d6ab09be62fedbc6b9a5a0a5c3621455d69ae Mon Sep 17 00:00:00 2001 From: maryia-lapata Date: Wed, 15 May 2019 12:08:38 +0300 Subject: [PATCH 1/2] Allow to send showLabel parameter with false value --- .../public/visualize/loader/pipeline_helpers/build_pipeline.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.ts b/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.ts index 1205632641ab6..b26be35e6a268 100644 --- a/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.ts +++ b/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.ts @@ -267,7 +267,7 @@ export const buildPipelineVisFunction: BuildPipelineVisFunction = { if (maxFontSize) { expr += `maxFontSize=${maxFontSize} `; } - if (showLabel) { + if (showLabel !== undefined) { expr += `showLabel=${showLabel} `; } From f3e5447fac8fb68f3ef41049b86d2cbf09561d38 Mon Sep 17 00:00:00 2001 From: maryia-lapata Date: Thu, 23 May 2019 21:22:20 +0300 Subject: [PATCH 2/2] Add unit test --- .../__snapshots__/build_pipeline.test.js.snap | 2 ++ .../loader/pipeline_helpers/build_pipeline.test.js | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/src/legacy/ui/public/visualize/loader/pipeline_helpers/__snapshots__/build_pipeline.test.js.snap b/src/legacy/ui/public/visualize/loader/pipeline_helpers/__snapshots__/build_pipeline.test.js.snap index ee4f3354cc9ed..920a29ba2f5b6 100644 --- a/src/legacy/ui/public/visualize/loader/pipeline_helpers/__snapshots__/build_pipeline.test.js.snap +++ b/src/legacy/ui/public/visualize/loader/pipeline_helpers/__snapshots__/build_pipeline.test.js.snap @@ -26,6 +26,8 @@ exports[`visualize loader pipeline helpers: build pipeline buildPipelineVisFunct exports[`visualize loader pipeline helpers: build pipeline buildPipelineVisFunction handles table function without splits or buckets 1`] = `"kibana_table visConfig='{\\"foo\\":\\"bar\\",\\"dimensions\\":{\\"metrics\\":[0,1],\\"buckets\\":[]}}' "`; +exports[`visualize loader pipeline helpers: build pipeline buildPipelineVisFunction handles tagcloud function with boolean param showLabel 1`] = `"tagcloud metric={visdimension 0} showLabel=false "`; + exports[`visualize loader pipeline helpers: build pipeline buildPipelineVisFunction handles tagcloud function with buckets 1`] = `"tagcloud metric={visdimension 0} bucket={visdimension 1 } "`; exports[`visualize loader pipeline helpers: build pipeline buildPipelineVisFunction handles tagcloud function without buckets 1`] = `"tagcloud metric={visdimension 0} "`; diff --git a/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.test.js b/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.test.js index a38b567b2f589..d8d43a1049980 100644 --- a/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.test.js +++ b/src/legacy/ui/public/visualize/loader/pipeline_helpers/build_pipeline.test.js @@ -183,6 +183,14 @@ describe('visualize loader pipeline helpers: build pipeline', () => { const actual = buildPipelineVisFunction.tagcloud({ params }, schemas); expect(actual).toMatchSnapshot(); }); + + it('with boolean param showLabel', () => { + const schemas = { metric: [{ accessor: 0 }] }; + const params = { showLabel: false }; + const actual = buildPipelineVisFunction.tagcloud({ params }, schemas); + expect(actual).toMatchSnapshot(); + }); + }); describe('handles region_map function', () => {