From 82c7ace4d7cf35f89021eb49e70051408dd94844 Mon Sep 17 00:00:00 2001 From: Jason Rhodes Date: Fri, 22 Mar 2019 10:28:37 -0400 Subject: [PATCH 1/5] Upgrades EUI to 9.5 (#33672) * Updates EUI to 9.5.0 * Remove duplicate type * Updates snapshots and fixes a few type errors * Updates x-pack snapshots --- package.json | 2 +- .../fatal_errors_screen.test.tsx.snap | 1 + .../editor/__snapshots__/controls_tab.test.js.snap | 1 + .../__snapshots__/input_control_vis.test.js.snap | 4 ++++ .../__snapshots__/dashboard_listing.test.js.snap | 5 +++++ .../top_nav/__snapshots__/add_panel.test.js.snap | 1 + .../top_nav/__snapshots__/clone_modal.test.js.snap | 2 ++ .../__snapshots__/open_search_panel.test.js.snap | 1 + .../components/__snapshots__/add_data.test.js.snap | 14 ++++++++++++++ .../components/__snapshots__/home.test.js.snap | 10 ++++++++++ .../sample_data_view_data_button.test.js.snap | 2 ++ .../tutorial/__snapshots__/footer.test.js.snap | 1 + .../__snapshots__/instruction_set.test.js.snap | 5 +++++ .../__snapshots__/introduction.test.js.snap | 3 ++- .../saved_objects_installer.test.js.snap | 5 +++++ .../__snapshots__/empty_state.test.js.snap | 1 + .../__jest__/__snapshots__/header.test.js.snap | 2 ++ .../__jest__/__snapshots__/header.test.js.snap | 1 + .../__jest__/__snapshots__/add_filter.test.js.snap | 2 ++ .../__jest__/__snapshots__/table.test.js.snap | 2 ++ .../saved_object_save_modal.test.js.snap | 2 ++ .../components/saved_object_finder.test.tsx | 9 +++++---- .../components/saved_object_finder.tsx | 3 ++- typings/@elastic/eui/index.d.ts | 1 - x-pack/package.json | 2 +- .../__snapshots__/upload_license.test.js.snap | 6 ++++++ .../__snapshots__/pipeline_editor.test.js.snap | 12 ++++++++++++ .../__snapshots__/pipelines_table.test.js.snap | 1 + .../__snapshots__/upgrade_failure.test.js.snap | 3 +++ .../upgrade_failure_actions.test.js.snap | 1 + .../__snapshots__/rule_editor_flyout.test.js.snap | 3 +++ .../explorer_no_jobs_found.test.js.snap | 1 + .../__snapshots__/calendar_form.test.js.snap | 2 ++ .../__snapshots__/import_modal.test.js.snap | 1 + .../__snapshots__/add_item_popover.test.js.snap | 3 +++ .../delete_filter_list_modal.test.js.snap | 5 +++++ .../__snapshots__/edit_filter_list.test.js.snap | 8 ++++++++ .../__snapshots__/collection_enabled.test.js.snap | 1 + .../__snapshots__/collection_interval.test.js.snap | 2 ++ .../__snapshots__/basic_login_form.test.tsx.snap | 1 + .../confirm_delete_modal.test.tsx.snap | 1 + .../delete_spaces_button.test.tsx.snap | 1 + .../__snapshots__/spaces_grid_pages.test.tsx.snap | 1 + .../__snapshots__/checklist_step.test.tsx.snap | 1 + .../__snapshots__/warning_step.test.tsx.snap | 1 + yarn.lock | 8 ++++---- 46 files changed, 132 insertions(+), 13 deletions(-) diff --git a/package.json b/package.json index 5d5a9bd1c2353..4d4b42e23f3ee 100644 --- a/package.json +++ b/package.json @@ -97,7 +97,7 @@ "@babel/polyfill": "^7.2.5", "@babel/register": "^7.0.0", "@elastic/datemath": "5.0.2", - "@elastic/eui": "9.4.2", + "@elastic/eui": "9.5.0", "@elastic/filesaver": "1.1.2", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "2.3.2", diff --git a/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap b/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap index 2b4066f4d9123..c6912764db2af 100644 --- a/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap +++ b/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap @@ -26,6 +26,7 @@ exports[`rendering render matches snapshot 1`] = ` fill={true} iconSide="left" onClick={[Function]} + size="m" type="button" > View data @@ -62,6 +63,7 @@ exports[`should render simple button when appLinks is empty 1`] = ` fill={false} href="root/app/kibana#/dashboard/722b74f0-b882-11e8-a6d9-e546fe2bba5f" iconSide="left" + size="m" type="button" > View data diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/footer.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/footer.test.js.snap index 36f81ab582568..aac8367ab3878 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/footer.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/footer.test.js.snap @@ -31,6 +31,7 @@ exports[`render 1`] = ` fill={true} href="/app/myapp" iconSide="left" + size="m" type="button" > launch myapp diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap index fc5bbb7979010..028cf16b75f74 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap @@ -182,6 +182,7 @@ exports[`statusCheckState checking status 1`] = ` iconSide="left" isLoading={true} onClick={[Function]} + size="m" type="button" > custom btn label @@ -300,6 +301,7 @@ exports[`statusCheckState failed status check - error 1`] = ` iconSide="left" isLoading={false} onClick={[Function]} + size="m" type="button" > custom btn label @@ -423,6 +425,7 @@ exports[`statusCheckState failed status check - no data 1`] = ` iconSide="left" isLoading={false} onClick={[Function]} + size="m" type="button" > custom btn label @@ -546,6 +549,7 @@ exports[`statusCheckState initial state - no check has been attempted 1`] = ` iconSide="left" isLoading={true} onClick={[Function]} + size="m" type="button" > custom btn label @@ -664,6 +668,7 @@ exports[`statusCheckState successful status check 1`] = ` iconSide="left" isLoading={false} onClick={[Function]} + size="m" type="button" > custom btn label diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap index 2197b84e9335d..41cee89145e71 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap @@ -31,7 +31,8 @@ exports[`props exportedFieldsUrl 1`] = ` fill={false} href="exported_fields_url" iconSide="left" - rel="noopener noreferrer" + rel="noopener" + size="m" target="_blank" type="button" > diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap index 1262d16ae1fe5..a7c1c2ddea898 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/saved_objects_installer.test.js.snap @@ -146,6 +146,7 @@ exports[`bulkCreate should display error message when bulkCreate request fails 1 iconSide="left" isLoading={false} onClick={[Function]} + size="m" type="button" > Load Kibana objects @@ -257,6 +258,7 @@ exports[`bulkCreate should display error message when bulkCreate request fails 1 iconSide="left" isLoading={false} onClick={[Function]} + size="m" type="button" > +
+ + + +
+ + + + +`; + +exports[`Storyshots components/FontPicker with value 1`] = ` +
+
+ +
+
+ + Select an option: +
+ American Typewriter +
+ , is selected +
+ +
+ + + +
+
+
+
+
+`; diff --git a/x-pack/plugins/index_lifecycle_management/__jest__/__snapshots__/extend_index_management.test.js.snap b/x-pack/plugins/index_lifecycle_management/__jest__/__snapshots__/extend_index_management.test.js.snap index cf33fa7ba5187..95f01e49c3789 100644 --- a/x-pack/plugins/index_lifecycle_management/__jest__/__snapshots__/extend_index_management.test.js.snap +++ b/x-pack/plugins/index_lifecycle_management/__jest__/__snapshots__/extend_index_management.test.js.snap @@ -524,8 +524,11 @@ exports[`ilm summary extension should return extension when index has lifecycle
Date: Wed, 27 Mar 2019 16:21:40 -0700 Subject: [PATCH 3/5] EUI@9.7.0 (#34011) --- package.json | 2 +- .../plugins/kbn_tp_run_pipeline/package.json | 2 +- .../plugins/kbn_tp_custom_visualizations/package.json | 2 +- .../plugins/kbn_tp_sample_panel_action/package.json | 2 +- .../plugins/kbn_tp_visualize_embedding/package.json | 2 +- x-pack/package.json | 2 +- yarn.lock | 8 ++++---- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index e1b5a0bf657bc..c9c27cc4fab2d 100644 --- a/package.json +++ b/package.json @@ -97,7 +97,7 @@ "@babel/polyfill": "^7.2.5", "@babel/register": "^7.0.0", "@elastic/datemath": "5.0.2", - "@elastic/eui": "9.6.0", + "@elastic/eui": "9.7.0", "@elastic/filesaver": "1.1.2", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "2.3.2", diff --git a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json index b97f284221483..3135a040cec92 100644 --- a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json +++ b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.6.0", + "@elastic/eui": "9.7.0", "react": "^16.8.0", "react-dom": "^16.8.0" } diff --git a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json index 116ee0f4ee7ce..cf922f28b944a 100644 --- a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json +++ b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.6.0", + "@elastic/eui": "9.7.0", "react": "^16.8.0" } } diff --git a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json index 78c26895530d1..c7148b8ce38f8 100644 --- a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json +++ b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json @@ -8,7 +8,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.6.0", + "@elastic/eui": "9.7.0", "react": "^16.8.0" }, "scripts": { diff --git a/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json b/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json index 96048fe01749b..e2a14cf36f71e 100644 --- a/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json +++ b/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.6.0", + "@elastic/eui": "9.7.0", "react": "^16.8.0", "react-dom": "^16.8.0" } diff --git a/x-pack/package.json b/x-pack/package.json index 0c2f897c72cd8..8bc9f23955a04 100644 --- a/x-pack/package.json +++ b/x-pack/package.json @@ -120,7 +120,7 @@ "@babel/register": "^7.0.0", "@babel/runtime": "^7.3.4", "@elastic/datemath": "5.0.2", - "@elastic/eui": "9.6.0", + "@elastic/eui": "9.7.0", "@elastic/node-crypto": "0.1.2", "@elastic/numeral": "2.3.2", "@kbn/babel-preset": "1.0.0", diff --git a/yarn.lock b/yarn.lock index a75a1b1021cb6..9ce3588146c7a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -785,10 +785,10 @@ tabbable "^1.1.0" uuid "^3.1.0" -"@elastic/eui@9.6.0": - version "9.6.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-9.6.0.tgz#740107869b1448348e603d4b1992daf3d5004d3a" - integrity sha512-/uZdPaf2TwTCT3MJsoz4yOqOVrAWhb3ziZtXIUIL/EWGQoha6Z8+wEhpixW472KVvp8bGJl3uDoTwTzDk3TAKw== +"@elastic/eui@9.7.0": + version "9.7.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-9.7.0.tgz#6da25d665936fba713d24bfec3beba8c20a4272b" + integrity sha512-2cXEvAxYEfS1i5ZwhSl63rGT6jMQOQHed4RLFnuf0xmZyUjIO9he8EVY9YAH2eFfrRvEVggQltLLEI+JXhiqSA== dependencies: "@types/lodash" "^4.14.116" "@types/numeral" "^0.0.25" From 6eae7bc119ce1e89b6f9de5cc271e0a7f9b79c70 Mon Sep 17 00:00:00 2001 From: "dave.snider@gmail.com" Date: Thu, 28 Mar 2019 12:27:35 -0700 Subject: [PATCH 4/5] eui 9.7.1 (#34098) --- package.json | 2 +- .../plugins/kbn_tp_run_pipeline/package.json | 2 +- .../plugins/kbn_tp_custom_visualizations/package.json | 2 +- .../plugins/kbn_tp_sample_panel_action/package.json | 2 +- .../plugins/kbn_tp_visualize_embedding/package.json | 2 +- x-pack/package.json | 2 +- yarn.lock | 8 ++++---- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index c9c27cc4fab2d..e438853b746a5 100644 --- a/package.json +++ b/package.json @@ -97,7 +97,7 @@ "@babel/polyfill": "^7.2.5", "@babel/register": "^7.0.0", "@elastic/datemath": "5.0.2", - "@elastic/eui": "9.7.0", + "@elastic/eui": "9.7.1", "@elastic/filesaver": "1.1.2", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "2.3.2", diff --git a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json index 3135a040cec92..ce2d0111c50bb 100644 --- a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json +++ b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.7.0", + "@elastic/eui": "9.7.1", "react": "^16.8.0", "react-dom": "^16.8.0" } diff --git a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json index cf922f28b944a..d1491583bc0d5 100644 --- a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json +++ b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.7.0", + "@elastic/eui": "9.7.1", "react": "^16.8.0" } } diff --git a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json index c7148b8ce38f8..dad6a74d14362 100644 --- a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json +++ b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json @@ -8,7 +8,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.7.0", + "@elastic/eui": "9.7.1", "react": "^16.8.0" }, "scripts": { diff --git a/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json b/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json index e2a14cf36f71e..9051a0e79c857 100644 --- a/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json +++ b/test/plugin_functional/plugins/kbn_tp_visualize_embedding/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "9.7.0", + "@elastic/eui": "9.7.1", "react": "^16.8.0", "react-dom": "^16.8.0" } diff --git a/x-pack/package.json b/x-pack/package.json index 8bc9f23955a04..71ac86b26c405 100644 --- a/x-pack/package.json +++ b/x-pack/package.json @@ -120,7 +120,7 @@ "@babel/register": "^7.0.0", "@babel/runtime": "^7.3.4", "@elastic/datemath": "5.0.2", - "@elastic/eui": "9.7.0", + "@elastic/eui": "9.7.1", "@elastic/node-crypto": "0.1.2", "@elastic/numeral": "2.3.2", "@kbn/babel-preset": "1.0.0", diff --git a/yarn.lock b/yarn.lock index 9ce3588146c7a..284e77699bed9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -785,10 +785,10 @@ tabbable "^1.1.0" uuid "^3.1.0" -"@elastic/eui@9.7.0": - version "9.7.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-9.7.0.tgz#6da25d665936fba713d24bfec3beba8c20a4272b" - integrity sha512-2cXEvAxYEfS1i5ZwhSl63rGT6jMQOQHed4RLFnuf0xmZyUjIO9he8EVY9YAH2eFfrRvEVggQltLLEI+JXhiqSA== +"@elastic/eui@9.7.1": + version "9.7.1" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-9.7.1.tgz#817b5018303a2c6160011e201a8d21fca2f3e47b" + integrity sha512-yYTnW1jqv586M8dD4TxTa/9wkj84gJuHeDh9F13z7XGeZ/clUN0XP43Y5Jzv80Q3M80VlEuTpABYMGpPqBAw8w== dependencies: "@types/lodash" "^4.14.116" "@types/numeral" "^0.0.25" From 862f755a3bbbca9b0b0a4e5064b8e998e31f0454 Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Thu, 28 Mar 2019 14:58:14 -0700 Subject: [PATCH 5/5] snaps --- .../components/tutorial/__snapshots__/introduction.test.js.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap index 41cee89145e71..79aafa88977d9 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/introduction.test.js.snap @@ -31,7 +31,7 @@ exports[`props exportedFieldsUrl 1`] = ` fill={false} href="exported_fields_url" iconSide="left" - rel="noopener" + rel="noopener noreferrer" size="m" target="_blank" type="button"