From 59791584a41806f9df6edcf431ef7a6a49d2adda Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Wed, 28 Jan 2015 16:09:59 -0700 Subject: [PATCH 1/2] move buttons out of ul --- .../plugins/visualize/editor/sidebar.html | 43 ++++++++++--------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/src/kibana/plugins/visualize/editor/sidebar.html b/src/kibana/plugins/visualize/editor/sidebar.html index 977b3cf7fbf25..d1680538ee79c 100644 --- a/src/kibana/plugins/visualize/editor/sidebar.html +++ b/src/kibana/plugins/visualize/editor/sidebar.html @@ -17,26 +17,27 @@ - +
+ + + +
- \ No newline at end of file + + From 7403e998fe180f6c448092afa592c4cdc99da645 Mon Sep 17 00:00:00 2001 From: Joe Fleming Date: Wed, 28 Jan 2015 16:10:08 -0700 Subject: [PATCH 2/2] fix styles, use flexbox --- .../visualize/editor/styles/editor.less | 27 +++++++++++-------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/kibana/plugins/visualize/editor/styles/editor.less b/src/kibana/plugins/visualize/editor/styles/editor.less index 62229443cf134..5ea468dbc0151 100644 --- a/src/kibana/plugins/visualize/editor/styles/editor.less +++ b/src/kibana/plugins/visualize/editor/styles/editor.less @@ -50,33 +50,38 @@ &-sidebar { .flex-parent(0, 0, auto); - overflow: auto; + // overflow: auto; // overrided for tablet and desktop @media (min-width: @screen-md-min) { .flex-basis(@vis-editor-sidebar-basis); min-width: @vis-editor-sidebar-min-width; max-width: @vis-editor-sidebar-min-width; - margin-bottom: (@input-height-base * 2) - 3; + // margin-bottom: (@input-height-base * 2) - 3; } - &-buttons { - // overrides for tablet and desktop - @media (min-width: @screen-md-min) { - position: absolute; - bottom: 0; - min-width: @vis-editor-sidebar-min-width; - } - } .sidebar-item { border-top: 0 !important; } .sidebar-container { - .flex(1, 0, auto); + .flex-parent(1, 1, auto); background-color: @body-bg; border-right-color: @sidebar-bg; + + form { + .flex-parent(1, 1, auto); + + > ul { + .flex(1, 1, auto); + overflow-y: auto; + } + + > .vis-edit-sidebar-buttons { + .flex(0, 0, auto) + } + } } .sidebar-item-title {