diff --git a/src/platform/plugins/shared/console/public/application/components/settings/settings_editor.tsx b/src/platform/plugins/shared/console/public/application/components/settings/settings_editor.tsx index 29af8cc11135e..5befa40c34334 100644 --- a/src/platform/plugins/shared/console/public/application/components/settings/settings_editor.tsx +++ b/src/platform/plugins/shared/console/public/application/components/settings/settings_editor.tsx @@ -36,8 +36,6 @@ const styles = { }; const DEBOUNCE_DELAY = 500; -const ON_LABEL = i18n.translate('console.settingsPage.onLabel', { defaultMessage: 'On' }); -const OFF_LABEL = i18n.translate('console.settingsPage.offLabel', { defaultMessage: 'Off' }); const onceTimeInterval = () => i18n.translate('console.settingsPage.refreshInterval.onceTimeInterval', { @@ -241,36 +239,45 @@ export const SettingsEditor = (props: Props) => { })} /> toggleSavingToHistory(e.target.checked)} /> toggleKeyboardShortcuts(e.target.checked)} /> toggleAccessibilityOverlay(e.target.checked)} /> @@ -303,6 +310,7 @@ export const SettingsEditor = (props: Props) => { })} /> { css={styles.minWidthControl} compressed data-test-subj="setting-font-size-input" + aria-labelledby="fontSize-label" value={fontSize} min={6} max={50} @@ -322,26 +331,32 @@ export const SettingsEditor = (props: Props) => { /> setWrapMode(e.target.checked)} id="wrapLines" /> setTripleQuotes(e.target.checked)} id="tripleQuotes" @@ -355,10 +370,12 @@ export const SettingsEditor = (props: Props) => { })} /> {autoCompleteCheckboxes.map((opts) => ( - + opts.stateSetter(e.target.checked)} /> diff --git a/src/platform/plugins/shared/console/public/application/components/settings/settings_form_row.tsx b/src/platform/plugins/shared/console/public/application/components/settings/settings_form_row.tsx index 383eabfb93bd2..0ee3937aada12 100644 --- a/src/platform/plugins/shared/console/public/application/components/settings/settings_form_row.tsx +++ b/src/platform/plugins/shared/console/public/application/components/settings/settings_form_row.tsx @@ -12,17 +12,20 @@ import React from 'react'; import { EuiFlexGroup, EuiFlexItem, EuiFormRow } from '@elastic/eui'; export interface DevToolsSettingsModalProps { + id?: string; label: string; children: React.ReactNode; } -export const SettingsFormRow = ({ label, children }: DevToolsSettingsModalProps) => { +export const SettingsFormRow = ({ id, label, children }: DevToolsSettingsModalProps) => { return ( - {label} + + {label} + diff --git a/x-pack/platform/plugins/private/translations/translations/de-DE.json b/x-pack/platform/plugins/private/translations/translations/de-DE.json index 99341e884ce28..f8dddd97c4804 100644 --- a/x-pack/platform/plugins/private/translations/translations/de-DE.json +++ b/x-pack/platform/plugins/private/translations/translations/de-DE.json @@ -516,8 +516,6 @@ "console.settingsPage.generalSettingsLabel": "Allgemeine Einstellungen", "console.settingsPage.indicesAndAliasesLabelText": "Indizes und Aliasse", "console.settingsPage.manualRefreshLabel": "Vorschläge zur Autovervollständigung manuell aktualisieren", - "console.settingsPage.offLabel": "Aus", - "console.settingsPage.onLabel": "An", "console.settingsPage.pageDescription": "Passen Sie die Konsole an Ihren Workflow an.", "console.settingsPage.pageTitle": "Konsoleinstellungen", "console.settingsPage.refreshButtonLabel": "Aktualisieren", diff --git a/x-pack/platform/plugins/private/translations/translations/fr-FR.json b/x-pack/platform/plugins/private/translations/translations/fr-FR.json index f5712a32ccb9b..6c306fffa2932 100644 --- a/x-pack/platform/plugins/private/translations/translations/fr-FR.json +++ b/x-pack/platform/plugins/private/translations/translations/fr-FR.json @@ -514,8 +514,6 @@ "console.settingsPage.generalSettingsLabel": "Paramètres généraux", "console.settingsPage.indicesAndAliasesLabelText": "Index et alias", "console.settingsPage.manualRefreshLabel": "Actualiser manuellement les suggestions de saisie semi-automatique", - "console.settingsPage.offLabel": "Désactivé", - "console.settingsPage.onLabel": "Activé", "console.settingsPage.pageDescription": "Personnalisez la console en fonction de votre workflow.", "console.settingsPage.pageTitle": "Paramètres de la console", "console.settingsPage.refreshButtonLabel": "Actualiser", diff --git a/x-pack/platform/plugins/private/translations/translations/ja-JP.json b/x-pack/platform/plugins/private/translations/translations/ja-JP.json index 7d266c5801f11..e428533ca4375 100644 --- a/x-pack/platform/plugins/private/translations/translations/ja-JP.json +++ b/x-pack/platform/plugins/private/translations/translations/ja-JP.json @@ -516,8 +516,6 @@ "console.settingsPage.generalSettingsLabel": "一般設定", "console.settingsPage.indicesAndAliasesLabelText": "インデックスとエイリアス", "console.settingsPage.manualRefreshLabel": "自動入力候補を手動で更新", - "console.settingsPage.offLabel": "オフ", - "console.settingsPage.onLabel": "オン", "console.settingsPage.pageDescription": "ワークフローに合わせてコンソールをカスタマイズします。", "console.settingsPage.pageTitle": "コンソール設定", "console.settingsPage.refreshButtonLabel": "更新", diff --git a/x-pack/platform/plugins/private/translations/translations/zh-CN.json b/x-pack/platform/plugins/private/translations/translations/zh-CN.json index f6b61b489f279..a1f7b3a502966 100644 --- a/x-pack/platform/plugins/private/translations/translations/zh-CN.json +++ b/x-pack/platform/plugins/private/translations/translations/zh-CN.json @@ -516,8 +516,6 @@ "console.settingsPage.generalSettingsLabel": "常规设置", "console.settingsPage.indicesAndAliasesLabelText": "索引和别名", "console.settingsPage.manualRefreshLabel": "手动刷新自动完成建议", - "console.settingsPage.offLabel": "关闭", - "console.settingsPage.onLabel": "开启", "console.settingsPage.pageDescription": "定制 Console 以适合您的工作流。", "console.settingsPage.pageTitle": "控制台设置", "console.settingsPage.refreshButtonLabel": "刷新",