diff --git a/src/platform/packages/private/kbn-esql-editor/src/editor_footer/discard_starred_query/discard_starred_query_modal.tsx b/src/platform/packages/private/kbn-esql-editor/src/editor_footer/discard_starred_query/discard_starred_query_modal.tsx index 5efa3a1469354..625b1a4e51fd2 100644 --- a/src/platform/packages/private/kbn-esql-editor/src/editor_footer/discard_starred_query/discard_starred_query_modal.tsx +++ b/src/platform/packages/private/kbn-esql-editor/src/editor_footer/discard_starred_query/discard_starred_query_modal.tsx @@ -22,6 +22,7 @@ import { EuiFlexItem, EuiFlexGroup, EuiHorizontalRule, + useGeneratedHtmlId, } from '@elastic/eui'; export interface DiscardStarredQueryModalProps { @@ -34,15 +35,17 @@ export default function DiscardStarredQueryModal({ onClose }: DiscardStarredQuer const onTransitionModalDismiss = useCallback((e: React.ChangeEvent) => { setDismissModalChecked(e.target.checked); }, []); + const modalTitleId = useGeneratedHtmlId(); return ( onClose()} style={{ width: 700 }} data-test-subj="discard-starred-query-modal" + aria-labelledby={modalTitleId} > - + {i18n.translate('esqlEditor.discardStarredQueryModal.title', { defaultMessage: 'Discard starred query', })} diff --git a/src/platform/packages/private/kbn-esql-editor/src/editor_footer/errors_warnings_popover.tsx b/src/platform/packages/private/kbn-esql-editor/src/editor_footer/errors_warnings_popover.tsx index 11c8537c0fc59..4d20438fb84cb 100644 --- a/src/platform/packages/private/kbn-esql-editor/src/editor_footer/errors_warnings_popover.tsx +++ b/src/platform/packages/private/kbn-esql-editor/src/editor_footer/errors_warnings_popover.tsx @@ -155,13 +155,14 @@ export function ErrorsWarningsFooterPopover({ return items; }, [items, dataErrorsControl]); - const { color, message } = getConstsByType(type, visibleItems.length); + const { color, message, label } = getConstsByType(type, visibleItems.length); const closePopover = useCallback(() => setIsPopoverOpen(false), [setIsPopoverOpen]); return ( setIsOpen(false)} diff --git a/src/platform/packages/private/kbn-esql-editor/src/editor_menu/help_popover.tsx b/src/platform/packages/private/kbn-esql-editor/src/editor_menu/help_popover.tsx index 1d5c3c0aef566..f6681dbbabb2f 100644 --- a/src/platform/packages/private/kbn-esql-editor/src/editor_menu/help_popover.tsx +++ b/src/platform/packages/private/kbn-esql-editor/src/editor_menu/help_popover.tsx @@ -297,6 +297,7 @@ export const HelpPopover: React.FC<{ return ( <> setPopoverIsOpen(false)} diff --git a/src/platform/packages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx b/src/platform/packages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx index 900cb7d1598ad..297c5ffe15a34 100644 --- a/src/platform/packages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx +++ b/src/platform/packages/private/kbn-index-editor/src/components/grid_custom_renderers/add_column_popover.tsx @@ -114,6 +114,9 @@ export const AddColumnPopover = ({ return ( +