From e136f6e2ed08bffa367ce657cce8d60ae3a7f61a Mon Sep 17 00:00:00 2001 From: "konrad.szwarc" <29123534+szwarckonrad@users.noreply.github.com> Date: Tue, 7 Apr 2026 14:24:19 -0600 Subject: [PATCH] Fix artifact FTR tests broken by artifacts regrouping page structure change --- .../apps/integrations/artifact_entries_list.ts | 14 ++++++-------- .../apps/integrations/trusted_apps_list.ts | 11 +++++------ 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts b/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts index 504d69aa0c355..09d4b96e2741c 100644 --- a/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts +++ b/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/artifact_entries_list.ts @@ -38,8 +38,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { } }; - // Failing: See https://github.com/elastic/kibana/issues/261850 - describe.skip('For each artifact list under management', function () { + describe('For each artifact list under management', function () { targetTags(this, ['@ess', '@serverless']); this.timeout(60_000 * 5); @@ -221,8 +220,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { }; for (const testData of getArtifactsListTestsData()) { - // Failing: See https://github.com/elastic/kibana/issues/261849 - describe.skip(`When on the ${testData.title} entries list`, function () { + describe(`When on the ${testData.title} entries list`, function () { beforeEach(async () => { policyInfo = await policyTestResources.createPolicy(); await removeAllArtifactLists(); @@ -237,8 +235,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { } }); - it(`should not show page title if there is no ${testData.title} entry`, async () => { - await testSubjects.missingOrFail('header-page-title'); + it(`should show empty state if there is no ${testData.title} entry`, async () => { + await testSubjects.existOrFail(`${testData.pagePrefix}-emptyState`); }); it(`should be able to add a new ${testData.title} entry`, async () => { @@ -300,8 +298,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { await deleteArtifact(testData); // We only expect one artifact to have been visible await testSubjects.missingOrFail(testData.delete.card); - // Header has gone because there is no artifact - await testSubjects.missingOrFail('header-page-title'); + // Empty state is shown because there is no artifact + await testSubjects.existOrFail(`${testData.pagePrefix}-emptyState`); }); }); } diff --git a/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/trusted_apps_list.ts b/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/trusted_apps_list.ts index be189889ebc12..840291dca0096 100644 --- a/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/trusted_apps_list.ts +++ b/x-pack/solutions/security/test/security_solution_endpoint/apps/integrations/trusted_apps_list.ts @@ -14,16 +14,15 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { const testSubjects = getService('testSubjects'); const toasts = getService('toasts'); - // Failing: See https://github.com/elastic/kibana/issues/261829 - describe.skip('When on the Trusted Apps list', function () { + describe('When on the Trusted Apps list', function () { targetTags(this, ['@ess', '@serverless']); before(async () => { await pageObjects.trustedApps.navigateToTrustedAppsList(); }); - it('should not show page title if there is no trusted app', async () => { - await testSubjects.missingOrFail('header-page-title'); + it('should show empty state if there is no trusted app', async () => { + await testSubjects.existOrFail('trustedAppsListPage-emptyState'); }); it('should be able to add a new trusted app and remove it', async () => { @@ -50,8 +49,8 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { await testSubjects.waitForDeleted('trustedAppsListPage-deleteModal-submitButton'); // We only expect one trusted app to have been visible await testSubjects.missingOrFail('trustedAppsListPage-card'); - // Header has gone because there is no trusted app - await testSubjects.missingOrFail('header-page-title'); + // Empty state is shown because there is no trusted app + await testSubjects.existOrFail('trustedAppsListPage-emptyState'); }); }); };