From 04621ee8977c7c981fbfcc08d302244e1fa5cf7d Mon Sep 17 00:00:00 2001 From: lukasolson Date: Thu, 2 Apr 2026 14:17:23 +0000 Subject: [PATCH] Default discover.embeddableTransforms to true when unset Use true as the fallback for unset flags in server state, getBooleanValue$, and client getEmbeddableTransformsEnabled. Explicit false keeps legacy path. The discover services test mock returns true to match production default. Refs #260103 Made-with: Cursor --- .../plugins/shared/discover/public/__mocks__/services.ts | 2 +- src/platform/plugins/shared/discover/public/build_services.ts | 2 +- src/platform/plugins/shared/discover/server/plugin.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/platform/plugins/shared/discover/public/__mocks__/services.ts b/src/platform/plugins/shared/discover/public/__mocks__/services.ts index 75780617e17e3..eb69521456ec5 100644 --- a/src/platform/plugins/shared/discover/public/__mocks__/services.ts +++ b/src/platform/plugins/shared/discover/public/__mocks__/services.ts @@ -330,7 +330,7 @@ export function createDiscoverServicesMock(): DiscoverServices { discoverFeatureFlags: { getCascadeLayoutEnabled: jest.fn(() => false), getIsEsqlDefault: jest.fn(() => false), - getEmbeddableTransformsEnabled: jest.fn(() => false), + getEmbeddableTransformsEnabled: jest.fn(() => true), }, embeddableEditor: { isByValueEditor: jest.fn(() => false), diff --git a/src/platform/plugins/shared/discover/public/build_services.ts b/src/platform/plugins/shared/discover/public/build_services.ts index a5c74308a28df..e510e3e1ed45f 100644 --- a/src/platform/plugins/shared/discover/public/build_services.ts +++ b/src/platform/plugins/shared/discover/public/build_services.ts @@ -212,7 +212,7 @@ export const buildServices = ({ getIsEsqlDefault: () => core.featureFlags.getBooleanValue(IS_ESQL_DEFAULT_FEATURE_FLAG_KEY, false), getEmbeddableTransformsEnabled: () => - core.featureFlags.getBooleanValue(EMBEDDABLE_TRANSFORMS_FEATURE_FLAG_KEY, false), + core.featureFlags.getBooleanValue(EMBEDDABLE_TRANSFORMS_FEATURE_FLAG_KEY, true), }, docLinks: core.docLinks, embeddable: plugins.embeddable, diff --git a/src/platform/plugins/shared/discover/server/plugin.ts b/src/platform/plugins/shared/discover/server/plugin.ts index 5d915bc5a265f..5fd3705257f8c 100644 --- a/src/platform/plugins/shared/discover/server/plugin.ts +++ b/src/platform/plugins/shared/discover/server/plugin.ts @@ -38,7 +38,7 @@ export class DiscoverServerPlugin { private readonly config: ConfigSchema; private subscriptions: Subscription[] = []; - private embeddableTransformsEnabled = false; + private embeddableTransformsEnabled = true; constructor(initializerContext: PluginInitializerContext) { this.config = initializerContext.config.get();