Skip to content

[Fix] re-introduce sln breadcrumbs to unified rules #260289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baileycash-elastic merged 2 commits into from
Apr 1, 2026
Merged

[Fix] re-introduce sln breadcrumbs to unified rules #260289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3ddb3f
re-introduce sln breadcrumbs to unified rules
baileycash-elastic Mar 30, 2026
9a7c4e4
Merge branch 'main' into unified-rules-breadcrumbs-reg
baileycash-elastic Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/platform/plugins/shared/triggers_actions_ui/public/application/home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { CreateRuleButton } from './sections/rules_list/components/create_rule_b
import type { Section } from './constants';
import { routeToRules, routeToLogs } from './constants';
import { getAlertingSectionBreadcrumb } from './lib/breadcrumb';
import { useSetBreadcrumbs } from './hooks/use_set_breadcrumbs';
import { getCurrentDocTitle } from './lib/doc_title';

import { HealthCheck } from './components/health_check';
Expand Down Expand Up @@ -52,8 +51,8 @@ export const TriggersActionsUIHome: React.FunctionComponent<RouteComponentProps<
ruleTypeRegistry,
application: { navigateToApp },
cps,
setBreadcrumbs,
} = useKibana().services;
const setBreadcrumbs = useSetBreadcrumbs();
const { authorizedToReadAnyRules, authorizedToCreateAnyRules } = useGetRuleTypesPermissions({
http,
toasts,
Expand Down
36 changes: 0 additions & 36 deletions ...atform/plugins/shared/triggers_actions_ui/public/application/hooks/use_set_breadcrumbs.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions .../triggers_actions_ui/public/application/sections/rule_details/components/rule_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import {
hasManageApiKeysCapability,
} from '../../../lib/capabilities';
import { getRulesBreadcrumbWithHref } from '../../../lib/breadcrumb';
import { useSetBreadcrumbs } from '../../../hooks/use_set_breadcrumbs';
import { getCurrentDocTitle } from '../../../lib/doc_title';
import type {
Rule,
Expand Down Expand Up @@ -109,9 +108,9 @@ export const RuleDetails: React.FunctionComponent<RuleDetailsProps> = ({
theme,
userProfile,
notifications: { toasts },
setBreadcrumbs,
} = useKibana().services;
const { capabilities, getUrlForApp } = application;
const setBreadcrumbs = useSetBreadcrumbs();

const [rulesToDelete, setRulesToDelete] = useState<string[]>([]);
const [rulesToUpdateAPIKey, setRulesToUpdateAPIKey] = useState<string[]>([]);
Expand Down
3 changes: 1 addition & 2 deletions ...ers_actions_ui/public/application/sections/rule_details/components/rule_details_route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { withActionOperations } from '../../common/components/with_actions_api_o
import { useKibana } from '../../../../common/lib/kibana';
import { CenterJustifiedSpinner } from '../../../components/center_justified_spinner';
import { getRulesBreadcrumbWithHref } from '../../../lib/breadcrumb';
import { useSetBreadcrumbs } from '../../../hooks/use_set_breadcrumbs';

type RuleDetailsRouteProps = RouteComponentProps<{
ruleId: string;
Expand All @@ -44,12 +43,12 @@ export const RuleDetailsRoute: React.FunctionComponent<RuleDetailsRouteProps> =
notifications: { toasts },
spaces: spacesApi,
application: { getUrlForApp },
setBreadcrumbs,
} = useKibana().services;

const { basePath } = http;

// sets a baseline breadcrumb regardless of the outcome of loading the rule
const setBreadcrumbs = useSetBreadcrumbs();
useEffect(() => {
setBreadcrumbs([getRulesBreadcrumbWithHref(getUrlForApp)]);
}, [getUrlForApp, setBreadcrumbs]);
Expand Down
3 changes: 1 addition & 2 deletions ...gins/shared/triggers_actions_ui/public/application/sections/rule_form/rule_form_route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { useHistory, useLocation, useParams } from 'react-router-dom';
import { ProjectRoutingAccess, useRouteBasedCpsPickerAccess } from '@kbn/cps-utils';
import { useKibana } from '../../../common/lib/kibana';
import { getAlertingSectionBreadcrumb } from '../../lib/breadcrumb';
import { useSetBreadcrumbs } from '../../hooks/use_set_breadcrumbs';
import { getCurrentDocTitle } from '../../lib/doc_title';
import { RuleTemplateError } from './components/rule_template_error';
import { CenterJustifiedSpinner } from '../../components/center_justified_spinner';
Expand All @@ -35,9 +34,9 @@ export const RuleFormRoute = () => {
contentManagement,
uiActions,
chrome,
setBreadcrumbs,
...startServices
} = useKibana().services;
const setBreadcrumbs = useSetBreadcrumbs();
const { getUrlForApp } = application;

const location = useLocation<{ returnApp?: string; returnPath?: string }>();
Expand Down
3 changes: 1 addition & 2 deletions .../plugins/shared/triggers_actions_ui/public/application/sections/rules_page/rules_page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { RulesListDocLink } from '../rules_list/components/rules_list_doc_link';
import { RulesPageTemplate } from './rules_page_template';
import { useKibana } from '../../../common/lib/kibana';
import { getAlertingSectionBreadcrumb, getRulesBreadcrumbWithHref } from '../../lib/breadcrumb';
import { useSetBreadcrumbs } from '../../hooks/use_set_breadcrumbs';
import { CreateRuleButton } from '../rules_list/components/create_rule_button';
import { getCurrentDocTitle } from '../../lib/doc_title';
import type { Section } from '../../constants';
Expand All @@ -44,8 +43,8 @@ const RulesPage = () => {
notifications: { toasts },
ruleTypeRegistry,
cps,
setBreadcrumbs,
} = useKibana().services;
const setBreadcrumbs = useSetBreadcrumbs();

const { authorizedToReadAnyRules, authorizedToCreateAnyRules } = useGetRuleTypesPermissions({
http,
Expand Down
Loading