Skip to content

[Alerting v2] [Rule authoring] Block comma key in number input component #257454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiannisnikolopoulos merged 1 commit into from
Mar 12, 2026
Merged

[Alerting v2] [Rule authoring] Block comma key in number input component #257454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...form/packages/shared/response-ops/alerting-v2-rule-form/form/fields/number_input.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ describe('NumberInput', () => {
});

describe('key filtering', () => {
it.each(['-', '+', '.', 'e', 'E'])('prevents typing "%s"', (key) => {
it.each(['-', '+', ',', '.', 'e', 'E'])('prevents typing "%s"', (key) => {
renderInput({ value: 5 });
const input = screen.getByTestId('testNumberInput');

Expand Down
2 changes: 1 addition & 1 deletion x-pack/platform/packages/shared/response-ops/alerting-v2-rule-form/form/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ describe('utils', () => {

describe('numeric input helpers', () => {
it('exposes invalid number keys for EuiFieldNumber guards', () => {
expect(INVALID_NUMBER_KEYS).toEqual(['-', '+', '.', 'e', 'E']);
expect(INVALID_NUMBER_KEYS).toEqual(['-', '+', ',', '.', 'e', 'E']);
});
});
});
2 changes: 1 addition & 1 deletion x-pack/platform/packages/shared/response-ops/alerting-v2-rule-form/form/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type { DataViewFieldMap } from '@kbn/data-views-plugin/common';

type TimeUnit = 's' | 'm' | 'h' | 'd';
export const POSITIVE_INTEGER_REGEX = /^[1-9][0-9]*$/;
export const INVALID_NUMBER_KEYS = ['-', '+', '.', 'e', 'E'];
export const INVALID_NUMBER_KEYS = ['-', '+', ',', '.', 'e', 'E'];

const TIME_UNITS: Record<TimeUnit, string> = {
s: i18n.translate('xpack.alertingV2.ruleForm.timeUnits.seconds', {
Expand Down
Loading