From 2bf0cf4acaf5d4601c9628d79899fe7cea8454e3 Mon Sep 17 00:00:00 2001 From: Tomasz Kajtoch Date: Mon, 2 Mar 2026 16:10:45 +0100 Subject: [PATCH 1/2] refactor: replace deprecated icons - @elastic/kibana-cases --- .../src/tooltip/icon_with_count.test.tsx | 4 ++-- .../src/tooltip/tooltip_content.tsx | 2 +- .../actions/assignees/no_selected_assignees.tsx | 2 +- .../actions/assignees/use_assignees_action.test.tsx | 2 +- .../actions/assignees/use_assignees_action.tsx | 2 +- .../actions/copy_id/use_copy_id_action.test.tsx | 2 +- .../components/actions/copy_id/use_copy_id_action.tsx | 2 +- .../cases/public/components/add_comment/index.tsx | 2 +- .../public/components/all_cases/assignees_filter.tsx | 2 +- .../public/components/all_cases/columns_popover.tsx | 2 +- .../components/all_cases/multi_select_filter.tsx | 2 +- .../cases/public/components/all_cases/nav_buttons.tsx | 2 +- .../shared/cases/public/components/all_cases/table.tsx | 2 +- .../public/components/all_cases/table_filters.tsx | 2 +- .../cases/public/components/all_cases/use_actions.tsx | 2 +- .../components/all_cases/use_bulk_actions.test.tsx | 2 +- .../cases/public/components/all_cases/utility_bar.tsx | 2 +- .../cases/public/components/app/use_readonly_header.ts | 2 +- .../public/components/attachments/alert/show_alert.tsx | 2 +- .../public/components/attachments/event/show_event.tsx | 2 +- .../public/components/attachments/file/add_file.tsx | 2 +- .../attachments/file/file_actions_popover_button.tsx | 10 +++++----- .../public/components/case_action_bar/actions.test.tsx | 8 +++----- .../public/components/case_action_bar/actions.tsx | 4 ++-- .../public/components/case_action_bar/index.test.tsx | 6 +++--- .../components/case_view/components/user_list.tsx | 2 +- .../configure_cases/connectors_dropdown.test.tsx | 2 +- .../components/configure_cases/connectors_dropdown.tsx | 2 +- .../cases/public/components/create/submit_button.tsx | 2 +- .../custom_fields/custom_fields_list/index.tsx | 2 +- .../cases/public/components/custom_fields/index.tsx | 2 +- .../public/components/edit_connector/push_button.tsx | 2 +- .../experimental_badge/experimental_badge.tsx | 2 +- .../cases/public/components/filter_popover/index.tsx | 2 +- .../components/markdown_editor/plugins/lens/plugin.tsx | 2 +- .../cases/public/components/observable_types/index.tsx | 2 +- .../observable_types/observable_types_list/index.tsx | 2 +- .../public/components/observables/add_observable.tsx | 2 +- .../observables/observable_actions_popover_button.tsx | 2 +- .../cases/public/components/property_actions/index.tsx | 2 +- .../public/components/recent_cases/recent_cases.tsx | 6 +----- .../public/components/status/status_popover_button.tsx | 2 +- .../components/system_actions/cases/cases_params.tsx | 2 +- .../shared/cases/public/components/templates/index.tsx | 2 +- .../public/components/templates/templates_list.tsx | 2 +- .../templates_v2/components/templates_bulk_actions.tsx | 4 ++-- .../templates_v2/components/templates_list_header.tsx | 4 ++-- .../components/templates_table_empty_prompt.tsx | 2 +- .../templates_v2/hooks/use_templates_columns.tsx | 4 ++-- .../cases/public/components/user_actions/assignees.tsx | 2 +- .../components/user_actions/comment/comment.test.tsx | 6 +++--- .../components/user_actions/move_to_reference.tsx | 2 +- .../property_actions/alert_property_actions.test.tsx | 6 +++--- .../property_actions/alert_property_actions.tsx | 2 +- .../property_actions/event_property_actions.test.tsx | 6 +++--- .../property_actions/event_property_actions.tsx | 2 +- .../public/components/user_profiles/no_matches.tsx | 2 +- .../apps/cases/group2/attachment_framework.ts | 2 +- .../cases/public/attachments/external_reference.tsx | 2 +- .../cases/public/attachments/persistable_state.tsx | 2 +- .../cases/attachments/indicator/utils/attachments.tsx | 4 ++-- 61 files changed, 81 insertions(+), 87 deletions(-) diff --git a/src/platform/packages/shared/kbn-cases-components/src/tooltip/icon_with_count.test.tsx b/src/platform/packages/shared/kbn-cases-components/src/tooltip/icon_with_count.test.tsx index 9dd48c3f77531..d3b59197ccf33 100644 --- a/src/platform/packages/shared/kbn-cases-components/src/tooltip/icon_with_count.test.tsx +++ b/src/platform/packages/shared/kbn-cases-components/src/tooltip/icon_with_count.test.tsx @@ -14,13 +14,13 @@ import { IconWithCount } from './icon_with_count'; describe('IconWithCount', () => { it('renders component correctly', () => { - const res = render(); + const res = render(); expect(res.getByTestId('comment-count-icon')).toBeInTheDocument(); }); it('renders count correctly', () => { - const res = render(); + const res = render(); expect(res.getByText(100)).toBeInTheDocument(); }); diff --git a/src/platform/packages/shared/kbn-cases-components/src/tooltip/tooltip_content.tsx b/src/platform/packages/shared/kbn-cases-components/src/tooltip/tooltip_content.tsx index 64ada2d80e5b3..eb9f3be202465 100644 --- a/src/platform/packages/shared/kbn-cases-components/src/tooltip/tooltip_content.tsx +++ b/src/platform/packages/shared/kbn-cases-components/src/tooltip/tooltip_content.tsx @@ -30,7 +30,7 @@ const CaseTooltipContentComponent = React.memo( - + diff --git a/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/no_selected_assignees.tsx b/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/no_selected_assignees.tsx index e73a568be5448..16a93214169c3 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/no_selected_assignees.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/no_selected_assignees.tsx @@ -21,7 +21,7 @@ const NoSelectedAssigneesComponent: React.FC<{ totalSelectedCases: number }> = ( data-test-subj="case-user-profiles-assignees-no-selected-assignees" > - + diff --git a/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.test.tsx index ec801035f2aa5..718ed72a650d1 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.test.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.test.tsx @@ -43,7 +43,7 @@ describe('useAssigneesAction', () => { "disabled": false, "icon": , "key": "cases-bulk-action-assignees", "name": "Edit assignees", diff --git a/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.tsx b/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.tsx index 2faae87d3ae38..74ca4b54426ef 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/actions/assignees/use_assignees_action.tsx @@ -33,7 +33,7 @@ export const useAssigneesAction = ({ onAction, onActionSuccess, isDisabled }: Us onClick: () => openFlyout(selectedCases), disabled: isActionDisabled, 'data-test-subj': 'cases-bulk-action-assignees', - icon: , + icon: , key: 'cases-bulk-action-assignees', }; }; diff --git a/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.test.tsx index c94d310296155..b20f9bd32ca67 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.test.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.test.tsx @@ -45,7 +45,7 @@ describe('useCopyIDAction', () => { "data-test-subj": "cases-action-copy-id", "icon": , "key": "cases-action-copy-id", "name": diff --git a/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.tsx b/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.tsx index 260726daa5950..5beecadb77ca5 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/actions/copy_id/use_copy_id_action.tsx @@ -26,7 +26,7 @@ export const useCopyIDAction = ({ onActionSuccess }: UseCopyIDActionProps) => { }); }, 'data-test-subj': 'cases-action-copy-id', - icon: , + icon: , key: 'cases-action-copy-id', }; }; diff --git a/x-pack/platform/plugins/shared/cases/public/components/add_comment/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/add_comment/index.tsx index 74a58db1943a3..c5e659cb84996 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/add_comment/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/add_comment/index.tsx @@ -236,7 +236,7 @@ export const AddComment = React.memo( = ( button={ = ({ aria-label={i18n.DRAG_HANDLE} grow={false} > - + )} diff --git a/x-pack/platform/plugins/shared/cases/public/components/all_cases/multi_select_filter.tsx b/x-pack/platform/plugins/shared/cases/public/components/all_cases/multi_select_filter.tsx index f260bf52e279c..9c9a7972ab2c0 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/all_cases/multi_select_filter.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/all_cases/multi_select_filter.tsx @@ -133,7 +133,7 @@ export const MultiSelectFilter = ({ ${buttonCss} `} data-test-subj={`options-filter-popover-button-${id}`} - iconType={buttonIconType || 'arrowDown'} + iconType={buttonIconType || 'chevronSingleDown'} onClick={toggleIsPopoverOpen} isSelected={isPopoverOpen} numFilters={showActiveOptionsNumber ? options.length : undefined} diff --git a/x-pack/platform/plugins/shared/cases/public/components/all_cases/nav_buttons.tsx b/x-pack/platform/plugins/shared/cases/public/components/all_cases/nav_buttons.tsx index 310340f0366eb..102092c364e22 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/all_cases/nav_buttons.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/all_cases/nav_buttons.tsx @@ -66,7 +66,7 @@ export const NavButtons: FunctionComponent = ({ actionsErrors }) => { fill onClick={navigateToCreateCaseClick} href={getCreateCaseUrl()} - iconType="plusInCircle" + iconType="plusCircle" data-test-subj="createNewCaseBtn" > {i18n.CREATE_CASE_TITLE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/all_cases/table.tsx b/x-pack/platform/plugins/shared/cases/public/components/all_cases/table.tsx index 72e785ff5967d..fd29d428a7839 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/all_cases/table.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/all_cases/table.tsx @@ -111,7 +111,7 @@ export const CasesTable: FunctionComponent = ({ size="s" onClick={navigateToCreateCaseClick} href={getCreateCaseUrl()} - iconType="plusInCircle" + iconType="plusCircle" data-test-subj="cases-table-add-case" > {i18n.CREATE_CASE_TITLE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/all_cases/table_filters.tsx b/x-pack/platform/plugins/shared/cases/public/components/all_cases/table_filters.tsx index f5b51c834336c..f5811224f44a1 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/all_cases/table_filters.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/all_cases/table_filters.tsx @@ -126,7 +126,7 @@ const CasesTableFiltersComponent = ({ {i18n.CREATE_CASE_TITLE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/all_cases/use_actions.tsx b/x-pack/platform/plugins/shared/cases/public/components/all_cases/use_actions.tsx index 2594bd18a9dca..a9b9a4a988a3a 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/all_cases/use_actions.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/all_cases/use_actions.tsx @@ -190,7 +190,7 @@ const ActionColumnComponent: React.FC<{ theCase: CaseUI; disableActions: boolean button={ { "disabled": false, "icon": , "key": "cases-bulk-action-assignees", "name": "Edit assignees", diff --git a/x-pack/platform/plugins/shared/cases/public/components/all_cases/utility_bar.tsx b/x-pack/platform/plugins/shared/cases/public/components/all_cases/utility_bar.tsx index ef8155cb3cc1d..f7306b76b45f6 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/all_cases/utility_bar.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/all_cases/utility_bar.tsx @@ -188,7 +188,7 @@ export const CasesTableUtilityBar: FunctionComponent = React.memo( onClick={togglePopover} size="xs" iconSide="right" - iconType="arrowDown" + iconType="chevronSingleDown" flush="left" data-test-subj="case-table-bulk-actions-link-icon" > diff --git a/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts b/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts index 40c4d25468d15..35eba6a45313d 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts +++ b/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts @@ -25,7 +25,7 @@ export function useReadonlyHeader() { chrome.setBadge({ text: i18n.READ_ONLY_BADGE_TEXT, tooltip: i18n.READ_ONLY_BADGE_TOOLTIP, - iconType: 'glasses', + iconType: 'readOnly', }); } }, [chrome, permissions]); diff --git a/x-pack/platform/plugins/shared/cases/public/components/attachments/alert/show_alert.tsx b/x-pack/platform/plugins/shared/cases/public/components/attachments/alert/show_alert.tsx index 8166d6400a49d..b6edb828c3474 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/attachments/alert/show_alert.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/attachments/alert/show_alert.tsx @@ -41,7 +41,7 @@ const UserActionShowAlertComponent = ({ aria-label={i18n.SHOW_ALERT_TOOLTIP} data-test-subj={`comment-action-show-alert-${id}`} onClick={onClick} - iconType="arrowRight" + iconType="chevronSingleRight" id={`${id}-show-alert`} /> diff --git a/x-pack/platform/plugins/shared/cases/public/components/attachments/event/show_event.tsx b/x-pack/platform/plugins/shared/cases/public/components/attachments/event/show_event.tsx index a8358cccddfe1..65dda4c59aa60 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/attachments/event/show_event.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/attachments/event/show_event.tsx @@ -41,7 +41,7 @@ const UserActionShowEventComponent = ({ aria-label={i18n.SHOW_EVENT_TOOLTIP} data-test-subj={`comment-action-show-event-${id}`} onClick={onClick} - iconType="arrowRight" + iconType="chevronSingleRight" id={`${id}-show-event`} /> diff --git a/x-pack/platform/plugins/shared/cases/public/components/attachments/file/add_file.tsx b/x-pack/platform/plugins/shared/cases/public/components/attachments/file/add_file.tsx index 59cc4d55caba0..458949d90582c 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/attachments/file/add_file.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/attachments/file/add_file.tsx @@ -111,7 +111,7 @@ const AddFileComponent: React.FC = ({ caseId }) => { { if (theFile.hash?.md5) { navigator.clipboard.writeText(theFile.hash.md5).then(() => { @@ -84,7 +84,7 @@ export const FileActionsPopoverButton: React.FC<{ caseId: string; theFile: FileJ theFile.hash?.sha1 ? { name: 'SHA1', - icon: 'copyClipboard', + icon: 'copy', onClick: () => { if (theFile.hash?.sha1) { navigator.clipboard.writeText(theFile.hash.sha1).then(() => { @@ -99,7 +99,7 @@ export const FileActionsPopoverButton: React.FC<{ caseId: string; theFile: FileJ theFile.hash?.sha256 ? { name: 'SHA256', - icon: 'copyClipboard', + icon: 'copy', onClick: () => { if (theFile.hash?.sha256) { navigator.clipboard.writeText(theFile.hash.sha256).then(() => { @@ -118,7 +118,7 @@ export const FileActionsPopoverButton: React.FC<{ caseId: string; theFile: FileJ if (fileHashesAvailable) { mainPanelItems.push({ name: i18n.COPY_FILE_HASH, - icon: 'copyClipboard', + icon: 'copy', panel: 1, 'data-test-subj': 'cases-files-copy-hash-button', }); @@ -158,7 +158,7 @@ export const FileActionsPopoverButton: React.FC<{ caseId: string; theFile: FileJ button={ { .find('button[data-test-subj="property-actions-case-ellipses"]') .first() .simulate('click'); - wrapper.find('button[data-test-subj="property-actions-case-copyClipboard"]').simulate('click'); + wrapper.find('button[data-test-subj="property-actions-case-copy"]').simulate('click'); expect(navigator.clipboard.writeText).toHaveBeenCalledWith(basicCase.id); @@ -96,9 +96,7 @@ describe('CaseView actions', () => { .first() .simulate('click'); expect(wrapper.find('[data-test-subj="property-actions-case-trash"]').exists()).toBeFalsy(); - expect( - wrapper.find('[data-test-subj="property-actions-case-copyClipboard"]').exists() - ).toBeTruthy(); + expect(wrapper.find('[data-test-subj="property-actions-case-copy"]').exists()).toBeTruthy(); }); it('toggle delete modal and confirm', async () => { @@ -145,7 +143,7 @@ describe('CaseView actions', () => { .first() .simulate('click'); expect( - wrapper.find('[data-test-subj="property-actions-case-popout"]').first().prop('aria-label') + wrapper.find('[data-test-subj="property-actions-case-external"]').first().prop('aria-label') ).toEqual(i18n.VIEW_INCIDENT(basicPush.externalTitle)); }); }); diff --git a/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.tsx b/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.tsx index 8db3e497f19ab..db72a1514c489 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.tsx @@ -43,7 +43,7 @@ const ActionsComponent: React.FC = ({ caseData, currentExternal () => [ { type: AttachmentActionType.BUTTON as const, - iconType: 'copyClipboard', + iconType: 'copy', label: i18n.COPY_ID_ACTION_LABEL, onClick: () => { navigator.clipboard.writeText(caseData.id); @@ -54,7 +54,7 @@ const ActionsComponent: React.FC = ({ caseData, currentExternal ? [ { type: AttachmentActionType.BUTTON as const, - iconType: 'popout', + iconType: 'external', label: i18n.VIEW_INCIDENT(currentExternalIncident?.externalTitle ?? ''), onClick: () => window.open(currentExternalIncident?.externalUrl, '_blank'), }, diff --git a/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/index.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/index.test.tsx index b636cc49aa8e8..3e0a07eea0481 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/index.test.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/index.test.tsx @@ -157,7 +157,7 @@ describe('CaseActionBar', () => { await userEvent.click(screen.getByTestId('property-actions-case-ellipses')); expect(screen.queryByText('Delete case')).not.toBeInTheDocument(); expect(screen.queryByTestId('property-actions-case-trash')).not.toBeInTheDocument(); - expect(screen.getByTestId('property-actions-case-copyClipboard')).toBeInTheDocument(); + expect(screen.getByTestId('property-actions-case-copy')).toBeInTheDocument(); }); it('should show the the delete item in the menu when the user does have delete privileges', async () => { @@ -183,7 +183,7 @@ describe('CaseActionBar', () => { await userEvent.click(screen.getByTestId('property-actions-case-ellipses')); await waitFor(() => { - expect(screen.getByTestId('property-actions-case-popout')).toBeInTheDocument(); + expect(screen.getByTestId('property-actions-case-external')).toBeInTheDocument(); }); }); @@ -192,6 +192,6 @@ describe('CaseActionBar', () => { await userEvent.click(screen.getByTestId('property-actions-case-ellipses')); - expect(screen.queryByTestId('property-actions-case-popout')).not.toBeInTheDocument(); + expect(screen.queryByTestId('property-actions-case-external')).not.toBeInTheDocument(); }); }); diff --git a/x-pack/platform/plugins/shared/cases/public/components/case_view/components/user_list.tsx b/x-pack/platform/plugins/shared/cases/public/components/case_view/components/user_list.tsx index 445974fcd2916..299d839f945b4 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/case_view/components/user_list.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/case_view/components/user_list.tsx @@ -61,7 +61,7 @@ const renderUsers = ( { diff --git a/x-pack/platform/plugins/shared/cases/public/components/configure_cases/connectors_dropdown.tsx b/x-pack/platform/plugins/shared/cases/public/components/configure_cases/connectors_dropdown.tsx index 2296ca0c6ba2b..d7d48d1cb713a 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/configure_cases/connectors_dropdown.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/configure_cases/connectors_dropdown.tsx @@ -51,7 +51,7 @@ const noConnectorOption = { margin-right: 13px; margin-bottom: 0 !important; `} - type="minusInCircle" + type="minusCircle" size={ICON_SIZE} /> diff --git a/x-pack/platform/plugins/shared/cases/public/components/create/submit_button.tsx b/x-pack/platform/plugins/shared/cases/public/components/create/submit_button.tsx index 0840cd6445437..e93946807b4ee 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/create/submit_button.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/create/submit_button.tsx @@ -23,7 +23,7 @@ const SubmitCaseButtonComponent: React.FC = ({ i tour-step="create-case-submit" data-test-subj="create-case-submit" fill - iconType="plusInCircle" + iconType="plusCircle" isDisabled={isSubmitting} isLoading={isSubmitting} onClick={submit} diff --git a/x-pack/platform/plugins/shared/cases/public/components/custom_fields/custom_fields_list/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/custom_fields/custom_fields_list/index.tsx index 90f6687141eda..43d79b9334e2f 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/custom_fields/custom_fields_list/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/custom_fields/custom_fields_list/index.tsx @@ -96,7 +96,7 @@ const CustomFieldsListComponent: React.FC = (props) => { setSelectedItem(customField)} /> diff --git a/x-pack/platform/plugins/shared/cases/public/components/custom_fields/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/custom_fields/index.tsx index 31bc4cd0dd523..e9c0b2b3550ed 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/custom_fields/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/custom_fields/index.tsx @@ -96,7 +96,7 @@ const CustomFieldsComponent: React.FC = ({ isDisabled={disabled || error} size="s" onClick={onAddCustomField} - iconType="plusInCircle" + iconType="plusCircle" data-test-subj="add-custom-field" > {i18n.ADD_CUSTOM_FIELD} diff --git a/x-pack/platform/plugins/shared/cases/public/components/edit_connector/push_button.tsx b/x-pack/platform/plugins/shared/cases/public/components/edit_connector/push_button.tsx index d004d69da85cf..38d4bafabf365 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/edit_connector/push_button.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/edit_connector/push_button.tsx @@ -32,7 +32,7 @@ const PushButtonComponent: React.FC = ({ const button = ( = ({ const props: EuiBetaBadgeProps = { label: compact ? null : EXPERIMENTAL_LABEL, size, - ...((icon || compact) && { iconType: 'beaker' }), + ...((icon || compact) && { iconType: 'flask' }), tooltipContent: EXPERIMENTAL_DESC, tooltipPosition: 'bottom' as const, 'data-test-subj': testSubj, diff --git a/x-pack/platform/plugins/shared/cases/public/components/filter_popover/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/filter_popover/index.tsx index 6eacc69b1ccde..3e32e0f63d9f8 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/filter_popover/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/filter_popover/index.tsx @@ -72,7 +72,7 @@ export const FilterPopoverComponent = ({ button={ + = ({ isDisabled={!canModifyObservableTypes} size="s" onClick={onAddObservableType} - iconType="plusInCircle" + iconType="plusCircle" data-test-subj="add-observable-type" > {i18n.ADD_OBSERVABLE_TYPE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/observable_types/observable_types_list/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/observable_types/observable_types_list/index.tsx index bdb898c718e8b..2b2f8bf45449a 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/observable_types/observable_types_list/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/observable_types/observable_types_list/index.tsx @@ -84,7 +84,7 @@ const ObservableTypesListComponent: React.FC = (props) setSelectedItem(observableType)} diff --git a/x-pack/platform/plugins/shared/cases/public/components/observables/add_observable.tsx b/x-pack/platform/plugins/shared/cases/public/components/observables/add_observable.tsx index acc6d5c1a422d..6462a55d20c3a 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/observables/add_observable.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/observables/add_observable.tsx @@ -56,7 +56,7 @@ const AddObservableComponent: React.FC = ({ caseData }) => { disabled={!isObservablesEnabled} title={isObservablesEnabled ? undefined : i18n.PLATINUM_NOTICE} data-test-subj="cases-observables-add" - iconType="plusInCircle" + iconType="plusCircle" onClick={showModal} > {i18n.ADD_OBSERVABLE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/observables/observable_actions_popover_button.tsx b/x-pack/platform/plugins/shared/cases/public/components/observables/observable_actions_popover_button.tsx index 93e0eab918e6f..00e9192411530 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/observables/observable_actions_popover_button.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/observables/observable_actions_popover_button.tsx @@ -98,7 +98,7 @@ export const ObservableActionsPopoverButton: React.FC<{ button={ ( diff --git a/x-pack/platform/plugins/shared/cases/public/components/recent_cases/recent_cases.tsx b/x-pack/platform/plugins/shared/cases/public/components/recent_cases/recent_cases.tsx index 1d17ea74777e8..928dcb7dfc0e2 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/recent_cases/recent_cases.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/recent_cases/recent_cases.tsx @@ -97,11 +97,7 @@ export const RecentCasesComp = React.memo( - + {i !== data.cases.length - 1 && } diff --git a/x-pack/platform/plugins/shared/cases/public/components/status/status_popover_button.tsx b/x-pack/platform/plugins/shared/cases/public/components/status/status_popover_button.tsx index e663bf9865685..6c5f1fa35d9fa 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/status/status_popover_button.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/status/status_popover_button.tsx @@ -21,7 +21,7 @@ interface Props { const StatusPopoverButtonComponent: React.FC = ({ status, disabled = false, onClick }) => { return ( )} diff --git a/x-pack/platform/plugins/shared/cases/public/components/templates/index.tsx b/x-pack/platform/plugins/shared/cases/public/components/templates/index.tsx index cbb75f915d3cb..144e6e4ab2a2f 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/templates/index.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/templates/index.tsx @@ -106,7 +106,7 @@ const TemplatesComponent: React.FC = ({ isDisabled={disabled || error} size="s" onClick={handleAddTemplate} - iconType="plusInCircle" + iconType="plusCircle" data-test-subj="add-template" > {i18n.ADD_TEMPLATE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/templates/templates_list.tsx b/x-pack/platform/plugins/shared/cases/public/components/templates/templates_list.tsx index 84009e34b5fdd..a19651c890287 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/templates/templates_list.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/templates/templates_list.tsx @@ -102,7 +102,7 @@ const TemplatesListComponent: React.FC = (props) => { setItemToBeDeleted(template)} /> diff --git a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_bulk_actions.tsx b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_bulk_actions.tsx index b73c394f91b7d..e667b202e24a2 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_bulk_actions.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_bulk_actions.tsx @@ -66,7 +66,7 @@ const TemplatesBulkActionsComponent: React.FC = ({ items: [ { name: i18n.BULK_EXPORT_TEMPLATES, - icon: 'exportAction', + icon: 'upload', onClick: handleBulkExport, disabled: isLoading, 'data-test-subj': 'templates-bulk-action-export', @@ -106,7 +106,7 @@ const TemplatesBulkActionsComponent: React.FC = ({ onClick={togglePopover} size="xs" iconSide="right" - iconType="arrowDown" + iconType="chevronSingleDown" flush="left" data-test-subj="templates-bulk-actions-link-icon" > diff --git a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_list_header.tsx b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_list_header.tsx index 925ac4e98ac17..9f4e3bd380d56 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_list_header.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_list_header.tsx @@ -52,7 +52,7 @@ export const TemplatesListHeader: React.FC = () => { { fill onClick={navigateToCasesCreateTemplate} href={getCasesCreateTemplateUrl()} - iconType="plusInCircle" + iconType="plusCircle" data-test-subj="create-template-button" > {i18n.CREATE_TEMPLATE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_table_empty_prompt.tsx b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_table_empty_prompt.tsx index fc5ba59ff7559..be2de7b649fea 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_table_empty_prompt.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/components/templates_table_empty_prompt.tsx @@ -56,7 +56,7 @@ const TemplatesTableEmptyPromptComponent: React.FC {i18n.CREATE_TEMPLATE} diff --git a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/hooks/use_templates_columns.tsx b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/hooks/use_templates_columns.tsx index 77d101dff2b08..fc30de2367f43 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/templates_v2/hooks/use_templates_columns.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/templates_v2/hooks/use_templates_columns.tsx @@ -120,7 +120,7 @@ const ActionColumnComponent: React.FC = ({ }, { name: i18n.EXPORT_TEMPLATE, - icon: 'exportAction', + icon: 'upload', onClick: handleExport, 'data-test-subj': `template-action-export-${template.templateId}`, }, @@ -145,7 +145,7 @@ const ActionColumnComponent: React.FC = ({ button={ { 'added an alert from Awesome rule' ); - await deleteAttachment('minusInCircle', 'Remove'); + await deleteAttachment('minusCircle', 'Remove'); await waitFor(() => { expect(builderArgs.handleDeleteComment).toHaveBeenCalledWith( @@ -495,7 +495,7 @@ describe('createCommentUserActionBuilder', () => { 'added 2 alerts from Awesome rule' ); - await deleteAttachment('minusInCircle', 'Remove'); + await deleteAttachment('minusCircle', 'Remove'); await waitFor(() => { expect(builderArgs.handleDeleteComment).toHaveBeenCalledWith( @@ -572,7 +572,7 @@ describe('createCommentUserActionBuilder', () => { 'added an event' ); - await deleteAttachment('minusInCircle', 'Remove'); + await deleteAttachment('minusCircle', 'Remove'); await waitFor(() => { expect(builderArgs.handleDeleteComment).toHaveBeenCalledWith( diff --git a/x-pack/platform/plugins/shared/cases/public/components/user_actions/move_to_reference.tsx b/x-pack/platform/plugins/shared/cases/public/components/user_actions/move_to_reference.tsx index 34647d7ce6b99..4cd06a84a3af4 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/user_actions/move_to_reference.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/user_actions/move_to_reference.tsx @@ -29,7 +29,7 @@ const UserActionMoveToReferenceComponent = ({ aria-label={i18n.MOVE_TO_ORIGINAL_COMMENT} data-test-subj={`move-to-link-${id}`} onClick={handleMoveToLink} - iconType="arrowUp" + iconType="chevronSingleUp" /> ); diff --git a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.test.tsx index bb492914573bb..3e24e5536c52a 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.test.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.test.tsx @@ -53,7 +53,7 @@ describe('AlertPropertyActions', () => { expect((await screen.findAllByTestId('property-actions-user-action-group')).length).toBe(1); expect( - await screen.findByTestId('property-actions-user-action-minusInCircle') + await screen.findByTestId('property-actions-user-action-minusCircle') ).toBeInTheDocument(); }); @@ -65,7 +65,7 @@ describe('AlertPropertyActions', () => { await user.click(await screen.findByTestId('property-actions-user-action-ellipses')); await waitForEuiPopoverOpen(); - await user.click(await screen.findByTestId('property-actions-user-action-minusInCircle')); + await user.click(await screen.findByTestId('property-actions-user-action-minusCircle')); expect(await screen.findByTestId('property-actions-confirm-modal')).toBeInTheDocument(); @@ -81,7 +81,7 @@ describe('AlertPropertyActions', () => { await user.click(await screen.findByTestId('property-actions-user-action-ellipses')); await waitForEuiPopoverOpen(); - await user.click(await screen.findByTestId('property-actions-user-action-minusInCircle')); + await user.click(await screen.findByTestId('property-actions-user-action-minusCircle')); expect(await screen.findByTestId('property-actions-confirm-modal')).toBeInTheDocument(); diff --git a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.tsx b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.tsx index 3abe81c2b0d5c..dcfcb5fe120c1 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/alert_property_actions.tsx @@ -37,7 +37,7 @@ const AlertPropertyActionsComponent: React.FC = ({ isLoading, totalAlerts type: AttachmentActionType.BUTTON as const, color: 'danger' as const, disabled: false, - iconType: 'minusInCircle', + iconType: 'minusCircle', label: i18n.REMOVE_ALERTS(totalAlerts), onClick: onModalOpen, }, diff --git a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.test.tsx index 8476bb568d333..9857caac17232 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.test.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.test.tsx @@ -53,7 +53,7 @@ describe('EventPropertyActions', () => { expect((await screen.findAllByTestId('property-actions-user-action-group')).length).toBe(1); expect( - await screen.findByTestId('property-actions-user-action-minusInCircle') + await screen.findByTestId('property-actions-user-action-minusCircle') ).toBeInTheDocument(); }); @@ -65,7 +65,7 @@ describe('EventPropertyActions', () => { await user.click(await screen.findByTestId('property-actions-user-action-ellipses')); await waitForEuiPopoverOpen(); - await user.click(await screen.findByTestId('property-actions-user-action-minusInCircle')); + await user.click(await screen.findByTestId('property-actions-user-action-minusCircle')); expect(await screen.findByTestId('property-actions-confirm-modal')).toBeInTheDocument(); @@ -81,7 +81,7 @@ describe('EventPropertyActions', () => { await user.click(await screen.findByTestId('property-actions-user-action-ellipses')); await waitForEuiPopoverOpen(); - await user.click(await screen.findByTestId('property-actions-user-action-minusInCircle')); + await user.click(await screen.findByTestId('property-actions-user-action-minusCircle')); expect(await screen.findByTestId('property-actions-confirm-modal')).toBeInTheDocument(); diff --git a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.tsx b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.tsx index 3d2f1e09fc30f..f73a95b0ebc4d 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/user_actions/property_actions/event_property_actions.tsx @@ -37,7 +37,7 @@ const EventPropertyActionsComponent: React.FC = ({ isLoading, totalEvents type: AttachmentActionType.BUTTON as const, color: 'danger' as const, disabled: false, - iconType: 'minusInCircle', + iconType: 'minusCircle', label: i18n.REMOVE_EVENTS(totalEvents), onClick: onModalOpen, }, diff --git a/x-pack/platform/plugins/shared/cases/public/components/user_profiles/no_matches.tsx b/x-pack/platform/plugins/shared/cases/public/components/user_profiles/no_matches.tsx index dabece99d533d..1dcd180d580fd 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/user_profiles/no_matches.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/user_profiles/no_matches.tsx @@ -30,7 +30,7 @@ const NoMatchesComponent: React.FC = () => { data-test-subj="case-user-profiles-assignees-popover-no-matches" > - + diff --git a/x-pack/platform/test/functional_with_es_ssl/apps/cases/group2/attachment_framework.ts b/x-pack/platform/test/functional_with_es_ssl/apps/cases/group2/attachment_framework.ts index 2316d62822309..df890ddbe4834 100644 --- a/x-pack/platform/test/functional_with_es_ssl/apps/cases/group2/attachment_framework.ts +++ b/x-pack/platform/test/functional_with_es_ssl/apps/cases/group2/attachment_framework.ts @@ -90,7 +90,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { const validateAttachment = async (type: string, attachmentId?: string | null) => { await testSubjects.existOrFail(`comment-${type}-.test`); await testSubjects.existOrFail(`copy-link-${attachmentId}`); - await testSubjects.existOrFail(`attachment-.test-${attachmentId}-arrowRight`); + await testSubjects.existOrFail(`attachment-.test-${attachmentId}-chevronSingleRight`); }; /** diff --git a/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/external_reference.tsx b/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/external_reference.tsx index 3ab6cd69103e0..0af2032e6fc0d 100644 --- a/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/external_reference.tsx +++ b/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/external_reference.tsx @@ -26,7 +26,7 @@ export const getExternalReferenceAttachmentRegular = (): ExternalReferenceAttach label: 'See attachment', onClick: () => {}, isPrimary: true, - iconType: 'arrowRight', + iconType: 'chevronSingleRight', }, ], children: AttachmentContentLazy, diff --git a/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/persistable_state.tsx b/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/persistable_state.tsx index 14cf76ec928fa..8552a600a5874 100644 --- a/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/persistable_state.tsx +++ b/x-pack/platform/test/functional_with_es_ssl/plugins/cases/public/attachments/persistable_state.tsx @@ -56,7 +56,7 @@ export const getPersistableStateAttachmentRegular = ( label: 'See attachment', onClick: () => {}, isPrimary: true, - iconType: 'arrowRight', + iconType: 'chevronSingleRight', }, ], children: getLazyComponent(EmbeddableComponent), diff --git a/x-pack/solutions/security/plugins/security_solution/public/cases/attachments/indicator/utils/attachments.tsx b/x-pack/solutions/security/plugins/security_solution/public/cases/attachments/indicator/utils/attachments.tsx index fe3dc0b7f35b5..2baa4e6859136 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/cases/attachments/indicator/utils/attachments.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/cases/attachments/indicator/utils/attachments.tsx @@ -52,10 +52,10 @@ export const generateIndicatorAttachmentType = (): ExternalReferenceAttachmentTy defaultMessage="added an indicator of compromise" /> ), - timelineAvatar: , + timelineAvatar: , children: IndicatorAttachmentChildrenLazy, }), - icon: 'crosshairs', + icon: 'crosshair', }); /** From 0c67adb3faf73d6c327e4f6ecc0d3e99c01a9b00 Mon Sep 17 00:00:00 2001 From: Tomasz Kajtoch Date: Tue, 24 Mar 2026 22:56:40 +0100 Subject: [PATCH 2/2] Update comments mentioning renamed icons Co-authored-by: Tomasz Kajtoch --- .../shared/cases/public/components/app/use_readonly_header.ts | 2 +- .../cases/public/components/case_action_bar/actions.test.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts b/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts index 35eba6a45313d..0ba8b818e5ac9 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts +++ b/x-pack/platform/plugins/shared/cases/public/components/app/use_readonly_header.ts @@ -19,7 +19,7 @@ export function useReadonlyHeader() { const { permissions } = useCasesContext(); const chrome = useKibana().services.chrome; - // if the user is read only then display the glasses badge in the global navigation header + // if the user is read only then display the readOnly badge in the global navigation header const setBadge = useCallback(() => { if (isReadOnlyPermissions(permissions)) { chrome.setBadge({ diff --git a/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.test.tsx b/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.test.tsx index 3a27c070da524..86975a7a99d1b 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.test.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/case_action_bar/actions.test.tsx @@ -54,7 +54,7 @@ describe('CaseView actions', () => { expect(wrapper.find('[data-test-subj="confirm-delete-case-modal"]').exists()).toBeTruthy(); }); - it('clicking copyClipboard icon copies case id', () => { + it('clicking copy icon copies case id', () => { const originalClipboard = global.window.navigator.clipboard; Object.defineProperty(navigator, 'clipboard', {