[Response Ops][Alerting] Add additional features to alerting rules #252703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

denar50 merged 41 commits into elastic:main from denar50:expose-permission-on-rules-to-modify-gap-autofill-scheduler

Mar 6, 2026

x-pack/examples/alerting_example/server/plugin.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -26,6 +26,21 @@ export interface AlertingExampleDeps { @@
       features: FeaturesPluginSetup;
     }
+    const alertingFeatures = [
+      {
+        ruleTypeId: alwaysFiringRule.id,
+        consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
+      },
+      {
+        ruleTypeId: peopleInSpaceRule.id,
+        consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
+      },
+      {
+        ruleTypeId: INDEX_THRESHOLD_ID,
+        consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
+      },
+    ];
     export class AlertingExamplePlugin implements Plugin<void, void, AlertingExampleDeps> {
       public setup(core: CoreSetup, { alerting, features }: AlertingExampleDeps) {
         alerting.registerType(alwaysFiringRule);
@@ Expand All @@
             insightsAndAlerting: ['triggersActions'],
           },
           category: DEFAULT_APP_CATEGORIES.management,
-          alerting: [
-            {
-              ruleTypeId: alwaysFiringRule.id,
-              consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-            },
-            {
-              ruleTypeId: peopleInSpaceRule.id,
-              consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-            },
-            {
-              ruleTypeId: INDEX_THRESHOLD_ID,
-              consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-            },
-          ],
+          alerting: alertingFeatures,
           privileges: {
             all: {
               alerting: {
                 rule: {
-                  all: [
-                    {
-                      ruleTypeId: alwaysFiringRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: peopleInSpaceRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: INDEX_THRESHOLD_ID,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                  ],
+                  all: alertingFeatures,
+                  enable: alertingFeatures,
+                  manual_run: alertingFeatures,
+                  manage_rule_settings: alertingFeatures,
                 },
                 alert: {
-                  all: [
-                    {
-                      ruleTypeId: alwaysFiringRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: peopleInSpaceRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: INDEX_THRESHOLD_ID,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                  ],
+                  all: alertingFeatures,
                 },
               },
               savedObject: {
@@ Expand All @@
             read: {
               alerting: {
                 rule: {
-                  read: [
-                    {
-                      ruleTypeId: alwaysFiringRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: peopleInSpaceRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: INDEX_THRESHOLD_ID,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                  ],
+                  read: alertingFeatures,
                 },
                 alert: {
-                  read: [
-                    {
-                      ruleTypeId: alwaysFiringRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: peopleInSpaceRule.id,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                    {
-                      ruleTypeId: INDEX_THRESHOLD_ID,
-                      consumers: [ALERTING_EXAMPLE_APP_ID, ALERTING_FEATURE_ID],
-                    },
-                  ],
+                  read: alertingFeatures,
                 },
               },
               savedObject: {
@@ Expand Down @@

...ate/security/authorization_core/src/privileges/feature_privilege_builder/alerting.test.ts

Large diffs are not rendered by default.

.../private/security/authorization_core/src/privileges/feature_privilege_builder/alerting.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -47,6 +47,20 @@ const enableOperations: Record<AlertingEntity, string[]> = { @@
       alert: [],
     };
+    const manageRuleSettingsOperations: Record<AlertingEntity, string[]> = {
+      rule: [
+        'getGapAutoFillScheduler',
+        'findGapAutoFillSchedulerLogs',
+        'createGapAutoFillScheduler',
+        'updateGapAutoFillScheduler',
+        'deleteGapAutoFillScheduler',
+        'find',
+        'findBackfill',
+        'scheduleBackfill',
+      ],
+      alert: [],
+    };
     const writeOperations: Record<AlertingEntity, string[]> = {
       rule: [
         'create',
@@ Expand All / @@ -62,19 +76,11 @@ const writeOperations: Record<AlertingEntity, string[]> = { @@
         'bulkDelete',
         'unsnooze',
         'runSoon',
-        'createGapAutoFillScheduler',
-        'updateGapAutoFillScheduler',
-        'deleteGapAutoFillScheduler',
       ],
       alert: ['update'],
     };
     const allOperations: Record<AlertingEntity, string[]> = {
-      rule: [
-        ...readOperations.rule,
-        ...writeOperations.rule,
-        ...enableOperations.rule,
-        ...manualRunOperations.rule,
-      ],
+      rule: [...readOperations.rule, ...writeOperations.rule],
       alert: [...readOperations.alert, ...writeOperations.alert],
     };
@@ Expand All @@
           const all = get(privilegeDefinition.alerting, `${entity}.all`) ?? [];
           const enable = get(privilegeDefinition.alerting, `${entity}.enable`) ?? [];
           const manualRun = get(privilegeDefinition.alerting, `${entity}.manual_run`) ?? [];
+          const manageRuleSettings =
+            get(privilegeDefinition.alerting, `${entity}.manage_rule_settings`) ?? [];
           const read = get(privilegeDefinition.alerting, `${entity}.read`) ?? [];
           return uniq([
             ...getAlertingPrivilege(allOperations[entity], all, entity),
             ...getAlertingPrivilege(readOperations[entity], read, entity),
             ...getAlertingPrivilege(enableOperations[entity], enable, entity),
             ...getAlertingPrivilege(manualRunOperations[entity], manualRun, entity),
+            ...getAlertingPrivilege(manageRuleSettingsOperations[entity], manageRuleSettings, entity),
           ]);
         };
@@ Expand Down @@

...k/platform/packages/private/security/authorization_core/src/privileges/privileges.test.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -593,12 +593,7 @@ describe('features', () => { @@
             'bulkDelete',
             'unsnooze',
             'runSoon',
-            'createGapAutoFillScheduler',
-            'updateGapAutoFillScheduler',
-            'deleteGapAutoFillScheduler',
           ],
-          ...['enable', 'disable', 'bulkEnable', 'bulkDisable'],
-          ...['deleteBackfill', 'fillGaps', 'scheduleBackfill'],
         ];
         const expectedAllPrivileges = [
@@ Expand Down Expand Up / @@ -771,12 +766,7 @@ describe('features', () => { @@
             'bulkDelete',
             'unsnooze',
             'runSoon',
-            'createGapAutoFillScheduler',
-            'updateGapAutoFillScheduler',
-            'deleteGapAutoFillScheduler',
           ],
-          ...['enable', 'disable', 'bulkEnable', 'bulkDisable'],
-          ...['deleteBackfill', 'fillGaps', 'scheduleBackfill'],
         ];
         const expectedAllPrivileges = [
@@ Expand Down @@

x-pack/platform/plugins/private/monitoring/server/plugin.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -302,6 +302,9 @@ export class MonitoringPlugin @@
                   alerting: {
                     rule: {
                       all: alertingFeatures,
+                      enable: alertingFeatures,
+                      manual_run: alertingFeatures,
+                      manage_rule_settings: alertingFeatures,
                     },
                     alert: {
                       all: alertingFeatures,
@@ Expand Down @@

x-pack/platform/plugins/shared/data_quality/server/features.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -33,6 +33,9 @@ const canManageRules: SubFeaturePrivilegeGroupConfig = { @@
           alerting: {
             rule: {
               all: [degradedDocsAlertingFeatures],
+              enable: [degradedDocsAlertingFeatures],
+              manual_run: [degradedDocsAlertingFeatures],
+              manage_rule_settings: [degradedDocsAlertingFeatures],
             },
           },
           savedObject: {
@@ Expand Down @@

x-pack/platform/plugins/shared/features/common/feature_kibana_privileges.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -139,6 +139,16 @@ export interface FeatureKibanaPrivileges { @@
            * ```
            */
           manual_run?: AlertingKibanaPrivilege;
+          /**
+           * List of rule types and consumers for which users should have the ability to manage rule settings (e.g. gap auto-fill scheduler) when granted this privilege.
+           * @example
+           * ```ts
+           *  {
+           *    manage_rule_settings: [{ ruleTypeId: 'my-alert-type-within-my-feature', consumers: ['my-consumer-within-my-feature'] }]
+           *  }
+           * ```
+           */
+          manage_rule_settings?: AlertingKibanaPrivilege;
         };
         alert?: {
           /**
@@ Expand Down @@

x-pack/platform/plugins/shared/features/server/__snapshots__/oss_features.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Response Ops][Alerting] Add additional features to alerting rules #252703

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!