Skip to content

[9.1] Fix AI Connector form fields resetting to default value when cleared by user (#251095) #251290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saikatsarkar056 merged 2 commits into from
Feb 3, 2026
Merged

[9.1] Fix AI Connector form fields resetting to default value when cleared by user (#251095) #251290

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c8ad8
Fix AI Connector form fields resetting to default value when cleared …
saikatsarkar056 Jan 30, 2026
28ef1a7
Fix the test for clean button
saikatsarkar056 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix the test for clean button
  • Loading branch information
@saikatsarkar056
saikatsarkar056 committed Feb 2, 2026
commit 28ef1a75c917d9f29178133406691ff2d0dca29d
55 changes: 0 additions & 55 deletions ...bn-inference-endpoint-ui-common/src/components/configuration/configuration_field.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,61 +203,6 @@ describe('ConfigNumberField', () => {
expect(input).toHaveValue(2048);
});

it('allows user to clear the field using the clear button', () => {
const validateAndSetConfigValue = jest.fn();
const configEntry = createConfigEntry({
value: null,
default_value: 1024,
});

render(
<ConfigNumberField
{...defaultProps}
configEntry={configEntry}
validateAndSetConfigValue={validateAndSetConfigValue}
/>
);

// Find and click the clear button
const clearButton = screen.getByRole('button', { name: /clear/i });
fireEvent.click(clearButton);

expect(validateAndSetConfigValue).toHaveBeenCalledWith('');
});

it('does not reset to default after rerender when field is cleared', () => {
const validateAndSetConfigValue = jest.fn();
const configEntry = createConfigEntry({
value: null,
default_value: 1024,
});

const { rerender } = render(
<ConfigNumberField
{...defaultProps}
configEntry={configEntry}
validateAndSetConfigValue={validateAndSetConfigValue}
/>
);

// Find and click the clear button
const clearButton = screen.getByRole('button', { name: /clear/i });
fireEvent.click(clearButton);

// Simulate parent form updating value prop to null (as it converts '' to null)
rerender(
<ConfigNumberField
{...defaultProps}
configEntry={{ ...configEntry, value: null }}
validateAndSetConfigValue={validateAndSetConfigValue}
/>
);

// Should still be empty, not reset to default
const input = screen.getByTestId('max_tokens-number');
expect(input).toHaveValue(null);
});

it('allows user to change the value', () => {
const validateAndSetConfigValue = jest.fn();
const configEntry = createConfigEntry({
Expand Down