From fa4ad11fea9f0d2c59586c8c3ad98e2f1bf4977e Mon Sep 17 00:00:00 2001 From: Brad White Date: Fri, 23 Jan 2026 17:40:54 -0700 Subject: [PATCH] Revert "[Security Solution] Skipped tests: flaky Suricata tests (#231473)" This reverts commit b66c54a94c38839b4b38c989e21d4ba75998d675. --- .../timelines/row_renderers.cy.ts | 22 ++++++ .../timelines/row_renderers_suricata.cy.ts | 67 ------------------- .../cypress/screens/timeline.ts | 2 +- 3 files changed, 23 insertions(+), 68 deletions(-) delete mode 100644 x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers_suricata.cy.ts diff --git a/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers.cy.ts b/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers.cy.ts index 877efea6f820a..c6c062996e6fd 100644 --- a/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers.cy.ts +++ b/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers.cy.ts @@ -5,11 +5,15 @@ * 2.0. */ +import { elementsOverlap } from '../../../helpers/rules'; import { TIMELINE_ROW_RENDERERS_DISABLE_ALL_BTN, TIMELINE_ROW_RENDERERS_MODAL_ITEMS_CHECKBOX, TIMELINE_ROW_RENDERERS_SEARCHBOX, TIMELINE_SHOW_ROW_RENDERERS_GEAR, + TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE, + TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP, + TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP, TIMELINE_ROW_RENDERERS_MODAL_CLOSE_BUTTON, TIMELINE_ROW_RENDERERS_WRAPPER, } from '../../../screens/timeline'; @@ -126,4 +130,22 @@ describe('Row renderers', { tags: ['@ess', '@serverless'] }, () => { cy.wait('@updateTimeline').its('response.statusCode').should('eq', 200); }); + + describe('Suricata', () => { + // This test has become very flaky over time and was blocking a lot of PRs. + // A follw-up ticket to tackle this issue has been created. + it.skip('Signature tooltips do not overlap', () => { + // Hover the signature to show the tooltips + cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE).parents('.euiPopover').realHover(); + + cy.get(TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP).then(($googleLinkTooltip) => { + cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP).then(($signatureTooltip) => { + expect( + elementsOverlap($googleLinkTooltip, $signatureTooltip), + 'tooltips do not overlap' + ).to.equal(false); + }); + }); + }); + }); }); diff --git a/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers_suricata.cy.ts b/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers_suricata.cy.ts deleted file mode 100644 index 974555ca4f938..0000000000000 --- a/x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers_suricata.cy.ts +++ /dev/null @@ -1,67 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License - * 2.0; you may not use this file except in compliance with the Elastic License - * 2.0. - */ - -import { elementsOverlap } from '../../../helpers/rules'; -import { - TIMELINE_ROW_RENDERERS_SEARCHBOX, - TIMELINE_SHOW_ROW_RENDERERS_GEAR, - TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE, - TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP, - TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP, -} from '../../../screens/timeline'; -import { deleteTimelines } from '../../../tasks/api_calls/timelines'; -import { waitForWelcomePanelToBeLoaded } from '../../../tasks/common'; -import { waitForAllHostsToBeLoaded } from '../../../tasks/hosts/all_hosts'; - -import { login } from '../../../tasks/login'; -import { visitWithTimeRange } from '../../../tasks/navigation'; -import { openTimelineUsingToggle } from '../../../tasks/security_main'; -import { populateTimeline } from '../../../tasks/timeline'; - -import { hostsUrl } from '../../../urls/navigation'; - -describe('Row renderers - Suricata', { tags: ['@ess', '@serverless'] }, () => { - before(() => { - cy.task('esArchiverLoad', { archiveName: 'bulk_process' }); - }); - - after(() => { - cy.task('esArchiverUnload', { archiveName: 'bulk_process' }); - }); - beforeEach(() => { - deleteTimelines(); - login(); - visitWithTimeRange(hostsUrl('allHosts'), { - visitOptions: { - onLoad: () => { - waitForWelcomePanelToBeLoaded(); - waitForAllHostsToBeLoaded(); - }, - }, - }); - openTimelineUsingToggle(); - populateTimeline(); - }); - - it('Signature tooltips do not overlap', () => { - // Hover the signature to show the tooltips - cy.get(TIMELINE_SHOW_ROW_RENDERERS_GEAR).realClick(); - cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).should('exist'); - cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).type('suricata'); - - cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE, { timeout: 3000 }).realHover(); - - cy.get(TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP).then(($googleLinkTooltip) => { - cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP).then(($signatureTooltip) => { - expect( - elementsOverlap($googleLinkTooltip, $signatureTooltip), - 'tooltips do not overlap' - ).to.equal(false); - }); - }); - }); -}); diff --git a/x-pack/solutions/security/test/security_solution_cypress/cypress/screens/timeline.ts b/x-pack/solutions/security/test/security_solution_cypress/cypress/screens/timeline.ts index fdf31a846600c..ab2aad0262c86 100644 --- a/x-pack/solutions/security/test/security_solution_cypress/cypress/screens/timeline.ts +++ b/x-pack/solutions/security/test/security_solution_cypress/cypress/screens/timeline.ts @@ -198,7 +198,7 @@ export const TIMELINE_ROW_RENDERERS_SEARCHBOX = `${TIMELINE_ROW_RENDERERS_MODAL} export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE = `${TIMELINE_ROW_RENDERERS_MODAL} [data-test-subj="render-content-suricata.eve.alert.signature"]`; -export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLink"]`; +export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLinkTooltip"]`; export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP = `[data-test-subj="suricata.eve.alert.signature-tooltip"]`;