[Observability] Fix KQL autocomplete in custom threshold rule creation#249894
Closed
cesco-f wants to merge 5 commits into
Closed
[Observability] Fix KQL autocomplete in custom threshold rule creation#249894cesco-f wants to merge 5 commits into
cesco-f wants to merge 5 commits into
Conversation
cesco-f
added
release_note:fix
backport:skip
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
github-actions
Bot
added
the
author:actionable-obs
miguelmartin-elastic
approved these changes
Jan 21, 2026
Contributor
miguelmartin-elastic
left a comment
miguelmartin-elastic
left a comment
There was a problem hiding this comment.
lgtm, also tested it locally 🚀
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10556[❌] x-pack/solutions/observability/plugins/observability/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
|
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10566[❌] x-pack/solutions/observability/plugins/observability/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Contributor
Author
|
Closing in favor of #250044 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It closes #249869
Related to: #246674
Summary
Fixes KQL autocomplete in custom threshold rule creation by properly including the
kqlplugin in the service dependency chain.Problem
When typing in the KQL filter field within the custom threshold rule form, users would see the error:
TypeError: Cannot read properties of undefined (reading 'autocomplete')This occurred because the
kqlservice was not properly injected into the Kibana context when rendering rule forms.Root Cause
The issue had two parts:
Observability plugin:
kqlwas declared inrequiredBundlesinstead ofrequiredPluginsinkibana.jsonc. TherequiredBundlesonly bundles code together for tree-shaking but does NOT inject plugin services at runtime.Triggers-actions-ui plugin: Missing
kqlin the plugin dependencies and not passing it through the service chain to the rule form components.E2E test:
Before:
Screen.Recording.2026-01-21.at.15.59.54.mov
After:
Screen.Recording.2026-01-21.at.16.01.26.mov