From 33f62ae458faef0d92d5b1997cdcf1713ec972ef Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Tue, 20 Jan 2026 12:40:03 +0200 Subject: [PATCH 1/2] Address `@elastic/eui/require-table-caption` lint violations across `@elastic/security-threat-hunting` files --- .../dashboards/components/dashboard_table/index.tsx | 2 ++ .../dashboards/components/dashboard_table/translations.ts | 7 +++++++ .../migration_status_panels/migration_result_panel.tsx | 2 ++ .../migration_status_panels/migration_result_panel.tsx | 2 ++ .../siem_migrations/rules/components/rules_table/index.tsx | 2 ++ .../rules/components/rules_table/translations.ts | 7 +++++++ 6 files changed, 22 insertions(+) diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx index 3823ce20b7dfa..662e34a60a950 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx @@ -47,6 +47,7 @@ import { useGetMigrationTranslationStats } from '../../logic/use_get_migration_t import { useMigrationDashboardDetailsFlyout } from '../../hooks/use_migration_dashboard_details_flyout'; import { useStartDashboardsMigrationModal } from '../../hooks/use_start_dashboard_migration_modal'; import { useStartMigration } from '../../logic/use_start_migration'; +import { DASHBOARD_MIGRATION_TABLE_CAPTION, MIGRATION_DASHBOARD_TABLE_TABLE } from './translations'; const DEFAULT_PAGE_SIZE = 10; const DEFAULT_SORT_FIELD = 'translation_result'; @@ -321,6 +322,7 @@ export const MigrationDashboardsTable: React.FC = + tableCaption={i18n.DASHBOARDS_MIGRATION_TABLE_CAPTION} loading={false} items={migrationDashboards} pagination={pagination} diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/translations.ts b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/translations.ts index 7a66fe9d610e1..1cbc3a62ebd34 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/translations.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/translations.ts @@ -20,3 +20,10 @@ export const NOT_TRANSLATED_DASHBOARD_TOOLTIP = i18n.translate( defaultMessage: 'Not translated migration dashboard', } ); + +export const DASHBOARDS_MIGRATION_TABLE_CAPTION = i18n.translate( + 'xpack.securitySolution.siemMigrations.dashboards.table.caption', + { + defaultMessage: 'Dashboards migration status', + } +); diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx index 443217142383e..486536a181896 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx @@ -41,6 +41,7 @@ import { MigrationsLastError } from '../../../common/components/migration_panels import { MigrationPanelTitle } from '../../../common/components/migration_panels/migration_title'; import { useCompleteBadgeStyles } from '../../../common/hooks/use_complete_status_badge_styles'; import { TotalExecutionTime } from '../../../common/components/total_execution_time'; +import { DASHBOARD_MIGRATION_SUMMARY_TITLE } from './translations'; const headerStyle = css` &:hover { @@ -306,6 +307,7 @@ const TranslationResultsTable = React.memo<{ items={items} columns={columns} compressed + tableCaption={i18n.DASHBOARD_MIGRATION_SUMMARY_TITLE} /> ); }); diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx index a8e5502655112..a6f3f7d85340d 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx @@ -42,6 +42,7 @@ import { RuleMigrationsUploadMissingPanel } from './upload_missing_panel'; import { MigrationsLastError } from '../../../common/components/migration_panels/last_error'; import { MigrationPanelTitle } from '../../../common/components/migration_panels/migration_title'; import { TotalExecutionTime } from '../../../common/components/total_execution_time'; +import { RULE_MIGRATION_SUMMARY_TITLE } from './translations'; const headerStyle = css` &:hover { @@ -309,6 +310,7 @@ const TranslationResultsTable = React.memo<{ data-test-subj="translatedResultsTable" items={items} columns={columns} + tableCaption={i18n.RULE_MIGRATION_SUMMARY_TITLE} compressed /> ); diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx index f8809436693a8..85156141b533d 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx @@ -54,6 +54,7 @@ import { } from '../../../../common/components/utility_bar'; import { useStartRulesMigrationModal } from '../../hooks/use_start_rules_migration_modal'; import { useStartMigration } from '../../logic/use_start_migration'; +import { RULES_MIGRAION_TABLE_CAPTION, RULES_MIGRATION_TABLE_CAPTION } from './translations'; const DEFAULT_PAGE_SIZE = 10; const DEFAULT_SORT_FIELD = 'translation_result'; @@ -452,6 +453,7 @@ export const MigrationRulesTable: React.FC = React.mem itemId={'id'} data-test-subj={'rules-translation-table'} columns={rulesColumns} + tableCaption={i18n.RULES_MIGRATION_TABLE_CAPTION} /> ) diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/translations.ts b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/translations.ts index 6f1aff56cb5cf..28e4d487b9638 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/translations.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/translations.ts @@ -7,6 +7,13 @@ import { i18n } from '@kbn/i18n'; +export const RULES_MIGRATION_TABLE_CAPTION = i18n.translate( + 'xpack.securitySolution.siemMigrations.rules.table.caption', + { + defaultMessage: 'Rules migration status', + } +); + export const ALREADY_TRANSLATED_RULE_TOOLTIP = i18n.translate( 'xpack.securitySolution.siemMigrations.rules.table.alreadyTranslatedTooltip', { From 2e107ead3f67bdca6119f735ca5bc5d7f8cb6e57 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Tue, 20 Jan 2026 11:07:26 +0000 Subject: [PATCH 2/2] Changes from node scripts/eslint_all_files --no-cache --fix --- .../dashboards/components/dashboard_table/index.tsx | 1 - .../migration_status_panels/migration_result_panel.tsx | 1 - .../migration_status_panels/migration_result_panel.tsx | 1 - .../siem_migrations/rules/components/rules_table/index.tsx | 1 - 4 files changed, 4 deletions(-) diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx index 662e34a60a950..9db8de588806a 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/dashboard_table/index.tsx @@ -47,7 +47,6 @@ import { useGetMigrationTranslationStats } from '../../logic/use_get_migration_t import { useMigrationDashboardDetailsFlyout } from '../../hooks/use_migration_dashboard_details_flyout'; import { useStartDashboardsMigrationModal } from '../../hooks/use_start_dashboard_migration_modal'; import { useStartMigration } from '../../logic/use_start_migration'; -import { DASHBOARD_MIGRATION_TABLE_CAPTION, MIGRATION_DASHBOARD_TABLE_TABLE } from './translations'; const DEFAULT_PAGE_SIZE = 10; const DEFAULT_SORT_FIELD = 'translation_result'; diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx index 486536a181896..d3e16b636df85 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/dashboards/components/migration_status_panels/migration_result_panel.tsx @@ -41,7 +41,6 @@ import { MigrationsLastError } from '../../../common/components/migration_panels import { MigrationPanelTitle } from '../../../common/components/migration_panels/migration_title'; import { useCompleteBadgeStyles } from '../../../common/hooks/use_complete_status_badge_styles'; import { TotalExecutionTime } from '../../../common/components/total_execution_time'; -import { DASHBOARD_MIGRATION_SUMMARY_TITLE } from './translations'; const headerStyle = css` &:hover { diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx index a6f3f7d85340d..76c82bc749906 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/migration_status_panels/migration_result_panel.tsx @@ -42,7 +42,6 @@ import { RuleMigrationsUploadMissingPanel } from './upload_missing_panel'; import { MigrationsLastError } from '../../../common/components/migration_panels/last_error'; import { MigrationPanelTitle } from '../../../common/components/migration_panels/migration_title'; import { TotalExecutionTime } from '../../../common/components/total_execution_time'; -import { RULE_MIGRATION_SUMMARY_TITLE } from './translations'; const headerStyle = css` &:hover { diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx index 85156141b533d..4ffb4b91c8921 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/rules_table/index.tsx @@ -54,7 +54,6 @@ import { } from '../../../../common/components/utility_bar'; import { useStartRulesMigrationModal } from '../../hooks/use_start_rules_migration_modal'; import { useStartMigration } from '../../logic/use_start_migration'; -import { RULES_MIGRAION_TABLE_CAPTION, RULES_MIGRATION_TABLE_CAPTION } from './translations'; const DEFAULT_PAGE_SIZE = 10; const DEFAULT_SORT_FIELD = 'translation_result';