From 4b17c442d49130142ef99686f27428c7f45586c9 Mon Sep 17 00:00:00 2001
From: James Gowdy <jgowdy@elastic.co>
Date: Thu, 25 Oct 2018 13:00:04 +0200
Subject: [PATCH 1/4] [Ml] Fixing results for known fields

---
 .../ml/common/constants/field_types.js        |   5 +-
 .../field_data_card/styles/main.less          |   2 +-
 .../field_type_icon/field_type_icon.js        |   4 +
 .../components/_index.scss                    |   1 +
 .../components/about_panel/about_panel.js     |   2 +-
 .../components/about_panel/welcome_content.js |   7 +-
 .../_experimental_badge.scss                  |   7 ++
 .../components/experimental_badge/_index.scss |   1 +
 .../experimental_badge/experimental_badge.js  |  19 ++++
 .../components/experimental_badge/index.js    |   8 ++
 .../fields_stats/field_stats_card.js          | 101 ++++++++++--------
 .../components/fields_stats/fields_stats.js   |  31 +++---
 .../fields_stats/get_field_names.js           |  37 +++++++
 .../components/import_view/import_view.js     |   6 +-
 14 files changed, 165 insertions(+), 66 deletions(-)
 create mode 100644 x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_experimental_badge.scss
 create mode 100644 x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_index.scss
 create mode 100644 x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/experimental_badge.js
 create mode 100644 x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/index.js
 create mode 100644 x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js

diff --git a/x-pack/plugins/ml/common/constants/field_types.js b/x-pack/plugins/ml/common/constants/field_types.js
index 3dd265c5c76ec..a3a474ab05415 100644
--- a/x-pack/plugins/ml/common/constants/field_types.js
+++ b/x-pack/plugins/ml/common/constants/field_types.js
@@ -27,7 +27,7 @@ export const ES_FIELD_TYPES = {
   TOKEN_COUNT: 'token_count',
   _ID: '_id',
   _SOURCE: '_source',
-  _TYPE: '_type'
+  _TYPE: '_type',
 };
 
 export const KBN_FIELD_TYPES = {
@@ -52,6 +52,7 @@ export const ML_JOB_FIELD_TYPES = {
   IP: 'ip',
   KEYWORD: 'keyword',
   NUMBER: 'number',
-  TEXT: 'text'
+  TEXT: 'text',
+  UNKNOWN_TYPE: 'unknown-type',
 };
 
diff --git a/x-pack/plugins/ml/public/components/field_data_card/styles/main.less b/x-pack/plugins/ml/public/components/field_data_card/styles/main.less
index 740e82b3d976e..f918f7066a313 100644
--- a/x-pack/plugins/ml/public/components/field_data_card/styles/main.less
+++ b/x-pack/plugins/ml/public/components/field_data_card/styles/main.less
@@ -34,7 +34,7 @@
     background-color: #920000;
   }
 
-  .type-other {
+  .type-other, .unknown-type {
     background-color: #bfa180;
   }
 
diff --git a/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js b/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js
index cf23fa1468f7d..8603b5aca4b2a 100644
--- a/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js
+++ b/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js
@@ -47,6 +47,10 @@ export function FieldTypeIcon({ tooltipEnabled = false, type }) {
       ariaLabel = 'IP type';
       iconClass = 'fa-laptop';
       break;
+    case ML_JOB_FIELD_TYPES.UNKNOWN_TYPE:
+      ariaLabel = 'Unknown type';
+      iconChar = '?';
+      break;
     default:
       // if type doesn't match one of ML_JOB_FIELD_TYPES
       // don't render the component at all
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/_index.scss b/x-pack/plugins/ml/public/file_datavisualizer/components/_index.scss
index c1a39da59fdb3..42974d098bda4 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/_index.scss
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/_index.scss
@@ -4,3 +4,4 @@
 @import 'fields_stats/index';
 @import 'about_panel/index';
 @import 'import_summary/index';
+@import 'experimental_badge/index';
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/about_panel.js b/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/about_panel.js
index 18df2ea7a54ae..261584bb1534b 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/about_panel.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/about_panel.js
@@ -52,7 +52,7 @@ export function AboutPanel({ onFilePickerChange }) {
 
 export function LoadingPanel() {
   return (
-    <EuiPage restrictWidth={200}>
+    <EuiPage restrictWidth={400}>
       <EuiPageBody>
         <EuiFlexGroup gutterSize="xl">
           <EuiFlexItem grow={false}>
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/welcome_content.js b/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/welcome_content.js
index 323db3b35fbcc..78f89f951f28f 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/welcome_content.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/welcome_content.js
@@ -8,7 +8,6 @@
 import React from 'react';
 
 import {
-  EuiBetaBadge,
   EuiFlexGroup,
   EuiFlexItem,
   EuiIcon,
@@ -18,6 +17,8 @@ import {
   EuiTitle,
 } from '@elastic/eui';
 
+import { ExperimentalBadge } from '../experimental_badge';
+
 export function WelcomeContent() {
 
   return (
@@ -29,7 +30,9 @@ export function WelcomeContent() {
         <EuiTitle size="m">
           <h3>
             Visualize data from a log file &nbsp;
-            <EuiBetaBadge label="Experimental" tooltipContent="Experimental feature. We'd love to hear your feedback." />
+            <ExperimentalBadge
+              tooltipContent="Experimental feature. We'd love to hear your feedback."
+            />
           </h3>
         </EuiTitle>
         <EuiSpacer size="s" />
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_experimental_badge.scss b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_experimental_badge.scss
new file mode 100644
index 0000000000000..4c90d6beed51a
--- /dev/null
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_experimental_badge.scss
@@ -0,0 +1,7 @@
+.ml-experimental-badge.euiBetaBadge {
+  font-size: 10px;
+  vertical-align: middle;
+  margin-bottom: 5px;
+  padding: 0px 20px;
+  line-height: 20px;
+}
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_index.scss b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_index.scss
new file mode 100644
index 0000000000000..9e25affd5e5f6
--- /dev/null
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/_index.scss
@@ -0,0 +1 @@
+@import 'experimental_badge'
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/experimental_badge.js b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/experimental_badge.js
new file mode 100644
index 0000000000000..1d45ccd8881fc
--- /dev/null
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/experimental_badge.js
@@ -0,0 +1,19 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import React from 'react';
+
+import {
+  EuiBetaBadge,
+} from '@elastic/eui';
+
+export function ExperimentalBadge({ tooltipContent }) {
+  return (
+    <span>
+      <EuiBetaBadge className="ml-experimental-badge" label="Experimental" tooltipContent={tooltipContent} />
+    </span>
+  );
+}
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/index.js b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/index.js
new file mode 100644
index 0000000000000..df986c3a2e61c
--- /dev/null
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/experimental_badge/index.js
@@ -0,0 +1,8 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+
+export { ExperimentalBadge } from './experimental_badge';
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/field_stats_card.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/field_stats_card.js
index 9c7300363dc47..3986685d09c3e 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/field_stats_card.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/field_stats_card.js
@@ -9,7 +9,6 @@ import React from 'react';
 
 import {
   EuiSpacer,
-
 } from '@elastic/eui';
 
 import { FieldTypeIcon } from '../../../components/field_type_icon';
@@ -35,59 +34,69 @@ export function FieldStatsCard({ field }) {
           </div>
 
           <div className="card-contents">
-            <div className="stats">
-              <div className="stat">
-                <i className="fa fa-files-o" aria-hidden="true" /> {field.count} document{(field.count > 1) ? 's' : ''} ({percent}%)
-              </div>
-              <div className="stat">
-                <i className="fa fa-cubes" aria-hidden="true" /> {field.cardinality} distinct value{(field.cardinality > 1) ? 's' : ''}
-              </div>
-
-              {
-                (field.mean_value) &&
-                <React.Fragment>
-                  <div>
-                    <div className="stat min heading">min</div>
-                    <div className="stat median heading">median</div>
-                    <div className="stat max heading">max</div>
+            {(field.count > 0) &&
+              <React.Fragment>
+                <div className="stats">
+                  <div className="stat">
+                    <i className="fa fa-files-o" aria-hidden="true" /> {field.count} document{(field.count > 1) ? 's' : ''} ({percent}%)
                   </div>
-                  <div>
-                    <div className="stat min heading">{field.min_value}</div>
-                    <div className="stat median heading">{field.median_value}</div>
-                    <div className="stat max heading">{field.max_value}</div>
+                  <div className="stat">
+                    <i className="fa fa-cubes" aria-hidden="true" /> {field.cardinality} distinct value{(field.cardinality > 1) ? 's' : ''}
                   </div>
-                </React.Fragment>
-              }
-            </div>
-
-            {
-              (field.top_hits) &&
-              <React.Fragment>
-
-                <EuiSpacer size="s" />
 
-                <div className="stats">
-                  <div className="stat">top values</div>
-                  {field.top_hits.map(({ count, value }) => {
-                    const pcnt = Math.round(((count / field.count) * 100) * 100) / 100;
-                    return (
-                      <div key={value} className="top-value">
-                        <div className="field-label">{value}&nbsp;</div>
-                        <div className="top-value-bar-holder">
-                          <div
-                            className={`top-value-bar ${type}`}
-                            style={{ width: `${pcnt}%` }}
-                          />
-                        </div>
-                        <div className="count-label">{pcnt}%</div>
+                  {
+                    (field.mean_value) &&
+                    <React.Fragment>
+                      <div>
+                        <div className="stat min heading">min</div>
+                        <div className="stat median heading">median</div>
+                        <div className="stat max heading">max</div>
+                      </div>
+                      <div>
+                        <div className="stat min heading">{field.min_value}</div>
+                        <div className="stat median heading">{field.median_value}</div>
+                        <div className="stat max heading">{field.max_value}</div>
                       </div>
-                    );
+                    </React.Fragment>
                   }
-                  )}
                 </div>
+
+                {
+                  (field.top_hits) &&
+                  <React.Fragment>
+
+                    <EuiSpacer size="s" />
+
+                    <div className="stats">
+                      <div className="stat">top values</div>
+                      {field.top_hits.map(({ count, value }) => {
+                        const pcnt = Math.round(((count / field.count) * 100) * 100) / 100;
+                        return (
+                          <div key={value} className="top-value">
+                            <div className="field-label">{value}&nbsp;</div>
+                            <div className="top-value-bar-holder">
+                              <div
+                                className={`top-value-bar ${type}`}
+                                style={{ width: `${pcnt}%` }}
+                              />
+                            </div>
+                            <div className="count-label">{pcnt}%</div>
+                          </div>
+                        );
+                      }
+                      )}
+                    </div>
+                  </React.Fragment>
+                }
               </React.Fragment>
             }
-
+            {(field.count === 0) &&
+              <div className="stats">
+                <div className="stat">
+                  No field information available
+                </div>
+              </div>
+            }
           </div>
         </div>
       </div>
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
index a357bca3d4346..461db01b546fc 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
@@ -10,6 +10,8 @@ import React, {
 } from 'react';
 
 import { FieldStatsCard } from './field_stats_card';
+import { getFieldNames } from './get_field_names';
+import { ML_JOB_FIELD_TYPES } from '../../../../common/constants/field_types';
 
 export class FieldsStats extends Component {
   constructor(props) {
@@ -46,26 +48,24 @@ function createFields(results) {
   const {
     mappings,
     field_stats: fieldStats,
-    column_names: columnNames,
     num_messages_analyzed: numMessagesAnalyzed,
     timestamp_field: timestampField,
   } = results;
 
   if (mappings && fieldStats) {
-    // if columnNames exists (i.e delimited) use it for the field list
-    // so we get the same order
-    const tempFields = (columnNames !== undefined) ? columnNames : Object.keys(fieldStats);
 
-    return tempFields.map((fName) => {
-      if (fieldStats[fName] !== undefined) {
-        const field = { name: fName };
-        const f  = fieldStats[fName];
-        const m  = mappings[fName];
+    const fieldNames = getFieldNames(results);
+
+    return fieldNames.map((name) => {
+      if (fieldStats[name] !== undefined) {
+        const field = { name };
+        const f  = fieldStats[name];
+        const m  = mappings[name];
 
         // sometimes the timestamp field is not in the mappings, and so our
         // collection of fields will be missing a time field with a type of date
-        if (fName === timestampField && field.type === undefined) {
-          field.type = 'date';
+        if (name === timestampField && field.type === undefined) {
+          field.type = ML_JOB_FIELD_TYPES.DATE;
         }
 
         if (f !== undefined) {
@@ -83,8 +83,15 @@ function createFields(results) {
 
         return field;
       } else {
+        // field is not in the field stats
+        // this could be a text field or a field which the endpoint has
+        // not been able to work out any information for
+        const type = (mappings[name] && mappings[name].type === ML_JOB_FIELD_TYPES.TEXT) ?
+          ML_JOB_FIELD_TYPES.TEXT : ML_JOB_FIELD_TYPES.UNKNOWN_TYPE;
+
         return {
-          name: fName,
+          name: name,
+          type,
           mean_value: 0,
           count: 0,
           cardinality: 0,
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js
new file mode 100644
index 0000000000000..4502e80ad3c06
--- /dev/null
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js
@@ -0,0 +1,37 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+
+import { difference } from 'lodash';
+
+export function getFieldNames(results) {
+  const {
+    mappings,
+    field_stats: fieldStats,
+    column_names: columnNames,
+  } = results;
+
+  // if columnNames exists (i.e delimited) use it for the field list
+  // so we get the same order
+  const tempFields = (columnNames !== undefined) ? columnNames : Object.keys(fieldStats);
+
+
+  // there may be fields in the mappings which do not exist in the field_stats
+  // e.g. text fields, as they have no stats.
+  // add any extra fields to the list
+  const differenceFields = difference(Object.keys(mappings), tempFields);
+
+  // except @timestamp
+  const timestampIndex = differenceFields.indexOf('@timestamp');
+  if (timestampIndex !== -1) {
+    differenceFields.splice(timestampIndex, 1);
+  }
+
+  if (differenceFields.length) {
+    tempFields.push(...differenceFields);
+  }
+  return tempFields;
+}
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/import_view/import_view.js b/x-pack/plugins/ml/public/file_datavisualizer/components/import_view/import_view.js
index 1297387c09e3c..4ae38a54425f0 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/import_view/import_view.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/import_view/import_view.js
@@ -10,7 +10,6 @@ import React, {
 } from 'react';
 
 import {
-  EuiBetaBadge,
   EuiButton,
   EuiSpacer,
   EuiPanel,
@@ -23,6 +22,7 @@ import { ImportProgress, IMPORT_STATUS } from '../import_progress';
 import { ImportErrors } from '../import_errors';
 import { ImportSummary } from '../import_summary';
 import { ImportSettings } from '../import_settings';
+import { ExperimentalBadge } from '../experimental_badge';
 import { getIndexPatternNames, refreshIndexPatterns } from '../../../util/index_utils';
 import { ml } from '../../../services/ml_api_service';
 
@@ -325,7 +325,9 @@ export class ImportView extends Component {
           <EuiTitle size="s">
             <h3>
               Import data &nbsp;
-              <EuiBetaBadge label="Experimental" tooltipContent="Experimental feature. We'd love to hear your feedback." />
+              <ExperimentalBadge
+                tooltipContent="Experimental feature. We'd love to hear your feedback."
+              />
             </h3>
           </EuiTitle>
 

From b43aff4181cf14d3db78b581381c4cb2ea6038bd Mon Sep 17 00:00:00 2001
From: James Gowdy <jgowdy@elastic.co>
Date: Thu, 25 Oct 2018 14:36:35 +0200
Subject: [PATCH 2/4] renaming known-type to unknown

---
 x-pack/plugins/ml/common/constants/field_types.js               | 2 +-
 .../ml/public/components/field_data_card/styles/main.less       | 2 +-
 .../ml/public/components/field_type_icon/field_type_icon.js     | 2 +-
 .../file_datavisualizer/components/fields_stats/fields_stats.js | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/x-pack/plugins/ml/common/constants/field_types.js b/x-pack/plugins/ml/common/constants/field_types.js
index a3a474ab05415..d8041b5b936b3 100644
--- a/x-pack/plugins/ml/common/constants/field_types.js
+++ b/x-pack/plugins/ml/common/constants/field_types.js
@@ -53,6 +53,6 @@ export const ML_JOB_FIELD_TYPES = {
   KEYWORD: 'keyword',
   NUMBER: 'number',
   TEXT: 'text',
-  UNKNOWN_TYPE: 'unknown-type',
+  UNKNOWN: 'unknown',
 };
 
diff --git a/x-pack/plugins/ml/public/components/field_data_card/styles/main.less b/x-pack/plugins/ml/public/components/field_data_card/styles/main.less
index f918f7066a313..1776afe87fec1 100644
--- a/x-pack/plugins/ml/public/components/field_data_card/styles/main.less
+++ b/x-pack/plugins/ml/public/components/field_data_card/styles/main.less
@@ -34,7 +34,7 @@
     background-color: #920000;
   }
 
-  .type-other, .unknown-type {
+  .type-other, .unknown {
     background-color: #bfa180;
   }
 
diff --git a/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js b/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js
index 8603b5aca4b2a..5b1868d0598d5 100644
--- a/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js
+++ b/x-pack/plugins/ml/public/components/field_type_icon/field_type_icon.js
@@ -47,7 +47,7 @@ export function FieldTypeIcon({ tooltipEnabled = false, type }) {
       ariaLabel = 'IP type';
       iconClass = 'fa-laptop';
       break;
-    case ML_JOB_FIELD_TYPES.UNKNOWN_TYPE:
+    case ML_JOB_FIELD_TYPES.UNKNOWN:
       ariaLabel = 'Unknown type';
       iconChar = '?';
       break;
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
index 461db01b546fc..569b2b832feb9 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
@@ -87,7 +87,7 @@ function createFields(results) {
         // this could be a text field or a field which the endpoint has
         // not been able to work out any information for
         const type = (mappings[name] && mappings[name].type === ML_JOB_FIELD_TYPES.TEXT) ?
-          ML_JOB_FIELD_TYPES.TEXT : ML_JOB_FIELD_TYPES.UNKNOWN_TYPE;
+          ML_JOB_FIELD_TYPES.TEXT : ML_JOB_FIELD_TYPES.UNKNOWN;
 
         return {
           name: name,

From 70e16a8526853bb671c057a974cfa3c2a29cdfbd Mon Sep 17 00:00:00 2001
From: James Gowdy <jgowdy@elastic.co>
Date: Thu, 25 Oct 2018 14:57:40 +0200
Subject: [PATCH 3/4] correcting comments

---
 .../components/fields_stats/fields_stats.js                   | 4 ++--
 .../components/fields_stats/get_field_names.js                | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
index 569b2b832feb9..5f48dd4dfc6f4 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
@@ -84,8 +84,8 @@ function createFields(results) {
         return field;
       } else {
         // field is not in the field stats
-        // this could be a text field or a field which the endpoint has
-        // not been able to work out any information for
+        // this could be the message field for a semi-structured log file or a
+        // field which the endpoint has not been able to work out any information for
         const type = (mappings[name] && mappings[name].type === ML_JOB_FIELD_TYPES.TEXT) ?
           ML_JOB_FIELD_TYPES.TEXT : ML_JOB_FIELD_TYPES.UNKNOWN;
 
diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js
index 4502e80ad3c06..858f2bd0cf095 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/get_field_names.js
@@ -20,7 +20,7 @@ export function getFieldNames(results) {
 
 
   // there may be fields in the mappings which do not exist in the field_stats
-  // e.g. text fields, as they have no stats.
+  // e.g. the message field for a semi-structured log file, as they have no stats.
   // add any extra fields to the list
   const differenceFields = difference(Object.keys(mappings), tempFields);
 

From 2dab2ce8aeebc5d1980f52a3612f5289e6d81d2c Mon Sep 17 00:00:00 2001
From: James Gowdy <jgowdy@elastic.co>
Date: Thu, 25 Oct 2018 15:38:22 +0200
Subject: [PATCH 4/4] tiny refactor

---
 .../file_datavisualizer/components/fields_stats/fields_stats.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
index 5f48dd4dfc6f4..b8166567fb09c 100644
--- a/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
+++ b/x-pack/plugins/ml/public/file_datavisualizer/components/fields_stats/fields_stats.js
@@ -90,7 +90,7 @@ function createFields(results) {
           ML_JOB_FIELD_TYPES.TEXT : ML_JOB_FIELD_TYPES.UNKNOWN;
 
         return {
-          name: name,
+          name,
           type,
           mean_value: 0,
           count: 0,