diff --git a/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.test.tsx b/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.test.tsx index ab15ebd5a47c7..f867e6093c847 100644 --- a/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.test.tsx +++ b/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.test.tsx @@ -8,7 +8,7 @@ import React from 'react'; import { renderWithReduxStore } from '../mocks'; import { SettingsMenu } from './settings_menu'; -import { screen, waitFor } from '@testing-library/react'; +import { screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; describe('settings menu', () => { @@ -41,17 +41,6 @@ describe('settings menu', () => { }; }; - afterEach(() => { - onCloseMock.mockClear(); - }); - - it('should call onClose when popover closes after toggling', async () => { - const { toggleAutoApply } = renderSettingsMenu(); - await toggleAutoApply(); - - await waitFor(() => expect(onCloseMock).toHaveBeenCalledTimes(1)); - }); - it('should toggle auto-apply', async () => { const { toggleAutoApply, isAutoApplyOn } = renderSettingsMenu(); diff --git a/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.tsx b/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.tsx index 09eb90be2c3c7..4f6cd8af6f15b 100644 --- a/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.tsx +++ b/x-pack/platform/plugins/shared/lens/public/app_plugin/settings_menu.tsx @@ -44,14 +44,13 @@ export function SettingsMenu({ const dispatch = useLensDispatch(); const toggleAutoApply = useCallback(() => { - onClose(); writeToStorage( new Storage(localStorage), AUTO_APPLY_DISABLED_STORAGE_KEY, String(autoApplyEnabled) ); dispatch(autoApplyEnabled ? disableAutoApply() : enableAutoApply()); - }, [dispatch, autoApplyEnabled, onClose]); + }, [dispatch, autoApplyEnabled]); return (