From 290a0d6443ca0b8228bf2b9d2724cd78dbc4de4a Mon Sep 17 00:00:00 2001 From: Brittany Date: Mon, 4 Aug 2025 12:13:20 +0100 Subject: [PATCH 1/2] [Search] Root Elasticsearch breadcrumb missing link (#230270) Root Elasticsearch breadcrumb missing link when set from search navigation API. On the search applications page, the breadcrumb for Elasticsearch had a link back to the home page. This link was missing for the breadcrumbs on the query rules and other pages that use search navigation to set breadcrumbs. **Working breadcrumb on the search applications page** Screenshot 2025-07-31 at 14 41 51 **Broken breadcrumb on the query rules page** Screenshot 2025-07-31 at 14 42 01 **Fixed breadcrumb on the query rules page** Screenshot 2025-08-01 at 16 41 36 Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~ - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [ ] ~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~ - [ ] ~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~ - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. Fixes Elasticsearch breadcrumb to include a link to the home page for search pages. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3de36a3276bfacdb25ddbe6f5266c79cb05bbe4b) --- .../search_solution/search_navigation/public/plugin.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/x-pack/solutions/search/plugins/search_solution/search_navigation/public/plugin.ts b/x-pack/solutions/search/plugins/search_solution/search_navigation/public/plugin.ts index ddaf0b059fceb..cdb593767d233 100644 --- a/x-pack/solutions/search/plugins/search_solution/search_navigation/public/plugin.ts +++ b/x-pack/solutions/search/plugins/search_solution/search_navigation/public/plugin.ts @@ -16,6 +16,7 @@ import type { Subscription } from 'rxjs'; import type { ChromeBreadcrumb, ChromeStyle } from '@kbn/core-chrome-browser'; import { i18n } from '@kbn/i18n'; import type { Logger } from '@kbn/logging'; +import { ENTERPRISE_SEARCH_APP_ID } from '@kbn/deeplinks-search'; import type { SearchNavigationPluginSetup, SearchNavigationPluginStart, @@ -129,12 +130,13 @@ export class SearchNavigationPlugin } private getSearchHomeBreadcrumb(): ChromeBreadcrumb { - // TODO: When search_navigation handles solution nav, use the default // home deep link for this breadcrumb's path. + const homeHref = this.coreStart?.chrome.navLinks.get(ENTERPRISE_SEARCH_APP_ID)?.href; return { text: i18n.translate('xpack.searchNavigation.breadcrumbs.home.title', { defaultMessage: 'Elasticsearch', }), + href: homeHref, }; } } From 74834549acafd80c40d9dba0f4aa56c3816c9d9a Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Wed, 6 Aug 2025 13:15:42 +0000 Subject: [PATCH 2/2] [CI] Auto-commit changed files from 'node scripts/styled_components_mapping' --- .../plugins/search_solution/search_navigation/tsconfig.json | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/solutions/search/plugins/search_solution/search_navigation/tsconfig.json b/x-pack/solutions/search/plugins/search_solution/search_navigation/tsconfig.json index a56616b2d6940..947fbd1259509 100644 --- a/x-pack/solutions/search/plugins/search_solution/search_navigation/tsconfig.json +++ b/x-pack/solutions/search/plugins/search_solution/search_navigation/tsconfig.json @@ -15,6 +15,7 @@ "@kbn/logging", "@kbn/serverless", "@kbn/core-plugins-browser", + "@kbn/deeplinks-search", ], "exclude": ["target/**/*"] }