From 41b386f1d3788c09d6faf297d4d62311b92cdde3 Mon Sep 17 00:00:00 2001 From: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Date: Sat, 12 Jul 2025 18:22:22 +0200 Subject: [PATCH 1/4] (Accessibility) Dashboard controls should be grouped as a labelled list (#227633) ## Summary Fixes https://github.com/elastic/kibana/issues/154561 Screenshot 2025-07-11 at 14 06 34 (cherry picked from commit b3a923e61112e915a74d5a06ccf40de83ae3321d) --- .../public/control_group/components/control_group.tsx | 8 +++++++- .../public/control_group/components/control_panel.tsx | 1 + .../functional/page_objects/dashboard_page_controls.ts | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/platform/plugins/shared/controls/public/control_group/components/control_group.tsx b/src/platform/plugins/shared/controls/public/control_group/components/control_group.tsx index 6453474aa8ff2..e7f75d4b39c11 100644 --- a/src/platform/plugins/shared/controls/public/control_group/components/control_group.tsx +++ b/src/platform/plugins/shared/controls/public/control_group/components/control_group.tsx @@ -147,7 +147,13 @@ export function ControlGroup({ }} > - + {controlsInOrder.map(({ id, type }) => ( Date: Tue, 15 Jul 2025 20:49:59 +0000 Subject: [PATCH 2/4] [CI] Auto-commit changed files from 'node scripts/lint_packages --fix' --- .github/CODEOWNERS | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 655ac158d7c10..429d1efee2a63 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -75,8 +75,8 @@ src/platform/packages/shared/kbn-calculate-auto @elastic/obs-ux-management-team src/platform/packages/shared/kbn-calculate-width-from-char-count @elastic/kibana-visualizations x-pack/platform/plugins/private/canvas @elastic/kibana-presentation packages/kbn-capture-oas-snapshot-cli @elastic/kibana-core -x-pack/platform/test/cases_api_integration/common/plugins/cases @elastic/kibana-cases -src/platform/packages/shared/kbn-cases-components @elastic/kibana-cases +x-pack/platform/test/cases_api_integration/common/plugins/cases @elastic/response-ops +src/platform/packages/shared/kbn-cases-components @elastic/response-ops x-pack/platform/plugins/shared/cases @elastic/response-ops @elastic/kibana-cases src/platform/packages/shared/kbn-cbor @elastic/kibana-operations src/platform/packages/shared/kbn-cell-actions @elastic/security-threat-hunting-investigations @@ -513,7 +513,7 @@ src/platform/plugins/private/ftr_apis @elastic/kibana-core src/platform/packages/shared/kbn-ftr-common-functional-services @elastic/kibana-operations @elastic/appex-qa src/platform/packages/shared/kbn-ftr-common-functional-ui-services @elastic/appex-qa src/platform/packages/private/kbn-ftr-screenshot-filename @elastic/kibana-operations @elastic/appex-qa -x-pack/platform/test/functional_with_es_ssl/plugins/cases @elastic/kibana-cases +x-pack/platform/test/functional_with_es_ssl/plugins/cases @elastic/response-ops src/platform/packages/private/kbn-gen-ai-functional-testing @elastic/appex-ai-infra x-pack/examples/gen_ai_streaming_response_example @elastic/response-ops packages/kbn-generate @elastic/kibana-operations @@ -695,7 +695,7 @@ x-pack/solutions/observability/packages/observability-ai/observability-ai-common x-pack/solutions/observability/packages/observability-ai/observability-ai-server @elastic/obs-ai-assistant x-pack/solutions/observability/packages/alert-details @elastic/obs-ux-management-team x-pack/solutions/observability/packages/alerting-test-data @elastic/obs-ux-management-team -x-pack/platform/test/cases_api_integration/common/plugins/observability @elastic/kibana-cases +x-pack/platform/test/cases_api_integration/common/plugins/observability @elastic/response-ops x-pack/solutions/observability/packages/get-padded-alert-time-range-util @elastic/obs-ux-management-team x-pack/solutions/observability/plugins/observability_logs_explorer @elastic/obs-ux-logs-team x-pack/solutions/observability/plugins/observability_onboarding @elastic/obs-ux-logs-team @@ -862,7 +862,7 @@ x-pack/solutions/security/packages/connectors @elastic/security-threat-hunting-i x-pack/solutions/security/packages/distribution-bar @elastic/kibana-cloud-security-posture x-pack/solutions/security/plugins/security_solution_ess @elastic/security-solution x-pack/solutions/security/packages/features @elastic/security-threat-hunting-investigations -x-pack/platform/test/cases_api_integration/common/plugins/security_solution @elastic/kibana-cases +x-pack/platform/test/cases_api_integration/common/plugins/security_solution @elastic/response-ops x-pack/solutions/security/packages/navigation @elastic/security-threat-hunting-investigations x-pack/solutions/security/plugins/security_solution @elastic/security-solution x-pack/solutions/security/plugins/security_solution_serverless @elastic/security-solution @@ -2813,4 +2813,11 @@ x-pack/plugins/observability_solution/synthetics/server/saved_objects/synthetics # See https://github.com/elastic/kibana/pull/199404 # Prevent backport assignments -* @kibanamachine \ No newline at end of file +* @kibanamachine +#### +## These rules are always last so they take ultimate priority over everything else +#### + +# See https://github.com/elastic/kibana/pull/199404 +# Prevent backport assignments +* @kibanamachine From d38c06c527e06d526200c84230dc0b5769e044d3 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Tue, 15 Jul 2025 21:06:08 +0000 Subject: [PATCH 3/4] [CI] Auto-commit changed files from 'node scripts/generate codeowners' --- .github/CODEOWNERS | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 429d1efee2a63..e03f18ca3772a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2814,10 +2814,3 @@ x-pack/plugins/observability_solution/synthetics/server/saved_objects/synthetics # See https://github.com/elastic/kibana/pull/199404 # Prevent backport assignments * @kibanamachine -#### -## These rules are always last so they take ultimate priority over everything else -#### - -# See https://github.com/elastic/kibana/pull/199404 -# Prevent backport assignments -* @kibanamachine From c2a2bdaa21e0e719fa4e109bb7ff5690d9e8adc8 Mon Sep 17 00:00:00 2001 From: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Date: Wed, 16 Jul 2025 10:49:53 +0200 Subject: [PATCH 4/4] Update CODEOWNERS --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4063532b1def7..b7cffd959b942 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2813,4 +2813,4 @@ x-pack/plugins/observability_solution/synthetics/server/saved_objects/synthetics # See https://github.com/elastic/kibana/pull/199404 # Prevent backport assignments -* @kibanamachine \ No newline at end of file +* @kibanamachine