From e063fcc555351df222dacd24849048db448b6a57 Mon Sep 17 00:00:00 2001 From: Zied Kharrat <98645757+zk2k2@users.noreply.github.com> Date: Fri, 11 Jul 2025 12:30:19 +0100 Subject: [PATCH 1/2] [CSP] Show loading indicator in misconfigurations flyout table Currently, when expanding the misconfigurations flyout, the table shows a "No items found" message while data is loading. This change adds the `loading` prop to the `` to properly display a loading spinner during the data fetch. Fixes: Issue #226694 --- .../csp_details/misconfiguration_findings_details_table.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx b/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx index 13b7a157f0c9c..75827eb75f035 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx @@ -143,7 +143,7 @@ export const MisconfigurationFindingsDetailsTable = memo( const sortFieldDirection: { [key: string]: string } = {}; sortFieldDirection[sortField] = sortDirection; - const { data } = useMisconfigurationFindings({ + const { data, isLoading } = useMisconfigurationFindings({ query: buildMisconfigurationEntityFlyoutPreviewQuery(field, value, currentFilter), sort: [sortFieldDirection], enabled: true, @@ -327,8 +327,9 @@ export const MisconfigurationFindingsDetailsTable = memo( onChange={onTableChange} data-test-subj={'securitySolutionFlyoutMisconfigurationFindingsTable'} sorting={sorting} + loading={isLoading} /> - + ); } From cb0e1c9ad406cb784ecacb938a0c21cd3f93daa8 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Fri, 11 Jul 2025 19:12:11 +0000 Subject: [PATCH 2/2] [CI] Auto-commit changed files from 'node scripts/eslint_all_files --no-cache --fix' --- .../csp_details/misconfiguration_findings_details_table.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx b/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx index 75827eb75f035..6d8b5688c1412 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/components/csp_details/misconfiguration_findings_details_table.tsx @@ -329,7 +329,7 @@ export const MisconfigurationFindingsDetailsTable = memo( sorting={sorting} loading={isLoading} /> - + ); }