From 07d3d62d8e76b0ef5e353ab9b4c925422d6e6d64 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Mon, 7 Jul 2025 14:45:11 +0300 Subject: [PATCH 1/8] Auto-fix violations of the @elastic/eui/consistent-is-invalid-props ESLint rule --- .../alerts-delete/components/modal.tsx | 1 + .../rule_consumer_selection.tsx | 1 + .../src/rule_details/rule_details.tsx | 2 ++ .../image_editor/image_editor_flyout.tsx | 1 + .../options/required_number_input.tsx | 2 +- .../components/form_fields/name_field.tsx | 1 + .../field_format_editor/editors/url/url.tsx | 2 ++ .../components/fields/combobox_field.tsx | 1 + .../components/destination_index_form.tsx | 4 ++- .../components/additional_options_fields.tsx | 1 + .../combined_fields/semantic_text.tsx | 1 + .../public/lite/index_input.tsx | 1 + .../geo_upload_form/geo_file_picker.tsx | 1 + .../add_policy_to_template_confirm_modal.tsx | 1 + .../add_lifecycle_confirm_modal.tsx | 1 + .../flyout_expressions/alert_param_number.tsx | 1 + .../alert_param_percentage.tsx | 1 + .../alert_param_textfield.tsx | 1 + .../policy_form/steps/step_logistics.tsx | 2 ++ .../policy_form/steps/step_retention.tsx | 2 ++ .../components/repository_form/step_one.tsx | 1 + .../type_settings/azure_settings.tsx | 1 + .../type_settings/common/chunk_size.tsx | 1 + .../type_settings/common/max_restore.tsx | 1 + .../type_settings/common/max_snapshots.tsx | 1 + .../type_settings/fs_settings.tsx | 1 + .../type_settings/hdfs_settings.tsx | 3 +++ .../type_settings/readonly_settings.tsx | 1 + .../type_settings/s3_settings.tsx | 3 +++ .../steps/step_logistics/step_logistics.tsx | 2 ++ .../steps/step_settings.tsx | 1 + .../retention_update_modal_provider.tsx | 1 + .../components/group_by_list/popover_form.tsx | 1 + .../common/terms_agg/terms_form_component.tsx | 1 + .../step_details/step_details_form.tsx | 2 +- .../edit_transform_retention_policy.tsx | 1 + .../data_stream_step/data_stream_step.tsx | 2 +- .../components/case_form_fields/assignees.tsx | 1 + .../connectors/resilient/case_fields.tsx | 1 + .../connector_detail/attach_index_box.tsx | 1 + .../create_connector/start_step.tsx | 1 + .../agent_policy_advanced_fields/index.tsx | 2 +- .../space_selector.tsx | 1 + .../steps/step_define_package_policy.tsx | 3 +++ .../components/migrate_agent_flyout/index.tsx | 1 + .../output_form_kafka_headers.tsx | 2 ++ .../public/components/namespace_combo_box.tsx | 1 + .../fielddata_frequency_filter_absolute.tsx | 1 + .../field_parameters/path_parameter.tsx | 1 + .../field_parameters/subtype_parameter.tsx | 1 + .../field_parameters/type_parameter.tsx | 1 + .../steps/fields/indices_selector.tsx | 1 + .../create_index/create_index_modal.tsx | 1 + .../common_fields/processor_type_field.tsx | 1 + .../operations/definitions/static_value.tsx | 1 + .../shared_components/range_input_field.tsx | 1 + .../components/pipeline_details.tsx | 1 + .../components/reindex_with_pipeline.tsx | 1 + .../shared/pipeline_name_and_description.tsx | 1 + .../advanced_step/advanced_step_form.tsx | 9 +++++-- .../advanced_step/hyper_parameters.tsx | 26 ++++++++++++++++--- .../outlier_hyper_parameters.tsx | 3 +++ .../details_step/details_step_form.tsx | 2 +- .../action_edit/edit_action_flyout.tsx | 1 + .../data_drift/data_view_editor.tsx | 1 + .../explorer/anomaly_context_menu.tsx | 1 + .../edit/calendar_form/calendar_form.tsx | 1 + .../anomaly_charts_initializer.tsx | 1 + .../job_creation/common/job_details.tsx | 2 ++ .../form/packs_combobox_field.tsx | 2 +- .../queries/ecs_mapping_editor_field.tsx | 1 + .../saved_queries/saved_queries_dropdown.tsx | 1 + .../es_index/es_index_params.tsx | 1 + .../swimlane/steps/swimlane_fields.tsx | 1 + .../connector_types/tines/tines_params.tsx | 3 +++ .../public/connector_types/xsoar/params.tsx | 1 + .../config_driven/components/array_field.tsx | 1 + .../src/components/create/form.tsx | 2 +- .../java_agent_version_input.tsx | 1 + .../expression_editor/criterion.tsx | 2 ++ .../expression_editor/threshold.tsx | 1 + .../settings/indices_configuration_panel.tsx | 1 + .../settings/name_configuration_panel.tsx | 1 + .../burn_rate_rule_editor/budget_consumed.tsx | 1 + .../burn_rate_rule_editor/burn_rate.tsx | 1 + .../timeslice_metric/metric_indicator.tsx | 1 + .../throttling/throttling_download_field.tsx | 4 +++ .../throttling/throttling_latency_field.tsx | 1 + .../throttling/throttling_upload_field.tsx | 4 +++ .../monitor_add_edit/fields/uploader.tsx | 1 + .../settings/global_params/add_param_form.tsx | 1 + .../global_params/param_value_field.tsx | 2 ++ .../components/settings/indices_form.tsx | 1 + .../connector_detail/attach_index_box.tsx | 1 + .../create_connector/start_step.tsx | 1 + .../new_connector_template.tsx | 2 +- .../ml_inference/configure_pipeline.tsx | 1 + .../shared/api_key/basic_setup_form.tsx | 1 + .../shared/schema/add_field_modal/index.tsx | 1 + .../overview/create_ruleset_modal.tsx | 1 + .../query_rule_metadata_editor.tsx | 2 ++ .../synonym_sets/create_new_set_modal.tsx | 1 + .../connector_index_name_form.tsx | 1 + .../src/field_value_match/index.tsx | 1 + .../markdown_editor/plugins/insight/index.tsx | 4 +++ .../components/duration_input/index.tsx | 1 + .../schedule_item_field.tsx | 1 + .../data_view_selector_field.tsx | 1 + .../components/item_comments/index.tsx | 1 + .../view/components/blocklist_form.tsx | 1 + .../event_filters/view/components/form.tsx | 1 + .../view/components/form.tsx | 2 ++ .../trusted_apps/view/components/form.tsx | 1 + .../lookups_file_upload.tsx | 1 + .../macros_file_upload/macros_file_upload.tsx | 1 + .../rules_file_upload/rules_file_upload.tsx | 1 + 116 files changed, 176 insertions(+), 14 deletions(-) diff --git a/src/platform/packages/shared/response-ops/alerts-delete/components/modal.tsx b/src/platform/packages/shared/response-ops/alerts-delete/components/modal.tsx index 114cb484fdb21..247c1b54cce72 100644 --- a/src/platform/packages/shared/response-ops/alerts-delete/components/modal.tsx +++ b/src/platform/packages/shared/response-ops/alerts-delete/components/modal.tsx @@ -420,6 +420,7 @@ export const AlertDeleteModal = ({ isInvalid={!validations.isDeleteConfirmationValid} > { aria-label={CONSUMER_SELECT_TITLE} > { error={baseErrors?.name} > { error={baseErrors?.tags} > ({ required data-test-subj={dataTestSubj} disabled={disabled} - isInvalid={!isValid} + isInvalid={isInvalid} step={step} max={max} min={min} diff --git a/src/platform/plugins/shared/data_view_editor/public/components/form_fields/name_field.tsx b/src/platform/plugins/shared/data_view_editor/public/components/form_fields/name_field.tsx index d58959fdf7368..32413b6011224 100644 --- a/src/platform/plugins/shared/data_view_editor/public/components/form_fields/name_field.tsx +++ b/src/platform/plugins/shared/data_view_editor/public/components/form_fields/name_field.tsx @@ -78,6 +78,7 @@ export const NameField = ({ namesNotAllowed }: NameFieldProps) => { return ( ) => { field.setValue(e.target.value); diff --git a/src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/url/url.tsx b/src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/url/url.tsx index 03cd4aae87b44..498baa64b277c 100644 --- a/src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/url/url.tsx +++ b/src/platform/plugins/shared/data_view_field_editor/public/components/field_format_editor/editors/url/url.tsx @@ -223,6 +223,7 @@ export class UrlFormatEditor extends DefaultFormatEditor< error={error} > { @@ -253,6 +254,7 @@ export class UrlFormatEditor extends DefaultFormatEditor< error={error} > { diff --git a/src/platform/plugins/shared/es_ui_shared/static/forms/components/fields/combobox_field.tsx b/src/platform/plugins/shared/es_ui_shared/static/forms/components/fields/combobox_field.tsx index 38d880fbe0aaf..cb3fcf55efe16 100644 --- a/src/platform/plugins/shared/es_ui_shared/static/forms/components/fields/combobox_field.tsx +++ b/src/platform/plugins/shared/es_ui_shared/static/forms/components/fields/combobox_field.tsx @@ -82,6 +82,7 @@ export const ComboBoxField = ({ field, euiFieldProps = {}, idAria, ...rest }: Pr {...rest} > = ({ defaultMessage: 'Choose a unique destination index name.', } )} - isInvalid={!destinationIndexNameEmpty && !destinationIndexNameValid} + isInvalid={ + destinationIndexNameEmpty || (!destinationIndexNameEmpty && !destinationIndexNameValid) + } data-test-subj="mlCreationWizardUtilsDestinationIndexInput" /> diff --git a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx index d89ae352957ed..da4b0a5716ef8 100644 --- a/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx +++ b/x-pack/platform/packages/shared/kbn-inference-endpoint-ui-common/src/components/additional_options_fields.tsx @@ -254,6 +254,7 @@ export const AdditionalOptionsFields: React.FC = ( } > = ({ addCombinedField, hasNameCollision error={[fieldError]} > = ({ )} > setIndexNameLocal(e.target.value)} diff --git a/x-pack/platform/plugins/private/file_upload/public/components/geo_upload_form/geo_file_picker.tsx b/x-pack/platform/plugins/private/file_upload/public/components/geo_upload_form/geo_file_picker.tsx index a9b720428d208..6a3bae37018c7 100644 --- a/x-pack/platform/plugins/private/file_upload/public/components/geo_upload_form/geo_file_picker.tsx +++ b/x-pack/platform/plugins/private/file_upload/public/components/geo_upload_form/geo_file_picker.tsx @@ -151,6 +151,7 @@ export class GeoFilePicker extends Component { helpText={this._renderHelpText()} > = ( } > { } > { diff --git a/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_number.tsx b/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_number.tsx index fe41a3a77597f..6597c1f6a30bb 100644 --- a/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_number.tsx +++ b/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_number.tsx @@ -21,6 +21,7 @@ export const AlertParamNumber: React.FC = (props: Props) => { return ( 0}> 0} compressed value={value} append={details.append as string} diff --git a/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_percentage.tsx b/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_percentage.tsx index cdcc43eb60cd0..17e23e421ef46 100644 --- a/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_percentage.tsx +++ b/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_percentage.tsx @@ -22,6 +22,7 @@ export const AlertParamPercentage: React.FC = (props: Props) => { return ( 0}> 0} compressed value={value} append={ diff --git a/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_textfield.tsx b/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_textfield.tsx index cff4507b0b77d..ec201909b567e 100644 --- a/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_textfield.tsx +++ b/x-pack/platform/plugins/private/monitoring/public/alerts/flyout_expressions/alert_param_textfield.tsx @@ -22,6 +22,7 @@ export const AlertParamTextField: React.FC = (props: Props) => { return ( 0}> 0} compressed placeholder={placeholder} value={value} diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx index d6f739827d9be..fc91bec7d76f6 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx @@ -111,6 +111,7 @@ export const PolicyStepLogistics: React.FunctionComponent = ({ fullWidth > setTouched({ ...touched, name: true })} @@ -412,6 +413,7 @@ export const PolicyStepLogistics: React.FunctionComponent = ({ fullWidth > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_retention.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_retention.tsx index 336ffa157d3ca..14d258e71e7f1 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_retention.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/policy_form/steps/step_retention.tsx @@ -170,6 +170,7 @@ export const PolicyStepRetention: React.FunctionComponent = ({ fullWidth > setTouched({ ...touched, minCount: true })} @@ -197,6 +198,7 @@ export const PolicyStepRetention: React.FunctionComponent = ({ fullWidth > setTouched({ ...touched, maxCount: true })} diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/step_one.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/step_one.tsx index 666360f48c432..31e9eeeb325b8 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/step_one.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/step_one.tsx @@ -115,6 +115,7 @@ export const RepositoryFormStepOne: React.FunctionComponent = ({ fullWidth > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/azure_settings.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/azure_settings.tsx index 4eff9d93d2303..001d1d52f05fc 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/azure_settings.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/azure_settings.tsx @@ -335,6 +335,7 @@ export const AzureSettings: React.FunctionComponent = ({ error={settingErrors.locationMode} > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/chunk_size.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/chunk_size.tsx index 0eb7185aaa4b9..38a5c1d8d2da2 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/chunk_size.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/chunk_size.tsx @@ -67,6 +67,7 @@ export const ChunkSizeField: React.FunctionComponent = ({ } > updateSettings('chunkSize', e.target.value)} diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_restore.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_restore.tsx index b5be6d079558b..82cf640fef8e0 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_restore.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_restore.tsx @@ -67,6 +67,7 @@ export const MaxRestoreField: React.FunctionComponent = ({ } > updateSettings('maxRestoreBytesPerSec', e.target.value)} diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_snapshots.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_snapshots.tsx index b126770e37ac1..8facff6ee15a4 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_snapshots.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/common/max_snapshots.tsx @@ -68,6 +68,7 @@ export const MaxSnapshotsField: React.FunctionComponent = ({ } > updateSettings('maxSnapshotBytesPerSec', e.target.value)} diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/fs_settings.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/fs_settings.tsx index f402c6e342206..e99538adc8ffa 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/fs_settings.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/fs_settings.tsx @@ -89,6 +89,7 @@ export const FSSettings: React.FunctionComponent = ({ error={settingErrors.location} > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/hdfs_settings.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/hdfs_settings.tsx index 5526b6fe006c0..0e1802e5922c2 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/hdfs_settings.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/hdfs_settings.tsx @@ -97,6 +97,7 @@ export const HDFSSettings: React.FunctionComponent = ({ error={settingErrors.uri} > {/* Wrap as string due to prettier not parsing `//` inside JSX correctly (prettier/prettier#2347) */} @@ -148,6 +149,7 @@ export const HDFSSettings: React.FunctionComponent = ({ error={settingErrors.path} > { @@ -286,6 +288,7 @@ export const HDFSSettings: React.FunctionComponent = ({ error={settingErrors.securityPrincipal} > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/readonly_settings.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/readonly_settings.tsx index a6451bb538cc5..5a4fd0f0773a1 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/readonly_settings.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/readonly_settings.tsx @@ -150,6 +150,7 @@ export const ReadonlySettings: React.FunctionComponent = ({ error={settingErrors.url} > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/s3_settings.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/s3_settings.tsx index 9747928f9b5ae..a73f8a0fb58db 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/s3_settings.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/repository_form/type_settings/s3_settings.tsx @@ -393,6 +393,7 @@ export const S3Settings: React.FunctionComponent = ({ } > { @@ -437,6 +438,7 @@ export const S3Settings: React.FunctionComponent = ({ error={settingErrors.cannedAcl} > { @@ -482,6 +484,7 @@ export const S3Settings: React.FunctionComponent = ({ error={settingErrors.storageClass} > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_logistics/step_logistics.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_logistics/step_logistics.tsx index 1c7ddc2fc6712..ed32865c87fa4 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_logistics/step_logistics.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_logistics/step_logistics.tsx @@ -502,6 +502,7 @@ export const RestoreSnapshotStepLogistics: React.FunctionComponent = error={errors.renamePattern} > { @@ -529,6 +530,7 @@ export const RestoreSnapshotStepLogistics: React.FunctionComponent = error={errors.renameReplacement} > { diff --git a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_settings.tsx b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_settings.tsx index 1b6d2ea2b7afc..5a1dd8624f785 100644 --- a/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_settings.tsx +++ b/x-pack/platform/plugins/private/snapshot_restore/public/application/components/restore_snapshot_form/steps/step_settings.tsx @@ -281,6 +281,7 @@ export const RestoreSnapshotStepSettings: React.FunctionComponent = ( error={errors.ignoreIndexSettings} > setRetentionSchedule(e.target.value)} diff --git a/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/group_by_list/popover_form.tsx b/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/group_by_list/popover_form.tsx index 5ee35a6312882..4f2f448987918 100644 --- a/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/group_by_list/popover_form.tsx +++ b/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/group_by_list/popover_form.tsx @@ -302,6 +302,7 @@ export const PopoverForm: React.FC = ({ defaultData, otherAggNames, onCha })} > setSelectedTimeZone(opt)} selectedOptions={selectedTimeZone} diff --git a/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_define/common/terms_agg/terms_form_component.tsx b/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_define/common/terms_agg/terms_form_component.tsx index 0af2c70564adf..347ed8f56fac7 100644 --- a/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_define/common/terms_agg/terms_form_component.tsx +++ b/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_define/common/terms_agg/terms_form_component.tsx @@ -31,6 +31,7 @@ export const TermsAggForm: IPivotAggsConfigTerms['AggFormComponent'] = ({ isInvalid={!isValid} > { onChange({ size: Number(e.target.value) }); diff --git a/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx b/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx index 3bfcd7d7d9dfb..59b27a52f264d 100644 --- a/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx +++ b/x-pack/platform/plugins/private/transform/public/app/sections/create_transform/components/step_details/step_details_form.tsx @@ -826,7 +826,7 @@ export const StepDetailsForm: FC = React.memo( defaultMessage: 'Choose a maximum page search size.', } )} - isInvalid={!isTransformFrequencyValid} + isInvalid={!isTransformSettingsMaxPageSearchSizeValid} data-test-subj="transformMaxPageSearchSizeInput" /> diff --git a/x-pack/platform/plugins/private/transform/public/app/sections/edit_transform/components/edit_transform_retention_policy.tsx b/x-pack/platform/plugins/private/transform/public/app/sections/edit_transform/components/edit_transform_retention_policy.tsx index 119302cab7581..844f31f164ff7 100644 --- a/x-pack/platform/plugins/private/transform/public/app/sections/edit_transform/components/edit_transform_retention_policy.tsx +++ b/x-pack/platform/plugins/private/transform/public/app/sections/edit_transform/components/edit_transform_retention_policy.tsx @@ -140,6 +140,7 @@ export const EditTransformRetentionPolicy: FC = () => { )} > 0} aria-label={i18n.translate( 'xpack.transform.transformList.editFlyoutFormRetentionPolicyFieldSelectAriaLabel', { diff --git a/x-pack/platform/plugins/shared/automatic_import/public/components/create_integration/create_automatic_import/steps/data_stream_step/data_stream_step.tsx b/x-pack/platform/plugins/shared/automatic_import/public/components/create_integration/create_automatic_import/steps/data_stream_step/data_stream_step.tsx index 4c9e9270b9c71..08ffa3d5d95ef 100644 --- a/x-pack/platform/plugins/shared/automatic_import/public/components/create_integration/create_automatic_import/steps/data_stream_step/data_stream_step.tsx +++ b/x-pack/platform/plugins/shared/automatic_import/public/components/create_integration/create_automatic_import/steps/data_stream_step/data_stream_step.tsx @@ -198,7 +198,7 @@ export const DataStreamStep = React.memo( data-test-subj="nameInput" value={name} onChange={onChange.name} - isInvalid={invalidFields.name} + isInvalid={!!nameInputError || invalidFields.name} isLoading={isLoadingPackageNames} disabled={isLoadingPackageNames} /> diff --git a/x-pack/platform/plugins/shared/cases/public/components/case_form_fields/assignees.tsx b/x-pack/platform/plugins/shared/cases/public/components/case_form_fields/assignees.tsx index d3a6363d33a3c..57a87abc920c9 100644 --- a/x-pack/platform/plugins/shared/cases/public/components/case_form_fields/assignees.tsx +++ b/x-pack/platform/plugins/shared/cases/public/components/case_form_fields/assignees.tsx @@ -182,6 +182,7 @@ const AssigneesFieldComponent: React.FC = React.memo( data-test-subj="caseAssignees" > = error={errorMessage} > = ({ connector }) => isInvalid={!!error} > = ({ } > = namespace: (selectedOptions.length ? selectedOptions[0] : '') as string, }); }} - isInvalid={Boolean(touchedFields.namespace && validation.namespace)} + isInvalid={Boolean(validation.namespace)} onBlur={() => setTouchedFields({ ...touchedFields, namespace: true })} /> diff --git a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/space_selector.tsx b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/space_selector.tsx index 123044059eae0..8c064fbba8d55 100644 --- a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/space_selector.tsx +++ b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_advanced_fields/space_selector.tsx @@ -122,6 +122,7 @@ export const SpaceSelectorComponent: React.FC = ({ isInvalid={Boolean(error)} > { diff --git a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/migrate_agent_flyout/index.tsx b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/migrate_agent_flyout/index.tsx index 1fdd13665d31e..2463836434296 100644 --- a/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/migrate_agent_flyout/index.tsx +++ b/x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/migrate_agent_flyout/index.tsx @@ -227,6 +227,7 @@ export const AgentMigrateFlyout: React.FC = ({ } > 0} > 0} data-test-subj={`settingsOutputsFlyout.kafkaHeadersKeyInput${index}`} fullWidth value={pair.key} @@ -159,6 +160,7 @@ export const OutputFormKafkaHeaders: React.FunctionComponent<{ inputs: OutputFor isInvalid={(valueErrors?.length ?? 0) > 0} > 0} data-test-subj={`settingsOutputsFlyout.kafkaHeadersValueInput${index}`} fullWidth value={pair.value} diff --git a/x-pack/platform/plugins/shared/fleet/public/components/namespace_combo_box.tsx b/x-pack/platform/plugins/shared/fleet/public/components/namespace_combo_box.tsx index eeb4f077d131e..6dba8f7a8e965 100644 --- a/x-pack/platform/plugins/shared/fleet/public/components/namespace_combo_box.tsx +++ b/x-pack/platform/plugins/shared/fleet/public/components/namespace_combo_box.tsx @@ -91,6 +91,7 @@ export const NamespaceComboBox: React.FC = ({ helpText={getHelpText()} > { } > { fullWidth > { {...rest} > = ({ initialType }) => data-test-subj="processorTypeSelector" > = memo( isInvalid={targetFieldError !== undefined} > = ({ pipelineName, sourceIndex }) => } > = ({ isInvalid={pipelineNameError !== undefined} > = ({ error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.FEATURE_INFLUENCE_THRESHOLD]} > setFormState({ featureInfluenceThreshold: e.target.value === '' ? undefined : +e.target.value, @@ -440,7 +444,7 @@ export const AdvancedStepForm: FC = ({ onChange={(e) => setFormState({ randomizeSeed: e.target.value === '' ? undefined : +e.target.value }) } - isInvalid={randomizeSeed !== undefined && typeof randomizeSeed !== 'number'} + isInvalid={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.RANDOMIZE_SEED] !== undefined} value={getNumberValue(randomizeSeed)} step={1} /> @@ -510,7 +514,7 @@ export const AdvancedStepForm: FC = ({ setNumTopClassesSelectedOptions(selectedOptions); }} isClearable={true} - isInvalid={selectedNumTopClasses !== undefined && selectedNumTopClasses < -1} + isInvalid={selectedNumTopClasses === 0 || selectedNumTopClassesIsInvalid} data-test-subj="mlAnalyticsCreateJobWizardnumTopClassesInput" /> @@ -580,6 +584,7 @@ export const AdvancedStepForm: FC = ({ } > = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.LAMBDA]} > = ({ actions, state, advancedParamErrors onChange={(e) => setFormState({ maxTrees: e.target.value === '' ? undefined : +e.target.value }) } - isInvalid={maxTrees !== undefined && !Number.isInteger(maxTrees)} + isInvalid={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.MAX_TREES] !== undefined} step={1} min={1} max={MAX_TREES_LIMIT} @@ -108,6 +109,7 @@ export const HyperParameters: FC = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.GAMMA]} > = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.ETA]} > = ({ actions, state, advancedParamErrors }) } isInvalid={ - featureBagFraction !== undefined && - (featureBagFraction > 1 || featureBagFraction <= 0) + advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.FEATURE_BAG_FRACTION] !== undefined } step={0.001} max={1} @@ -198,6 +200,7 @@ export const HyperParameters: FC = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.ALPHA]} > = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.DOWNSAMPLE_FACTOR]} > = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.ETA_GROWTH_RATE_PER_TREE]} > = ({ actions, state, advancedParamErrors } > = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.SOFT_TREE_DEPTH_LIMIT]} > = ({ actions, state, advancedParamErrors error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.SOFT_TREE_DEPTH_TOLERANCE]} > = ({ actions, state, advancedPara error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.METHOD]} > ({ value: outlierMethod, text: outlierMethod, @@ -67,6 +68,7 @@ export const OutlierHyperParameters: FC = ({ actions, state, advancedPara error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.N_NEIGHBORS]} > = ({ actions, state, advancedPara error={advancedParamErrors[ANALYSIS_ADVANCED_FIELDS.OUTLIER_FRACTION]} > = ({ aria-label={i18n.translate('xpack.ml.dataframe.analytics.create.jobIdInputAriaLabel', { defaultMessage: 'Choose a unique analytics job ID.', })} - isInvalid={(!jobIdEmpty && !jobIdValid) || jobIdExists || jobIdEmpty} + isInvalid={(!jobIdEmpty && !jobIdValid) || jobIdExists || jobIdInvalidMaxLength} data-test-subj="mlAnalyticsCreateJobFlyoutJobIdInput" /> diff --git a/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_edit/edit_action_flyout.tsx b/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_edit/edit_action_flyout.tsx index 4922ae35e81d5..4a16146c177fe 100644 --- a/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_edit/edit_action_flyout.tsx +++ b/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_edit/edit_action_flyout.tsx @@ -279,6 +279,7 @@ export const EditActionFlyout: FC> = ({ closeFlyout, item } } > ) => { let query = e.target.value; diff --git a/x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_context_menu.tsx b/x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_context_menu.tsx index 9a25224463695..dc94a28d4f1ac 100644 --- a/x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_context_menu.tsx +++ b/x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_context_menu.tsx @@ -234,6 +234,7 @@ export const AnomalyContextMenu: FC = ({ } > = ({ isInvalid={!isNewCalendarIdValid} > = ({ } > > = ({ isInvalid={jobIdValidationError !== ''} > { @@ -266,6 +267,7 @@ export const JobDetails: FC> = ({ isInvalid={bucketSpanValidationError !== ''} > { diff --git a/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx b/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx index a6a1558c865a5..e8ac369bf67c4 100644 --- a/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx +++ b/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx @@ -128,7 +128,7 @@ export const PacksComboBoxField = ({ describedByIds={idAria ? [idAria] : undefined} {...rest} > - + placeholder={i18n.translate('xpack.osquery.packs.dropdown.searchFieldPlaceholder', { defaultMessage: `Search for a pack to run`, })} diff --git a/x-pack/platform/plugins/shared/osquery/public/packs/queries/ecs_mapping_editor_field.tsx b/x-pack/platform/plugins/shared/osquery/public/packs/queries/ecs_mapping_editor_field.tsx index 57636e1a4dba9..cb2fafbfe2f59 100644 --- a/x-pack/platform/plugins/shared/osquery/public/packs/queries/ecs_mapping_editor_field.tsx +++ b/x-pack/platform/plugins/shared/osquery/public/packs/queries/ecs_mapping_editor_field.tsx @@ -247,6 +247,7 @@ const ECSComboboxFieldComponent: React.FC = ({ isDisabled={euiFieldProps.isDisabled} > = ({ fullWidth > 0} fullWidth data-test-subj="preconfiguredIndexToUse" prepend={ALERT_HISTORY_PREFIX} diff --git a/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/swimlane/steps/swimlane_fields.tsx b/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/swimlane/steps/swimlane_fields.tsx index 9a4f45eaa1ce5..6e60cab78fc48 100644 --- a/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/swimlane/steps/swimlane_fields.tsx +++ b/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/swimlane/steps/swimlane_fields.tsx @@ -126,6 +126,7 @@ const MappingField: React.FC<{ return ( { diff --git a/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/xsoar/params.tsx b/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/xsoar/params.tsx index e044ea5c46754..2c5ca467d53ae 100644 --- a/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/xsoar/params.tsx +++ b/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/xsoar/params.tsx @@ -203,6 +203,7 @@ const XSOARParamsFields: React.FunctionComponent updateDatasetName(event.target.value)} - isInvalid={hasErrors(errors?.fields?.datasets?.[0].name) && touchedFields.datasets} + isInvalid={hasErrors(errors?.fields?.datasets?.[0]?.name) && touchedFields.datasets} max={100} data-test-subj={ testSubjects?.datasetName ?? 'customIntegrationsPackageCreateFormDatasetNameInput' diff --git a/x-pack/solutions/observability/plugins/apm/public/components/fleet_integration/apm_agents/runtime_attachment/java_agent_version_input.tsx b/x-pack/solutions/observability/plugins/apm/public/components/fleet_integration/apm_agents/runtime_attachment/java_agent_version_input.tsx index 020ff53a1c4a8..21c2ab288ea1a 100644 --- a/x-pack/solutions/observability/plugins/apm/public/components/fleet_integration/apm_agents/runtime_attachment/java_agent_version_input.tsx +++ b/x-pack/solutions/observability/plugins/apm/public/components/fleet_integration/apm_agents/runtime_attachment/java_agent_version_input.tsx @@ -80,6 +80,7 @@ export function JavaAgentVersionInput({ isValid, version, onChange }: Props) { } > = ({ error={errors.field as string} > 0} compressed fullWidth isClearable={false} @@ -259,6 +260,7 @@ export const Criterion: React.FC = ({ error={errors.comparator as string} > 0} data-test-subj="infraCriterionSelect" compressed hasNoInitialSelection={criterion.comparator == null} diff --git a/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx b/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx index 9795fde2e11fa..b17024b1971f4 100644 --- a/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx +++ b/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx @@ -100,6 +100,7 @@ export const Threshold: React.FC = ({ comparator, value, updateThreshold, error={errors.value as string[]} > 0} data-test-subj="infraThresholdFieldNumber" compressed value={value} diff --git a/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx b/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx index fac34034caf93..812bce63b4b61 100644 --- a/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx +++ b/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx @@ -130,6 +130,7 @@ export const IndicesConfigurationPanel = ({ } > } > = ({ } > = ({ connector }) => isInvalid={!!error} > = ({ } > = ({ )} fullWidth disabled={disabled} - isInvalid={false} + isInvalid={formInvalid} value={rawName} onChange={handleNameChange} autoFocus diff --git a/x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/configure_pipeline.tsx b/x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/configure_pipeline.tsx index cc318831555af..9947ed27f37b0 100644 --- a/x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/configure_pipeline.tsx +++ b/x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/pipelines/ml_inference/configure_pipeline.tsx @@ -94,6 +94,7 @@ export const ConfigurePipeline: React.FC = () => { isInvalid={nameError} > = ({ })} > = ({ isInvalid={!!addFieldFormErrors} > { } > { diff --git a/x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_flyout/query_rule_metadata_editor.tsx b/x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_flyout/query_rule_metadata_editor.tsx index e1e897269ed7e..0b2e9e84bc436 100644 --- a/x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_flyout/query_rule_metadata_editor.tsx +++ b/x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_flyout/query_rule_metadata_editor.tsx @@ -55,6 +55,7 @@ export const QueryRuleMetadataEditor: React.FC = ( error={error?.metadata ? error.metadata.message : undefined} > = ( error={error?.values ? error.values.message : undefined} > { diff --git a/x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_index_name_form.tsx b/x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_index_name_form.tsx index ffa1cbd7525c7..759a18f7f3c84 100644 --- a/x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_index_name_form.tsx +++ b/x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_index_name_form.tsx @@ -57,6 +57,7 @@ export const ConnectorIndexNameForm: React.FC = ({ })} > ( fullWidth > ( data-test-subj="hostIsolationExceptions-form-name-input-formRow" > ( data-test-subj="hostIsolationExceptions-form-ip-input-formRow" > ( error={validationResult.result.name?.errors} > ( fullWidth > 0} id="lookupsFilePicker" ref={filePickerRef as React.Ref>} fullWidth diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/macros/sub_steps/macros_file_upload/macros_file_upload.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/macros/sub_steps/macros_file_upload/macros_file_upload.tsx index 49940a4eb9b02..04808b0f1bf6a 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/macros/sub_steps/macros_file_upload/macros_file_upload.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/macros/sub_steps/macros_file_upload/macros_file_upload.tsx @@ -74,6 +74,7 @@ export const MacrosFileUpload = React.memo( fullWidth > >} fullWidth diff --git a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/rules/sub_steps/rules_file_upload/rules_file_upload.tsx b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/rules/sub_steps/rules_file_upload/rules_file_upload.tsx index c02076c929156..8bb98488fab65 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/rules/sub_steps/rules_file_upload/rules_file_upload.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/siem_migrations/rules/components/data_input_flyout/steps/rules/sub_steps/rules_file_upload/rules_file_upload.tsx @@ -75,6 +75,7 @@ export const RulesFileUpload = React.memo( >} fullWidth From ef9d086b99ee77b5b9689166792aab830146e785 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Mon, 7 Jul 2025 15:44:23 +0300 Subject: [PATCH 2/8] fix issues --- .../osquery/public/live_queries/form/packs_combobox_field.tsx | 3 ++- .../log_threshold/components/expression_editor/criterion.tsx | 2 ++ .../log_threshold/components/expression_editor/threshold.tsx | 1 + .../pages/metrics/settings/indices_configuration_panel.tsx | 2 +- .../public/pages/metrics/settings/name_configuration_panel.tsx | 2 +- 5 files changed, 7 insertions(+), 3 deletions(-) diff --git a/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx b/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx index e8ac369bf67c4..8e4ad24c4f54a 100644 --- a/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx +++ b/x-pack/platform/plugins/shared/osquery/public/live_queries/form/packs_combobox_field.tsx @@ -128,7 +128,8 @@ export const PacksComboBoxField = ({ describedByIds={idAria ? [idAria] : undefined} {...rest} > - + = ({ error={errors.field as string} > 0} compressed fullWidth @@ -260,6 +261,7 @@ export const Criterion: React.FC = ({ error={errors.comparator as string} > 0} data-test-subj="infraCriterionSelect" compressed diff --git a/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx b/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx index b17024b1971f4..8e15f5838d0ee 100644 --- a/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx +++ b/x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/expression_editor/threshold.tsx @@ -100,6 +100,7 @@ export const Threshold: React.FC = ({ comparator, value, updateThreshold, error={errors.value as string[]} > 0} data-test-subj="infraThresholdFieldNumber" compressed diff --git a/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx b/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx index 812bce63b4b61..018fe100d589b 100644 --- a/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx +++ b/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/indices_configuration_panel.tsx @@ -130,13 +130,13 @@ export const IndicesConfigurationPanel = ({ } > {isMetricAliasChanged && numberOfInfraRules > 0 && ( diff --git a/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/name_configuration_panel.tsx b/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/name_configuration_panel.tsx index 244bd1606b0de..49d9aa3fde91c 100644 --- a/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/name_configuration_panel.tsx +++ b/x-pack/solutions/observability/plugins/infra/public/pages/metrics/settings/name_configuration_panel.tsx @@ -60,13 +60,13 @@ export const NameConfigurationPanel = ({ } > From 8fa5ecbe9c447e14ed06be852108b7d15a7051f0 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Mon, 7 Jul 2025 19:15:07 +0300 Subject: [PATCH 3/8] fix jest --- .../edit/calendar_form/__snapshots__/calendar_form.test.js.snap | 1 + .../public/components/synonym_sets/create_new_set_modal.tsx | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/platform/plugins/shared/ml/public/application/settings/calendars/edit/calendar_form/__snapshots__/calendar_form.test.js.snap b/x-pack/platform/plugins/shared/ml/public/application/settings/calendars/edit/calendar_form/__snapshots__/calendar_form.test.js.snap index e70c43b383f98..6514ea353e36e 100644 --- a/x-pack/platform/plugins/shared/ml/public/application/settings/calendars/edit/calendar_form/__snapshots__/calendar_form.test.js.snap +++ b/x-pack/platform/plugins/shared/ml/public/application/settings/calendars/edit/calendar_form/__snapshots__/calendar_form.test.js.snap @@ -29,6 +29,7 @@ exports[`CalendarForm Renders calendar form 1`] = ` { From 9d24d79358c2180aa8f65ba8936a1bea3138d7a3 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Fri, 11 Jul 2025 12:34:49 +0300 Subject: [PATCH 4/8] update /vis_default_editor/public/components/options/required_num.tsx --- .../public/components/options/required_number_input.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/platform/plugins/private/vis_default_editor/public/components/options/required_number_input.tsx b/src/platform/plugins/private/vis_default_editor/public/components/options/required_number_input.tsx index 4dc857215df44..845fa3eabd254 100644 --- a/src/platform/plugins/private/vis_default_editor/public/components/options/required_number_input.tsx +++ b/src/platform/plugins/private/vis_default_editor/public/components/options/required_number_input.tsx @@ -13,7 +13,6 @@ import { EuiFormRow, EuiFieldNumber } from '@elastic/eui'; interface NumberInputOptionProps { disabled?: boolean; error?: ReactNode; - isInvalid?: boolean; label?: React.ReactNode; max?: number; min?: number; @@ -34,7 +33,6 @@ interface NumberInputOptionProps { function RequiredNumberInputOption({ disabled, error, - isInvalid, label, max, min, @@ -60,14 +58,14 @@ function RequiredNumberInputOption({ ); return ( - + Date: Fri, 11 Jul 2025 19:17:36 +0300 Subject: [PATCH 5/8] Update range_input_field.tsx --- .../shared/lens/public/shared_components/range_input_field.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/platform/plugins/shared/lens/public/shared_components/range_input_field.tsx b/x-pack/platform/plugins/shared/lens/public/shared_components/range_input_field.tsx index e9a5a8b797925..cf84963c02a83 100644 --- a/x-pack/platform/plugins/shared/lens/public/shared_components/range_input_field.tsx +++ b/x-pack/platform/plugins/shared/lens/public/shared_components/range_input_field.tsx @@ -68,6 +68,7 @@ export function RangeInputField({ Date: Tue, 15 Jul 2025 12:50:07 +0300 Subject: [PATCH 6/8] Update x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com> --- .../components/details_step/details_step_form.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx b/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx index 015f55f9a90bc..3a61139164245 100644 --- a/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx +++ b/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx @@ -215,7 +215,7 @@ export const DetailsStepForm: FC = ({ aria-label={i18n.translate('xpack.ml.dataframe.analytics.create.jobIdInputAriaLabel', { defaultMessage: 'Choose a unique analytics job ID.', })} - isInvalid={(!jobIdEmpty && !jobIdValid) || jobIdExists || jobIdInvalidMaxLength} + isInvalid={(!jobIdEmpty && !jobIdValid) || jobIdExists || jobIdInvalidMaxLength || jobIdEmpty} data-test-subj="mlAnalyticsCreateJobFlyoutJobIdInput" /> From cc01d7cd5165da1fb0936061b22bc44192cee66c Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Tue, 15 Jul 2025 10:13:04 +0000 Subject: [PATCH 7/8] [CI] Auto-commit changed files from 'node scripts/eslint_all_files --no-cache --fix' --- .../components/details_step/details_step_form.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx b/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx index 3a61139164245..b5c39dea3370d 100644 --- a/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx +++ b/x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx @@ -215,7 +215,9 @@ export const DetailsStepForm: FC = ({ aria-label={i18n.translate('xpack.ml.dataframe.analytics.create.jobIdInputAriaLabel', { defaultMessage: 'Choose a unique analytics job ID.', })} - isInvalid={(!jobIdEmpty && !jobIdValid) || jobIdExists || jobIdInvalidMaxLength || jobIdEmpty} + isInvalid={ + (!jobIdEmpty && !jobIdValid) || jobIdExists || jobIdInvalidMaxLength || jobIdEmpty + } data-test-subj="mlAnalyticsCreateJobFlyoutJobIdInput" /> From 211c97b00bbb835d8e0d30ca89b8c1aed541d44f Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Wed, 16 Jul 2025 15:36:17 +0300 Subject: [PATCH 8/8] fix typecheck --- .../response-ops/rule_form/src/rule_details/rule_details.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/platform/packages/shared/response-ops/rule_form/src/rule_details/rule_details.tsx b/src/platform/packages/shared/response-ops/rule_form/src/rule_details/rule_details.tsx index 197a8f895d60f..efacd3ff24030 100644 --- a/src/platform/packages/shared/response-ops/rule_form/src/rule_details/rule_details.tsx +++ b/src/platform/packages/shared/response-ops/rule_form/src/rule_details/rule_details.tsx @@ -109,7 +109,6 @@ export const RuleDetails = () => { error={baseErrors?.name} >