diff --git a/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/overview_tab.tsx b/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/overview_tab.tsx index 11b2162c1ebc8..bfc6462fc9fc0 100644 --- a/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/overview_tab.tsx +++ b/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/overview_tab.tsx @@ -18,9 +18,16 @@ import { EuiPanel, EuiSpacer, EuiText, + EuiTitle, + useEuiTheme, } from '@elastic/eui'; import React, { useMemo } from 'react'; -import type { EuiDescriptionListProps, EuiAccordionProps, EuiBasicTableColumn } from '@elastic/eui'; +import type { + EuiDescriptionListProps, + EuiAccordionProps, + EuiBasicTableColumn, + EuiThemeComputed, +} from '@elastic/eui'; import { i18n } from '@kbn/i18n'; import { CDR_MISCONFIGURATIONS_INDEX_PATTERN, @@ -82,9 +89,21 @@ const renderTableField = (value: string) => { return {EMPTY_VALUE}; } - return Array.isArray(value) ? ( - items={value} field="" object={{}} renderItem={renderValue} /> - ) : ( + if (Array.isArray(value)) { + return ( + + items={value} + field="" + object={{}} + renderItem={renderValue} + {...(value.length === 1 + ? { firstItemRenderer: (item) => } + : {})} + /> + ); + } + + return ( <> > @@ -138,40 +157,74 @@ const getResourceList = (data: CspFinding) => [ const getDetailsList = ( data: CspFinding, ruleFlyoutLink?: string, - discoverDataViewLink?: string + discoverDataViewLink?: string, + euiTheme?: EuiThemeComputed<{}> ) => [ { title: ( - <> - - - {i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.ruleDescription', { - defaultMessage: 'Rule Description', - })} - - - - - {i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.showRuleDetails', { - defaultMessage: 'Show rule details', + + + + + {i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.ruleDescription', { + defaultMessage: 'Rule Description', })} - - - - > + + + + + + + + + + {i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.showRuleDetails', { + defaultMessage: 'Show rule details', + })} + + + + + + + ), + description: data.rule?.description ? ( + {data.rule?.description} + ) : ( + EMPTY_VALUE ), - description: data.rule?.description ? {data.rule?.description} : EMPTY_VALUE, }, { - title: i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.alertsTitle', { - defaultMessage: 'Alerts', - }), + title: ( + + + {i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.alertsTitle', { + defaultMessage: 'Alerts', + })} + + + ), description: , }, { - title: i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.dataViewTitle', { - defaultMessage: 'Data View', - }), + title: ( + + + {i18n.translate('xpack.csp.findings.findingsFlyout.overviewTab.dataViewTitle', { + defaultMessage: 'Data View', + })} + + + ), description: discoverDataViewLink ? ( {CDR_MISCONFIGURATIONS_INDEX_PATTERN} ) : ( @@ -229,6 +282,7 @@ export const OverviewTab = ({ }) => { const { discover } = useKibana().services; const cdrMisconfigurationsDataView = useDataView(CDR_MISCONFIGURATIONS_DATA_VIEW_ID_PREFIX); + const { euiTheme } = useEuiTheme(); // link will navigate to our dataview in discover, filtered by the data source of the finding const discoverDataViewLink = useMemo( @@ -265,7 +319,7 @@ export const OverviewTab = ({ defaultMessage: 'About', }), id: 'detailsAccordion', - listItems: getDetailsList(data, ruleFlyoutLink, discoverDataViewLink), + listItems: getDetailsList(data, ruleFlyoutLink, discoverDataViewLink, euiTheme), }, { initialIsOpen: true, @@ -294,7 +348,7 @@ export const OverviewTab = ({ listItems: getEvidenceList(data), }, ].filter(truthy), - [data, discoverDataViewLink, hasEvidence, ruleFlyoutLink] + [data, discoverDataViewLink, euiTheme, hasEvidence, ruleFlyoutLink] ); return ( diff --git a/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx b/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx index 4df65003f9300..209276c339cfe 100644 --- a/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx +++ b/x-pack/solutions/security/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_right/header.tsx @@ -93,22 +93,20 @@ export const FindingsVulnerabilityFlyoutHeader = ({ href={referenceLink} target="_blank" color="primary" - css={{ - fontWeight: euiTheme.font.weight.semiBold, - }} + css={css` + display: flex; + align-items: center; + svg { + width: ${euiTheme.base}px; + height: ${euiTheme.base}px; + } + `} > {id} ) : ( - - {id} - + {id} ); }; @@ -121,10 +119,10 @@ export const FindingsVulnerabilityFlyoutHeader = ({ > {renderVulnerabilityId()}