From 75c8e530b0b1f33277c64129d2128b1e48bcf0e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Georgiana-Andreea=20Onolea=C8=9B=C4=83?=
 <georgiana.onoleata@elastic.co>
Date: Tue, 29 Apr 2025 10:27:18 +0300
Subject: [PATCH] [ResponseOps][Cases]Allow dashes in host names in Observables
 (#219038)

Closes https://github.com/elastic/kibana/issues/218946

## Summary

- changed the GENERIC_REGEX to allow `-`

<img width="488" alt="Screenshot 2025-04-24 at 10 31 00"
src="https://github.com/user-attachments/assets/57841c74-9e6c-4600-81f4-8b454d1ddec1"
/>

(cherry picked from commit d0d08b0bdb8f178e88063e0a05467f78d4d8b99f)

# Conflicts:
#	x-pack/platform/plugins/shared/cases/common/observables/validators.test.ts
#	x-pack/platform/plugins/shared/cases/common/observables/validators.ts
---
 .../public/components/observables/fields_config.test.ts   | 8 ++++++++
 .../cases/public/components/observables/fields_config.ts  | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.test.ts b/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.test.ts
index 348b5b1ca27b5..3d832cb63003d 100644
--- a/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.test.ts
+++ b/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.test.ts
@@ -75,6 +75,14 @@ describe('genericValidator', () => {
     } as Parameters<ValidationFunc>[0]);
     expect(result).toBeUndefined();
   });
+
+  it('should return undefined if the value contains dashes', () => {
+    const result = genericValidator({
+      value: 'valid-value',
+      path: 'generic',
+    } as Parameters<ValidationFunc>[0]);
+    expect(result).toBeUndefined();
+  });
 });
 
 describe('domainValidator', () => {
diff --git a/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.ts b/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.ts
index b858bb1251bb2..ce196d8088044 100644
--- a/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.ts
+++ b/x-pack/platform/plugins/shared/cases/public/components/observables/fields_config.ts
@@ -28,7 +28,7 @@ export const normalizeValueType = (value: string): keyof typeof fieldsConfig.val
 };
 
 const DOMAIN_REGEX = /^(?!-)[A-Za-z0-9-]{1,63}(?<!-)\.[A-Za-z]{2,}$/;
-const GENERIC_REGEX = /^[a-zA-Z0-9._:/\\]+$/;
+const GENERIC_REGEX = /^[a-zA-Z0-9._:/\\-]+$/;
 
 const notStringError = (path: string) => ({
   code: 'ERR_NOT_STRING',