From d15f67b9a5ccf2c152f89c8823ccb1d72c8a1492 Mon Sep 17 00:00:00 2001 From: Kevin Delemme Date: Fri, 30 May 2025 13:39:15 -0400 Subject: [PATCH 1/4] Add fields in pipeline and install pipeline on non breaking update --- .../observability/plugins/slo/common/constants.ts | 2 +- .../component_templates/sli_mappings_template.ts | 11 +++++++++++ .../ingest_templates/sli_pipeline_template.ts | 12 ++++++++++++ .../plugins/slo/server/services/update_slo.ts | 15 ++++++++++++++- 4 files changed, 38 insertions(+), 2 deletions(-) diff --git a/x-pack/solutions/observability/plugins/slo/common/constants.ts b/x-pack/solutions/observability/plugins/slo/common/constants.ts index 3b806ac71f808..dadd3fbf02336 100644 --- a/x-pack/solutions/observability/plugins/slo/common/constants.ts +++ b/x-pack/solutions/observability/plugins/slo/common/constants.ts @@ -56,7 +56,7 @@ export const SUPPRESSED_PRIORITY_ACTION = { export const LOCK_ID_RESOURCE_INSTALLER = 'slo:resource_installer'; export const SLO_MODEL_VERSION = 2; -export const SLO_RESOURCES_VERSION = 3.4; +export const SLO_RESOURCES_VERSION = 3.5; export const SLO_RESOURCES_VERSION_MAJOR = 3; export const SLI_COMPONENT_TEMPLATE_MAPPINGS_NAME = '.slo-observability.sli-mappings'; diff --git a/x-pack/solutions/observability/plugins/slo/server/assets/component_templates/sli_mappings_template.ts b/x-pack/solutions/observability/plugins/slo/server/assets/component_templates/sli_mappings_template.ts index 8e8051a8b887c..06c760570d2e7 100644 --- a/x-pack/solutions/observability/plugins/slo/server/assets/component_templates/sli_mappings_template.ts +++ b/x-pack/solutions/observability/plugins/slo/server/assets/component_templates/sli_mappings_template.ts @@ -86,6 +86,17 @@ export const SLI_MAPPINGS_TEMPLATE: ClusterPutComponentTemplateRequest = { type: 'keyword', ignore_above: 256, }, + name: { + type: 'text', + fields: { + keyword: { + type: 'keyword', + }, + }, + }, + tags: { + type: 'keyword', + }, revision: { type: 'long', }, diff --git a/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/sli_pipeline_template.ts b/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/sli_pipeline_template.ts index fa66e9dc72f94..4ef0295583b2c 100644 --- a/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/sli_pipeline_template.ts +++ b/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/sli_pipeline_template.ts @@ -39,6 +39,18 @@ export const getSLIPipelineTemplate = (slo: SLODefinition, spaceId: string) => { value: slo.id, }, }, + { + set: { + field: 'slo.name', + value: slo.name, + }, + }, + { + set: { + field: 'slo.tags', + value: slo.tags, + }, + }, { set: { field: 'slo.revision', diff --git a/x-pack/solutions/observability/plugins/slo/server/services/update_slo.ts b/x-pack/solutions/observability/plugins/slo/server/services/update_slo.ts index c280ec9a91c38..7ef8d578dac69 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/update_slo.ts +++ b/x-pack/solutions/observability/plugins/slo/server/services/update_slo.ts @@ -75,8 +75,21 @@ export class UpdateSLO { rollbackOperations.push(() => this.repository.update(originalSlo)); if (!requireRevisionBump) { - // we only have to update the summary pipeline to include the non-breaking changes (name, desc, tags, ...) in the summary index + // we only have to update the rollup and summary pipelines to include the non-breaking changes (name, desc, tags, ...) in the summary index try { + await retryTransientEsErrors( + () => + this.scopedClusterClient.asSecondaryAuthUser.ingest.putPipeline( + getSLIPipelineTemplate(updatedSlo, this.spaceId) + ), + { logger: this.logger } + ); + rollbackOperations.push(() => + this.scopedClusterClient.asSecondaryAuthUser.ingest.deletePipeline( + { id: getSLOPipelineId(updatedSlo.id, updatedSlo.revision) }, + { ignore: [404] } + ) + ); await retryTransientEsErrors( () => this.scopedClusterClient.asSecondaryAuthUser.ingest.putPipeline( From 247b0b601cd68c6829ac65231e2edd2e4f463cdc Mon Sep 17 00:00:00 2001 From: Kevin Delemme Date: Fri, 30 May 2025 14:54:18 -0400 Subject: [PATCH 2/4] Update tests --- .../sli_pipeline_template.test.ts.snap | 38 +++++++++++++++++-- .../slo_transform_template.test.ts | 2 +- .../__snapshots__/create_slo.test.ts.snap | 18 +++++++-- .../__snapshots__/reset_slo.test.ts.snap | 23 +++++++++-- .../clean_up_temp_summary.test.ts.snap | 4 +- .../__snapshots__/occurrences.test.ts.snap | 18 ++++----- .../timeslices_calendar_aligned.test.ts.snap | 6 +-- .../timeslices_rolling.test.ts.snap | 6 +-- .../apm_transaction_duration.test.ts.snap | 12 +++--- .../apm_transaction_error_rate.test.ts.snap | 12 +++--- .../__snapshots__/histogram.test.ts.snap | 12 +++--- .../__snapshots__/kql_custom.test.ts.snap | 12 +++--- .../__snapshots__/metric_custom.test.ts.snap | 8 ++-- .../synthetics_availability.test.ts.snap | 4 +- .../timeslice_metric.test.ts.snap | 8 ++-- 15 files changed, 120 insertions(+), 63 deletions(-) diff --git a/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/__snapshots__/sli_pipeline_template.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/__snapshots__/sli_pipeline_template.test.ts.snap index 7c06406af7522..2e55fc0681140 100644 --- a/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/__snapshots__/sli_pipeline_template.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/__snapshots__/sli_pipeline_template.test.ts.snap @@ -6,7 +6,7 @@ Object { "description": "Ingest pipeline for SLO rollup data", "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "description": "Ingest pipeline for SLO rollup data [id: irrelevant, revision: 1]", "id": ".slo-observability.sli.pipeline-irrelevant-1", @@ -29,6 +29,21 @@ Object { "value": "irrelevant", }, }, + Object { + "set": Object { + "field": "slo.name", + "value": "irrelevant", + }, + }, + Object { + "set": Object { + "field": "slo.tags", + "value": Array [ + "critical", + "k8s", + ], + }, + }, Object { "set": Object { "field": "slo.revision", @@ -50,7 +65,7 @@ Object { ], "date_rounding": "M", "field": "@timestamp", - "index_name_prefix": ".slo-observability.sli-v3.4.", + "index_name_prefix": ".slo-observability.sli-v3.5.", }, }, Object { @@ -85,7 +100,7 @@ Object { "description": "Ingest pipeline for SLO rollup data", "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "description": "Ingest pipeline for SLO rollup data [id: irrelevant, revision: 1]", "id": ".slo-observability.sli.pipeline-irrelevant-1", @@ -108,6 +123,21 @@ Object { "value": "irrelevant", }, }, + Object { + "set": Object { + "field": "slo.name", + "value": "irrelevant", + }, + }, + Object { + "set": Object { + "field": "slo.tags", + "value": Array [ + "critical", + "k8s", + ], + }, + }, Object { "set": Object { "field": "slo.revision", @@ -129,7 +159,7 @@ Object { ], "date_rounding": "M", "field": "@timestamp", - "index_name_prefix": ".slo-observability.sli-v3.4.", + "index_name_prefix": ".slo-observability.sli-v3.5.", }, }, Object { diff --git a/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts b/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts index a8eeb411af238..07108b12e6e1c 100644 --- a/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts +++ b/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts @@ -143,7 +143,7 @@ describe('slo transform template', () => { }, defer_validation: true, _meta: { - version: 3.4, + version: 3.5, managed: true, managed_by: 'observability', }, diff --git a/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/create_slo.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/create_slo.test.ts.snap index cf1fbd5c57391..9ffcad31a9e4d 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/create_slo.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/create_slo.test.ts.snap @@ -7,7 +7,7 @@ Array [ "description": "Ingest pipeline for SLO rollup data", "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "description": "Ingest pipeline for SLO rollup data [id: unique-id, revision: 1]", "id": ".slo-observability.sli.pipeline-unique-id-1", @@ -30,6 +30,18 @@ Array [ "value": "unique-id", }, }, + Object { + "set": Object { + "field": "slo.name", + "value": "irrelevant", + }, + }, + Object { + "set": Object { + "field": "slo.tags", + "value": Array [], + }, + }, Object { "set": Object { "field": "slo.revision", @@ -51,7 +63,7 @@ Array [ ], "date_rounding": "M", "field": "@timestamp", - "index_name_prefix": ".slo-observability.sli-v3.4.", + "index_name_prefix": ".slo-observability.sli-v3.5.", }, }, Object { @@ -168,7 +180,7 @@ Array [ }, }, "id": "slo-unique-id", - "index": ".slo-observability.summary-v3.4.temp", + "index": ".slo-observability.summary-v3.5.temp", "refresh": true, }, ] diff --git a/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/reset_slo.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/reset_slo.test.ts.snap index 7b0b4559eda0a..127a74fc38055 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/reset_slo.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/__snapshots__/reset_slo.test.ts.snap @@ -177,7 +177,7 @@ exports[`ResetSLO happy path resets all associated resources 6`] = ` "description": "Ingest pipeline for SLO rollup data", "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "description": "Ingest pipeline for SLO rollup data [id: irrelevant, revision: 1]", "id": ".slo-observability.sli.pipeline-irrelevant-1", @@ -200,6 +200,21 @@ exports[`ResetSLO happy path resets all associated resources 6`] = ` "value": "irrelevant", }, }, + Object { + "set": Object { + "field": "slo.name", + "value": "irrelevant", + }, + }, + Object { + "set": Object { + "field": "slo.tags", + "value": Array [ + "critical", + "k8s", + ], + }, + }, Object { "set": Object { "field": "slo.revision", @@ -221,7 +236,7 @@ exports[`ResetSLO happy path resets all associated resources 6`] = ` ], "date_rounding": "M", "field": "@timestamp", - "index_name_prefix": ".slo-observability.sli-v3.4.", + "index_name_prefix": ".slo-observability.sli-v3.5.", }, }, Object { @@ -255,7 +270,7 @@ exports[`ResetSLO happy path resets all associated resources 6`] = ` "description": "Ingest pipeline for SLO summary data [id: irrelevant, revision: 1]", "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "description": "Ingest pipeline for SLO summary data [id: irrelevant, revision: 1]", "id": ".slo-observability.summary.pipeline-irrelevant-1", @@ -710,7 +725,7 @@ exports[`ResetSLO happy path resets all associated resources 9`] = ` }, }, "id": "slo-irrelevant", - "index": ".slo-observability.summary-v3.4.temp", + "index": ".slo-observability.summary-v3.5.temp", "refresh": true, }, ], diff --git a/x-pack/solutions/observability/plugins/slo/server/services/management/__snapshots__/clean_up_temp_summary.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/management/__snapshots__/clean_up_temp_summary.test.ts.snap index dfb343c41bf8d..ab8d27818acd3 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/management/__snapshots__/clean_up_temp_summary.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/management/__snapshots__/clean_up_temp_summary.test.ts.snap @@ -6,7 +6,7 @@ exports[`CleanUpTempSummary deletes the duplicated temp documents 1`] = ` Array [ Object { "conflicts": "proceed", - "index": ".slo-observability.summary-v3.4.temp", + "index": ".slo-observability.summary-v3.5.temp", "query": Object { "bool": Object { "minimum_should_match": 1, @@ -45,7 +45,7 @@ exports[`CleanUpTempSummary deletes the duplicated temp documents 1`] = ` Array [ Object { "conflicts": "proceed", - "index": ".slo-observability.summary-v3.4.temp", + "index": ".slo-observability.summary-v3.5.temp", "query": Object { "bool": Object { "minimum_should_match": 1, diff --git a/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/occurrences.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/occurrences.test.ts.snap index 725c9df707040..554c1c40820e5 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/occurrences.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/occurrences.test.ts.snap @@ -5,12 +5,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Summarise the rollup data of SLO: irrelevant [id: irrelevant, revision: 1].", "dest": Object { - "index": ".slo-observability.summary-v3.4", + "index": ".slo-observability.summary-v3.5", "pipeline": ".slo-observability.summary.pipeline-irrelevant-1", }, "frequency": "1m", @@ -212,7 +212,7 @@ Object { "unattended": true, }, "source": Object { - "index": ".slo-observability.sli-v3.4*", + "index": ".slo-observability.sli-v3.5*", "query": Object { "bool": Object { "filter": Array [ @@ -253,12 +253,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Summarise the rollup data of SLO: irrelevant [id: irrelevant, revision: 1].", "dest": Object { - "index": ".slo-observability.summary-v3.4", + "index": ".slo-observability.summary-v3.5", "pipeline": ".slo-observability.summary.pipeline-irrelevant-1", }, "frequency": "1m", @@ -460,7 +460,7 @@ Object { "unattended": true, }, "source": Object { - "index": ".slo-observability.sli-v3.4*", + "index": ".slo-observability.sli-v3.5*", "query": Object { "bool": Object { "filter": Array [ @@ -501,12 +501,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Summarise the rollup data of SLO: irrelevant [id: irrelevant, revision: 1].", "dest": Object { - "index": ".slo-observability.summary-v3.4", + "index": ".slo-observability.summary-v3.5", "pipeline": ".slo-observability.summary.pipeline-irrelevant-1", }, "frequency": "1m", @@ -708,7 +708,7 @@ Object { "unattended": true, }, "source": Object { - "index": ".slo-observability.sli-v3.4*", + "index": ".slo-observability.sli-v3.5*", "query": Object { "bool": Object { "filter": Array [ diff --git a/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_calendar_aligned.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_calendar_aligned.test.ts.snap index 86f300e0bf217..0f2f12ec4e45e 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_calendar_aligned.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_calendar_aligned.test.ts.snap @@ -5,12 +5,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Summarise the rollup data of SLO: irrelevant [id: irrelevant, revision: 1].", "dest": Object { - "index": ".slo-observability.summary-v3.4", + "index": ".slo-observability.summary-v3.5", "pipeline": ".slo-observability.summary.pipeline-irrelevant-1", }, "frequency": "1m", @@ -236,7 +236,7 @@ Object { "unattended": true, }, "source": Object { - "index": ".slo-observability.sli-v3.4*", + "index": ".slo-observability.sli-v3.5*", "query": Object { "bool": Object { "filter": Array [ diff --git a/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_rolling.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_rolling.test.ts.snap index e13acde32200b..1db250227ccb5 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_rolling.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/summary_transform_generator/generators/__snapshots__/timeslices_rolling.test.ts.snap @@ -5,12 +5,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Summarise the rollup data of SLO: irrelevant [id: irrelevant, revision: 1].", "dest": Object { - "index": ".slo-observability.summary-v3.4", + "index": ".slo-observability.summary-v3.5", "pipeline": ".slo-observability.summary.pipeline-irrelevant-1", }, "frequency": "1m", @@ -212,7 +212,7 @@ Object { "unattended": true, }, "source": Object { - "index": ".slo-observability.sli-v3.4*", + "index": ".slo-observability.sli-v3.5*", "query": Object { "bool": Object { "filter": Array [ diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap index ea89857a161d7..383ef4a0e7bd9 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_duration.test.ts.snap @@ -369,12 +369,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -517,12 +517,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -665,12 +665,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap index ac38a15c9122a..39f5a33619559 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/apm_transaction_error_rate.test.ts.snap @@ -345,12 +345,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -480,12 +480,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -615,12 +615,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/histogram.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/histogram.test.ts.snap index 09fb74df7e88a..d99c94dfc9aa4 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/histogram.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/histogram.test.ts.snap @@ -86,12 +86,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -224,12 +224,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -362,12 +362,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/kql_custom.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/kql_custom.test.ts.snap index 7bffdd0190d7c..b09959b114cf0 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/kql_custom.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/kql_custom.test.ts.snap @@ -145,12 +145,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -265,12 +265,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -385,12 +385,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/metric_custom.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/metric_custom.test.ts.snap index dbfdb75dc4234..fae305f2849f3 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/metric_custom.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/metric_custom.test.ts.snap @@ -126,12 +126,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -275,12 +275,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/synthetics_availability.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/synthetics_availability.test.ts.snap index 68d20e9f68545..0b589e43fca98 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/synthetics_availability.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/synthetics_availability.test.ts.snap @@ -5,12 +5,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", diff --git a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/timeslice_metric.test.ts.snap b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/timeslice_metric.test.ts.snap index f9168e52ec5ee..c1e972d42bcda 100644 --- a/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/timeslice_metric.test.ts.snap +++ b/x-pack/solutions/observability/plugins/slo/server/services/transform_generators/__snapshots__/timeslice_metric.test.ts.snap @@ -42,12 +42,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", @@ -260,12 +260,12 @@ Object { "_meta": Object { "managed": true, "managed_by": "observability", - "version": 3.4, + "version": 3.5, }, "defer_validation": true, "description": "Rolled-up SLI data for SLO: irrelevant [id: irrelevant, revision: 1]", "dest": Object { - "index": ".slo-observability.sli-v3.4", + "index": ".slo-observability.sli-v3.5", "pipeline": ".slo-observability.sli.pipeline-irrelevant-1", }, "frequency": "1m", From 8e78e0a001d6df9a747dcbf99c75f92b6c9966a9 Mon Sep 17 00:00:00 2001 From: Kevin Delemme Date: Fri, 30 May 2025 14:55:39 -0400 Subject: [PATCH 3/4] update tests --- .../apis/observability/slo/create_slo.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts b/x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts index a71c24f5cd9f0..5af00900ff523 100644 --- a/x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts +++ b/x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts @@ -104,7 +104,7 @@ export default function ({ getService }: DeploymentAgnosticFtrProviderContext) { const rollUpTransformResponse = await transformHelper.assertExist(getSLOTransformId(id, 1)); expect(rollUpTransformResponse.transforms[0].source.index).eql(['kbn-data-forge*']); expect(rollUpTransformResponse.transforms[0].dest).eql({ - index: '.slo-observability.sli-v3.4', + index: '.slo-observability.sli-v3.5', pipeline: `.slo-observability.sli.pipeline-${id}-1`, }); expect(rollUpTransformResponse.transforms[0].pivot.group_by).eql({ @@ -116,10 +116,10 @@ export default function ({ getService }: DeploymentAgnosticFtrProviderContext) { getSLOSummaryTransformId(id, 1) ); expect(summaryTransformResponse.transforms[0].source.index).eql([ - '.slo-observability.sli-v3.4*', + '.slo-observability.sli-v3.5*', ]); expect(summaryTransformResponse.transforms[0].dest).eql({ - index: '.slo-observability.summary-v3.4', + index: '.slo-observability.summary-v3.5', pipeline: `.slo-observability.summary.pipeline-${id}-1`, }); }); From 5bad292d5b40e35b23225f7dd7dac502cfd816de Mon Sep 17 00:00:00 2001 From: Kevin Delemme Date: Mon, 9 Jun 2025 13:21:48 -0400 Subject: [PATCH 4/4] Fix test --- .../assets/transform_templates/slo_transform_template.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts b/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts index 07108b12e6e1c..95d8381e8e832 100644 --- a/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts +++ b/x-pack/solutions/observability/plugins/slo/server/assets/transform_templates/slo_transform_template.test.ts @@ -247,7 +247,7 @@ describe('slo transform template', () => { }, defer_validation: true, _meta: { - version: 3.4, + version: 3.5, managed: true, managed_by: 'observability', },