From efd0f490e9e99cd2d9a4308c651930299a5ab288 Mon Sep 17 00:00:00 2001 From: Florian Lehner Date: Wed, 30 Apr 2025 07:56:51 +0200 Subject: [PATCH] [Profiling]: Fix color for Go Frametype (#219524) ## Summary Fixes a bug, where https://github.com/elastic/kibana/pull/215697 added only three colors but four colors are expected. Fixes https://github.com/elastic/kibana/issues/218839 and fixes https://github.com/elastic/elastic-charts/issues/2652 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] ~~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - [ ] ~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [ ] ~~[Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios~~ - [ ] ~~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - [ ] ~~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - [ ] ~~[Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - `release_note:skip` Signed-off-by: Florian Lehner (cherry picked from commit 9cbbf78abe2d542f9b6d1b080f3355552a2724f4) --- .../observability/plugins/profiling/common/frame_type_colors.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts b/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts index 7539ace15b956..bb59c4f7ba5c6 100644 --- a/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts +++ b/x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts @@ -44,7 +44,7 @@ export const FRAME_TYPE_COLOR_MAP = { [FrameType.JavaScript]: [0xcbc3e3, 0xd5cfe8, 0xdfdbee, 0xeae7f3], [FrameType.PHPJIT]: [0xccfc82, 0xd1fc8e, 0xd6fc9b, 0xdbfca7], [FrameType.DotNET]: [0x6c60e1, 0x8075e5, 0x948be9, 0xa8a0ed], - [FrameType.Go]: [0x00add8, 0x31bee0, 0x68cce7], + [FrameType.Go]: [0x00add8, 0x31bee0, 0x68cce7, 0x9cdbed], [FrameType.ErrorFlag]: [0x0, 0x0, 0x0, 0x0], // This is a special case, it's not a real frame type [FrameType.Error]: [0xfd8484, 0xfd9d9d, 0xfeb5b5, 0xfecece], [FrameType.Root]: [RED, RED, RED, RED],