From e72e76f2d0e421ab8dbceb5df61d54c6a2f8f8d1 Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Tue, 22 Apr 2025 13:25:45 +0200 Subject: [PATCH 1/3] chore: update eui package --- package.json | 2 +- src/dev/license_checker/config.ts | 2 +- yarn.lock | 28 ++++++++++++++-------------- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/package.json b/package.json index 470c10ce3eb1d..f12069194b4b2 100644 --- a/package.json +++ b/package.json @@ -123,7 +123,7 @@ "@elastic/ecs": "^8.11.5", "@elastic/elasticsearch": "^8.17.1", "@elastic/ems-client": "8.6.3", - "@elastic/eui": "101.3.0-classic.0", + "@elastic/eui": "101.4.0-amsterdam.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "^1.2.3", "@elastic/numeral": "^2.5.1", diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index 1e903b614978c..e722810a95caa 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -88,7 +88,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.6.3': ['Elastic License 2.0'], - '@elastic/eui@101.2.0-classic.1': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'], + '@elastic/eui@101.4.0-amsterdam.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary '@bufbuild/protobuf@1.2.1': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause) diff --git a/yarn.lock b/yarn.lock index 5cf804a7a6fc0..1a41221cdf9f7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2157,22 +2157,22 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui-theme-common@0.1.0": - version "0.1.0" - resolved "https://registry.yarnpkg.com/@elastic/eui-theme-common/-/eui-theme-common-0.1.0.tgz#fa74c7f72b4ca69ff1f7a5cf45e55c979064ab73" - integrity sha512-2Pm9PeEr4QXjtL/YYM6faXbQ2Fm/mJXzV7QLBxUW8iHov70IHZy1e3xJOio0lI1IbO3S7t79EIS6J3/uNffJfA== +"@elastic/eui-theme-common@0.2.0": + version "0.2.0" + resolved "https://registry.yarnpkg.com/@elastic/eui-theme-common/-/eui-theme-common-0.2.0.tgz#570a988f58c24076c6f867475e70930769f3cff5" + integrity sha512-g2n38Uk4G9UqQU/wim+ZKWusWtO1bdudvDy/7+sdCYaxtgbINT5hhMHoU9M49D+7FJSsPuHn7gVfdYKMN9bTdQ== dependencies: "@types/lodash" "^4.14.202" chroma-js "^2.4.2" lodash "^4.17.21" -"@elastic/eui@101.3.0-classic.0": - version "101.3.0-classic.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-101.3.0-classic.0.tgz#c7b0632b062257342210850a958d2e353e829026" - integrity sha512-REt71u2yfnVyXX3+2MWLk3VzBdHAbCeSiPcs5MHY6h4TQR1WsD8+qs9RGFFfvW9ZSXTtyimrwOjQFt6Ph64s2Q== +"@elastic/eui@101.4.0-amsterdam.0": + version "101.4.0-amsterdam.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-101.4.0-amsterdam.0.tgz#27360ebeb71e86052f99f5e88814b197ae97558e" + integrity sha512-zhWSRQYFFk2lm6mycBnpX8SJOeNzKjYJ7XwTv9RFfRUR6MGe/GfUIjHGCAg52NDNUTcYPlLuPhJKcNtAMasEOQ== dependencies: - "@elastic/eui-theme-common" "0.1.0" - "@elastic/prismjs-esql" "^1.0.0" + "@elastic/eui-theme-common" "0.2.0" + "@elastic/prismjs-esql" "^1.1.0" "@hello-pangea/dnd" "^16.6.0" "@types/lodash" "^4.14.202" "@types/numeral" "^2.0.5" @@ -2235,10 +2235,10 @@ resolved "https://registry.yarnpkg.com/@elastic/numeral/-/numeral-2.5.1.tgz#96acf39c3d599950646ef8ccfd24a3f057cf4932" integrity sha512-Tby6TKjixRFY+atVNeYUdGr9m0iaOq8230KTwn8BbUhkh7LwozfgKq0U98HRX7n63ZL62szl+cDKTYzh5WPCFQ== -"@elastic/prismjs-esql@^1.0.0": - version "1.0.0" - resolved "https://registry.yarnpkg.com/@elastic/prismjs-esql/-/prismjs-esql-1.0.0.tgz#370c996536dcea8840f2c2288a97aca4982e13c5" - integrity sha512-kEQcj9wg7pUaFkW7m7zs0fz4cmg0kWUMQv6SyENXKvLGMecgDjNciEoN3CMg22PYURelbnhM7ii6nFv9hAr2NA== +"@elastic/prismjs-esql@^1.1.0": + version "1.1.0" + resolved "https://registry.yarnpkg.com/@elastic/prismjs-esql/-/prismjs-esql-1.1.0.tgz#c7f84de21bb453831df7e8565be7430b1b078836" + integrity sha512-k2zZfCL4l+qCXfmc9jrnDdEWW2jDPFAHlCq1JAh3x7zWN6Eyc6ACn3oj9oy49xsuAO+BAhQ345uueL8K/3UIKg== "@elastic/react-search-ui-views@1.20.2", "@elastic/react-search-ui-views@^1.20.2": version "1.20.2" From bb4ef3b6a4f04558896b895385aa515e617590dc Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Tue, 22 Apr 2025 14:03:43 +0200 Subject: [PATCH 2/3] test: update tests - updates assertions on aria-current value from true to page, updated replaced icon --- .../test/functional/services/data_grid.ts | 2 +- .../datatable/components/table_basic.test.tsx | 10 +++++----- .../src/components/alerts_grouping.test.tsx | 18 +++++++++--------- .../alerts_table/alerts_grouping.test.tsx | 18 +++++++++--------- .../entity_store/entities_list.test.tsx | 2 +- .../components/paginated_table/index.test.tsx | 6 +++--- .../view/response_actions_list_page.test.tsx | 2 +- .../timeline/tabs/eql/index.test.tsx | 8 ++++---- .../timeline/tabs/query/index.test.tsx | 16 ++++++++-------- 9 files changed, 41 insertions(+), 41 deletions(-) diff --git a/src/platform/test/functional/services/data_grid.ts b/src/platform/test/functional/services/data_grid.ts index 6710f5baccc62..f259bffc12062 100644 --- a/src/platform/test/functional/services/data_grid.ts +++ b/src/platform/test/functional/services/data_grid.ts @@ -948,7 +948,7 @@ export class DataGridService extends FtrService { } public async getCurrentPageNumber() { - const currentPage = await this.find.byCssSelector('.euiPaginationButton[aria-current="true"]'); + const currentPage = await this.find.byCssSelector('.euiPaginationButton[aria-current="page"]'); return await currentPage.getVisibleText(); } diff --git a/x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/table_basic.test.tsx b/x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/table_basic.test.tsx index 14b3796fbd145..13030d68c12d0 100644 --- a/x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/table_basic.test.tsx +++ b/x-pack/platform/plugins/shared/lens/public/visualizations/datatable/components/table_basic.test.tsx @@ -518,7 +518,7 @@ describe('DatatableComponent', () => { expect(screen.queryByTestId('tablePaginationPopoverButton')).toBeInTheDocument(); expect(screen.getByRole('button', { name: `Page 1 of ${numberOfPages}` })).toHaveAttribute( 'aria-current', - 'true' + 'page' ); const newIndex = 3; await userEvent.click( @@ -526,7 +526,7 @@ describe('DatatableComponent', () => { ); expect( screen.getByRole('button', { name: `Page ${newIndex} of ${numberOfPages}` }) - ).toHaveAttribute('aria-current', 'true'); + ).toHaveAttribute('aria-current', 'page'); }); it('dynamically toggles pagination', async () => { const argsWithoutPagination = copyData(args); @@ -599,7 +599,7 @@ describe('DatatableComponent', () => { ); expect( screen.getByRole('button', { name: `Page ${newIndex} of ${numberOfPages}` }) - ).toHaveAttribute('aria-current', 'true'); + ).toHaveAttribute('aria-current', 'page'); await act(async () => { rerender({ @@ -614,7 +614,7 @@ describe('DatatableComponent', () => { // keeps existing page if more data is added expect( screen.getByRole('button', { name: `Page ${newIndex} of ${newNumberOfPages}` }) - ).toHaveAttribute('aria-current', 'true'); + ).toHaveAttribute('aria-current', 'page'); }); it('resets page position if rows change so page will be empty', async () => { @@ -639,7 +639,7 @@ describe('DatatableComponent', () => { ); expect( screen.getByRole('button', { name: `Page ${newIndex} of ${numberOfPages}` }) - ).toHaveAttribute('aria-current', 'true'); + ).toHaveAttribute('aria-current', 'page'); await act(async () => { rerender({ diff --git a/x-pack/solutions/observability/packages/kbn-alerts-grouping/src/components/alerts_grouping.test.tsx b/x-pack/solutions/observability/packages/kbn-alerts-grouping/src/components/alerts_grouping.test.tsx index 2424bc57005d6..2ad230f0ef924 100644 --- a/x-pack/solutions/observability/packages/kbn-alerts-grouping/src/components/alerts_grouping.test.tsx +++ b/x-pack/solutions/observability/packages/kbn-alerts-grouping/src/components/alerts_grouping.test.tsx @@ -240,7 +240,7 @@ describe('AlertsGrouping', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); }); await userEvent.click(screen.getAllByTestId('group-selector-dropdown')[0]); @@ -254,7 +254,7 @@ describe('AlertsGrouping', () => { ].forEach((pagination) => { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') ).toEqual(null); @@ -307,7 +307,7 @@ describe('AlertsGrouping', () => { ].forEach((pagination) => { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') ).toEqual(null); @@ -366,7 +366,7 @@ describe('AlertsGrouping', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); }); // level 2 pagination is reset @@ -374,7 +374,7 @@ describe('AlertsGrouping', () => { within(screen.getByTestId('grouping-level-2-pagination')) .getByTestId('pagination-button-0') .getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect( within(screen.getByTestId('grouping-level-2-pagination')) .getByTestId('pagination-button-1') @@ -429,11 +429,11 @@ describe('AlertsGrouping', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); } else { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect(within(pagination).queryByTestId('pagination-button-1')).not.toBeInTheDocument(); } }); @@ -484,11 +484,11 @@ describe('AlertsGrouping', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); } else { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect(within(pagination).queryByTestId('pagination-button-1')).not.toBeInTheDocument(); } }); diff --git a/x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/alerts_grouping.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/alerts_grouping.test.tsx index c2e2c76a7a702..c0bd866bd9880 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/alerts_grouping.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/alerts_grouping.test.tsx @@ -320,7 +320,7 @@ describe('GroupedAlertsTable', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); }); fireEvent.click(getAllByTestId('group-selector-dropdown')[0]); @@ -333,7 +333,7 @@ describe('GroupedAlertsTable', () => { ].forEach((pagination) => { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') ).toEqual(null); @@ -381,7 +381,7 @@ describe('GroupedAlertsTable', () => { ].forEach((pagination) => { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') ).toEqual(null); @@ -430,7 +430,7 @@ describe('GroupedAlertsTable', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); }); // level 2 pagination is reset @@ -438,7 +438,7 @@ describe('GroupedAlertsTable', () => { within(getByTestId('grouping-level-2-pagination')) .getByTestId('pagination-button-0') .getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect( within(getByTestId('grouping-level-2-pagination')) .getByTestId('pagination-button-1') @@ -484,11 +484,11 @@ describe('GroupedAlertsTable', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); } else { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect(within(pagination).queryByTestId('pagination-button-1')).not.toBeInTheDocument(); } }); @@ -533,11 +533,11 @@ describe('GroupedAlertsTable', () => { ).toEqual(null); expect( within(pagination).getByTestId('pagination-button-1').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); } else { expect( within(pagination).getByTestId('pagination-button-0').getAttribute('aria-current') - ).toEqual('true'); + ).toEqual('page'); expect(within(pagination).queryByTestId('pagination-button-1')).not.toBeInTheDocument(); } }); diff --git a/x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_store/entities_list.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_store/entities_list.test.tsx index 0f493304e1f87..753a0897a9c25 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_store/entities_list.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/entity_analytics/components/entity_store/entities_list.test.tsx @@ -126,7 +126,7 @@ describe('EntitiesList', () => { await waitFor(() => { const firstPageButton = screen.getByTestId('pagination-button-0'); - expect(firstPageButton).toHaveAttribute('aria-current', 'true'); + expect(firstPageButton).toHaveAttribute('aria-current', 'page'); }); }); diff --git a/x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/index.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/index.test.tsx index 0747feb9a5f54..db75d44077f8e 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/index.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/index.test.tsx @@ -99,7 +99,7 @@ describe('Paginated Table Component', () => { expect(screen.getByTestId('numberedPagination')).toBeInTheDocument(); const firstButton = screen.getByTestId('pagination-button-0'); - expect(firstButton).toHaveAttribute('aria-current', 'true'); + expect(firstButton).toHaveAttribute('aria-current', 'page'); expect(firstButton).toHaveAttribute('aria-label', 'Page 1 of 10'); }); @@ -177,7 +177,7 @@ describe('Paginated Table Component', () => { test('should update the page when the activePage is changed from redux', async () => { const { rerender } = renderComponent({ activePage: 3 }); const beforeActiveButton = screen.getByTestId('pagination-button-3'); - expect(beforeActiveButton).toHaveAttribute('aria-current', 'true'); + expect(beforeActiveButton).toHaveAttribute('aria-current', 'page'); expect(beforeActiveButton).toHaveAttribute('aria-label', 'Page 4 of 10'); rerender( @@ -188,7 +188,7 @@ describe('Paginated Table Component', () => { await waitFor(() => { const afterActiveButton = screen.getByTestId('pagination-button-0'); - expect(afterActiveButton).toHaveAttribute('aria-current', 'true'); + expect(afterActiveButton).toHaveAttribute('aria-current', 'page'); expect(afterActiveButton).toHaveAttribute('aria-label', 'Page 1 of 10'); }); }); diff --git a/x-pack/solutions/security/plugins/security_solution/public/management/pages/response_actions/view/response_actions_list_page.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/management/pages/response_actions/view/response_actions_list_page.test.tsx index 46e72a489681c..3c9ef24bac330 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/management/pages/response_actions/view/response_actions_list_page.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/management/pages/response_actions/view/response_actions_list_page.test.tsx @@ -214,7 +214,7 @@ describe('Response actions history page', () => { expect(history.location.search).toEqual('?page=3&pageSize=20'); expect(getByTestId('tablePaginationPopoverButton').textContent).toContain('20'); - expect(getByTestId('pagination-button-2').getAttribute('aria-current')).toStrictEqual('true'); + expect(getByTestId('pagination-button-2').getAttribute('aria-current')).toStrictEqual('page'); }); it('should read and set command filter values from URL params', async () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.test.tsx index b307e06331039..a75aa0336653c 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/eql/index.test.tsx @@ -267,7 +267,7 @@ describe('EQL Tab', () => { expect(screen.getByTestId('pagination-button-previous')).toBeVisible(); - expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'page'); expect(fetchNotesMock).toHaveBeenCalledWith(['1']); // Page : 2 @@ -280,7 +280,7 @@ describe('EQL Tab', () => { await waitFor(() => { expect(screen.getByTestId('pagination-button-1')).toHaveAttribute( 'aria-current', - 'true' + 'page' ); expect(fetchNotesMock).toHaveBeenNthCalledWith(1, [mockTimelineData[1]._id]); @@ -295,7 +295,7 @@ describe('EQL Tab', () => { await waitFor(() => { expect(screen.getByTestId('pagination-button-2')).toHaveAttribute( 'aria-current', - 'true' + 'page' ); expect(fetchNotesMock).toHaveBeenNthCalledWith(1, [mockTimelineData[2]._id]); @@ -339,7 +339,7 @@ describe('EQL Tab', () => { expect(screen.getByTestId('pagination-button-previous')).toBeVisible(); - expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'page'); expect(screen.getByTestId('tablePaginationPopoverButton')).toHaveTextContent( 'Rows per page: 1' ); diff --git a/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/query/index.test.tsx b/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/query/index.test.tsx index 746b3b1ceb1dd..8666ccf43c07e 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/query/index.test.tsx +++ b/x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/tabs/query/index.test.tsx @@ -364,14 +364,14 @@ describe('query tab with unified timeline', () => { 'Rows per page: 1' ); - expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'page'); expect(screen.getByTestId('pagination-button-2')).toBeVisible(); expect(screen.queryByTestId('pagination-button-3')).toBeNull(); fireEvent.click(screen.getByTestId('pagination-button-2')); await waitFor(() => { - expect(screen.getByTestId('pagination-button-2')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-2')).toHaveAttribute('aria-current', 'page'); }); }, SPECIAL_TEST_TIMEOUT @@ -393,7 +393,7 @@ describe('query tab with unified timeline', () => { expect(await screen.findByTestId('discoverDocTable')).toBeVisible(); await waitFor(() => { - expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'page'); expect(screen.getByTestId('pagination-button-2')).toBeVisible(); }); // Go to last page @@ -403,7 +403,7 @@ describe('query tab with unified timeline', () => { }); fireEvent.click(screen.getByTestId('dscGridSampleSizeFetchMoreLink')); await waitFor(() => { - expect(screen.getByTestId('pagination-button-2')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-2')).toHaveAttribute('aria-current', 'page'); expect(screen.getByTestId('pagination-button-5')).toBeVisible(); }); }, @@ -427,7 +427,7 @@ describe('query tab with unified timeline', () => { expect(screen.getByTestId('pagination-button-previous')).toBeVisible(); - expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'page'); expect(fetchNotesSpy).toHaveBeenCalledWith(['1']); // Page : 2 @@ -438,7 +438,7 @@ describe('query tab with unified timeline', () => { fireEvent.click(screen.getByTestId('pagination-button-1')); await waitFor(() => { - expect(screen.getByTestId('pagination-button-1')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-1')).toHaveAttribute('aria-current', 'page'); expect(fetchNotesSpy).toHaveBeenNthCalledWith(1, [mockTimelineData[1]._id]); }); @@ -450,7 +450,7 @@ describe('query tab with unified timeline', () => { fireEvent.click(screen.getByTestId('pagination-button-2')); await waitFor(() => { - expect(screen.getByTestId('pagination-button-2')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-2')).toHaveAttribute('aria-current', 'page'); expect(fetchNotesSpy).toHaveBeenNthCalledWith(1, [mockTimelineData[2]._id]); }); @@ -475,7 +475,7 @@ describe('query tab with unified timeline', () => { expect(screen.getByTestId('pagination-button-previous')).toBeVisible(); - expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'true'); + expect(screen.getByTestId('pagination-button-0')).toHaveAttribute('aria-current', 'page'); expect(screen.getByTestId('tablePaginationPopoverButton')).toHaveTextContent( 'Rows per page: 1' ); From 4ae07fa3a30cc04797ce963a4e4b100e9c91688c Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Tue, 22 Apr 2025 14:04:00 +0200 Subject: [PATCH 3/3] test: update snapshots --- .../__snapshots__/data_view.test.tsx.snap | 6 ++---- .../__snapshots__/comments.test.tsx.snap | 16 ++++++++-------- .../authentications_host_table.test.tsx.snap | 2 +- .../authentications_user_table.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 4 ++-- .../__snapshots__/index.test.tsx.snap | 4 ++-- .../tls_table/__snapshots__/index.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- 12 files changed, 22 insertions(+), 24 deletions(-) diff --git a/src/platform/plugins/shared/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap b/src/platform/plugins/shared/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap index f7b2acfda437f..39ce5453121ed 100644 --- a/src/platform/plugins/shared/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap +++ b/src/platform/plugins/shared/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap @@ -347,7 +347,6 @@ Array [ />