From 720ed2b37de84ad5db94583fc7e7e8c650a29450 Mon Sep 17 00:00:00 2001
From: "Christiane (Tina) Heiligers" <christiane.heiligers@elastic.co>
Date: Mon, 10 Mar 2025 15:03:56 -0700
Subject: [PATCH] only transform legend if present (#213814)

The inventory_view saved object allows the legend attribute to be
optional and limits and/or sets the number of steps during an upgrade
between model version 1 and 2. The transform function needs to handle
cases where legend is not set to prevent migration failures.

Related to https://github.com/elastic/kibana/pull/207007

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 85baab2431bea918a68d752ec912b792ee93e00f)
---
 .../inventory_view_saved_object.test.ts       | 19 +++++++++++++++++++
 .../inventory_view_saved_object.ts            |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.test.ts b/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.test.ts
index af29eb91b5f8e..c7e8039ecf101 100644
--- a/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.test.ts
+++ b/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.test.ts
@@ -57,5 +57,24 @@ describe('invetoryViewSavedObject model version transformation', () => {
       });
       expect(migrated.attributes).toEqual(inventoryViewV2.attributes);
     });
+
+    it('should return unaltered document if legend is not defined when converting from v1 to v2', () => {
+      const { legend, ...inventoryViewV2bAttributes } = inventoryViewV2.attributes;
+      const inventoryViewV1b = JSON.parse(
+        JSON.stringify({ ...inventoryViewV2, attributes: inventoryViewV2bAttributes })
+      );
+      delete inventoryViewV1b.attributes.legend;
+      const migrated = migrator.migrate({
+        document: {
+          ...inventoryViewV1b,
+          attributes: {
+            ...inventoryViewV1b.attributes,
+          },
+        },
+        fromVersion: 1,
+        toVersion: 2,
+      });
+      expect(migrated.attributes).toEqual(inventoryViewV2bAttributes);
+    });
   });
 });
diff --git a/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.ts b/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.ts
index 6faf824d44222..8554a1d310f32 100644
--- a/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.ts
+++ b/x-pack/solutions/observability/plugins/infra/server/saved_objects/inventory_view/inventory_view_saved_object.ts
@@ -59,9 +59,9 @@ export const inventoryViewSavedObjectType: SavedObjectsType = {
         {
           type: 'unsafe_transform',
           transformFn: (document) => {
-            if (document.attributes.legend.steps > 18) {
+            if (document.attributes.legend?.steps > 18) {
               document.attributes.legend.steps = 18;
-            } else if (document.attributes.legend.steps < 2) {
+            } else if (document.attributes.legend?.steps < 2) {
               document.attributes.legend.steps = 2;
             }
             return { document };