From 30fc08170de66f64ee246595776d7eff7d2ad0e7 Mon Sep 17 00:00:00 2001 From: Philippe Oberti Date: Fri, 28 Feb 2025 22:21:37 +0100 Subject: [PATCH] [Security Solution][Notes] change upper limit for max unassociated notes advanced setting to be 10k instead of 1k (#212786) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary This previous [PR](https://github.com/elastic/kibana/pull/194947) made the maximum number of unassociated notes an advanced settings so that user can change the value within a certain limit. The intent was to allow that value to be between 1 and 10,000 (see acceptance criteria of the [original ticket](https://github.com/elastic/kibana/issues/193097)) but we missed one 0 and the maximum value allowed got set to 1000. This PR fixes that. #### Before ![Screenshot 2025-02-28 at 9 18 14 AM](https://github.com/user-attachments/assets/cf1d473c-5bd5-4759-a834-60888b0c8f78) #### After ![Screenshot 2025-02-28 at 9 18 47 AM](https://github.com/user-attachments/assets/129ba898-bbad-420a-b615-b0a456640af4) (cherry picked from commit eabf95d6dc157d1c1ac2bb8832c7021986285aef) --- x-pack/plugins/security_solution/server/ui_settings.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/security_solution/server/ui_settings.ts b/x-pack/plugins/security_solution/server/ui_settings.ts index 6aeb86750be7a..53103f5e36322 100644 --- a/x-pack/plugins/security_solution/server/ui_settings.ts +++ b/x-pack/plugins/security_solution/server/ui_settings.ts @@ -340,7 +340,7 @@ export const initUiSettings = ( value: DEFAULT_MAX_UNASSOCIATED_NOTES, schema: schema.number({ min: 1, - max: 1000, + max: 10000, defaultValue: DEFAULT_MAX_UNASSOCIATED_NOTES, }), category: [APP_ID],