[ML] Fix overall bucket request for large number of job IDs #198292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
Team:ML
Contributor
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
approved these changes
Oct 30, 2024
Member
jgowdyelastic
left a comment
jgowdyelastic
left a comment
There was a problem hiding this comment.
Added nit pick comment, but otherwise LGTM
x-pack/plugins/ml/public/application/services/ml_api_service/index.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Starting backport for target branches: 8.16 https://github.com/elastic/kibana/actions/runs/11598549394 |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @darnautov |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
…198292) ## Summary Fixes elastic#190591 Adds chunking for `over_buckets` request to prevent exceeding the request length URL. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fa0f397)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
…198292) (#198415) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] Fix overall bucket request for large number of job IDs (#198292)](#198292) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T17:30:16Z","message":"[ML] Fix overall bucket request for large number of job IDs (#198292)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for `over_buckets` request to prevent exceeding the\r\nrequest length URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Fix overall bucket request for large number of job IDs","number":198292,"url":"https://github.com/elastic/kibana/pull/198292","mergeCommit":{"message":"[ML] Fix overall bucket request for large number of job IDs (#198292)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for `over_buckets` request to prevent exceeding the\r\nrequest length URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198292","number":198292,"mergeCommit":{"message":"[ML] Fix overall bucket request for large number of job IDs (#198292)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for `over_buckets` request to prevent exceeding the\r\nrequest length URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
darnautov
added
v8.17.0
backport:version
Contributor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11609543339 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
…198292) ## Summary Fixes elastic#190591 Adds chunking for `over_buckets` request to prevent exceeding the request length URL. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit fa0f397)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
…98292) (#198485) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix overall bucket request for large number of job IDs (#198292)](#198292) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T17:30:16Z","message":"[ML] Fix overall bucket request for large number of job IDs (#198292)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for `over_buckets` request to prevent exceeding the\r\nrequest length URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix overall bucket request for large number of job IDs","number":198292,"url":"https://github.com/elastic/kibana/pull/198292","mergeCommit":{"message":"[ML] Fix overall bucket request for large number of job IDs (#198292)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for `over_buckets` request to prevent exceeding the\r\nrequest length URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198292","number":198292,"mergeCommit":{"message":"[ML] Fix overall bucket request for large number of job IDs (#198292)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/190591\r\n\r\nAdds chunking for `over_buckets` request to prevent exceeding the\r\nrequest length URL.\r\n\r\n### Checklist\r\n\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"fa0f397a4269a37370d2101a8c5ece03ad0117bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198415","number":198415,"state":"MERGED","mergeCommit":{"sha":"318831e20a039ec3d41d12108a85ced5064116d7","message":"[8.16] [ML] Fix overall bucket request for large number of job IDs (#198292) (#198415)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[ML] Fix overall bucket request for large number of job IDs\n(#198292)](https://github.com/elastic/kibana/pull/198292)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-30T17:30:16Z\",\"message\":\"[ML]\nFix overall bucket request for large number of job IDs (#198292)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/190591\\r\\n\\r\\nAdds chunking for\n`over_buckets` request to prevent exceeding the\\r\\nrequest length\nURL.\\r\\n\\r\\n### Checklist\\r\\n\\r\\n\\r\\n- [ ] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"fa0f397a4269a37370d2101a8c5ece03ad0117bd\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML]\nFix overall bucket request for large number of job\nIDs\",\"number\":198292,\"url\":\"https://github.com/elastic/kibana/pull/198292\",\"mergeCommit\":{\"message\":\"[ML]\nFix overall bucket request for large number of job IDs (#198292)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/190591\\r\\n\\r\\nAdds chunking for\n`over_buckets` request to prevent exceeding the\\r\\nrequest length\nURL.\\r\\n\\r\\n### Checklist\\r\\n\\r\\n\\r\\n- [ ] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"fa0f397a4269a37370d2101a8c5ece03ad0117bd\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198292\",\"number\":198292,\"mergeCommit\":{\"message\":\"[ML]\nFix overall bucket request for large number of job IDs (#198292)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/190591\\r\\n\\r\\nAdds chunking for\n`over_buckets` request to prevent exceeding the\\r\\nrequest length\nURL.\\r\\n\\r\\n### Checklist\\r\\n\\r\\n\\r\\n- [ ] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"fa0f397a4269a37370d2101a8c5ece03ad0117bd\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dima Arnautov <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #190591
Adds chunking for
over_bucketsrequest to prevent exceeding the request length URL.Checklist