From edf137e40ae891b69cd5af651c32441d23ec7df5 Mon Sep 17 00:00:00 2001
From: Shahzad <shahzad31comp@gmail.com>
Date: Thu, 24 Oct 2024 11:10:51 +0200
Subject: [PATCH] [Synthetics] Fixes broken e2e tests !! (#197567)

## Summary

Fixes broken e2e tests !!

Rules API behavior somehow has changed , i still not sure what changed
but now it will rely on UI !!

(cherry picked from commit b61a627ef3a04617b2834e6c445666318a98d848)
---
 .../custom_status_alert.journey.ts            | 21 +++----------------
 .../journeys/services/synthetics_services.ts  |  8 -------
 .../page_objects/synthetics_app.tsx           |  5 +++++
 3 files changed, 8 insertions(+), 26 deletions(-)

diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/alert_rules/custom_status_alert.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/alert_rules/custom_status_alert.journey.ts
index 161a58d650e6c..431b3e39fc952 100644
--- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/alert_rules/custom_status_alert.journey.ts
+++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/alert_rules/custom_status_alert.journey.ts
@@ -5,8 +5,7 @@
  * 2.0.
  */
 
-import { journey, step, before, after, expect } from '@elastic/synthetics';
-import { RetryService } from '@kbn/ftr-common-functional-services';
+import { journey, step, before, after } from '@elastic/synthetics';
 import { syntheticsAppPageProvider } from '../../page_objects/synthetics_app';
 import { SyntheticsServices } from '../services/synthetics_services';
 
@@ -14,8 +13,6 @@ journey(`CustomStatusAlert`, async ({ page, params }) => {
   const syntheticsApp = syntheticsAppPageProvider({ page, kibanaUrl: params.kibanaUrl, params });
 
   const services = new SyntheticsServices(params);
-  const getService = params.getService;
-  const retry: RetryService = getService('retry');
 
   const firstCheckTime = new Date(Date.now()).toISOString();
 
@@ -60,19 +57,7 @@ journey(`CustomStatusAlert`, async ({ page, params }) => {
   });
 
   step('verify rule creation', async () => {
-    await retry.try(async () => {
-      const rules = await services.getRules();
-      expect(rules.length).toBe(3);
-      expect(rules[2].params).toStrictEqual({
-        condition: {
-          downThreshold: 3,
-          locationsThreshold: 1,
-          groupBy: 'locationId',
-          window: {
-            numberOfChecks: 5,
-          },
-        },
-      });
-    });
+    await syntheticsApp.goToRulesPage();
+    await page.waitForSelector(`text='Synthetics status rule'`);
   });
 });
diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/services/synthetics_services.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/services/synthetics_services.ts
index 23c5ef45d1383..5c356492f1c24 100644
--- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/services/synthetics_services.ts
+++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/services/synthetics_services.ts
@@ -221,14 +221,6 @@ export class SyntheticsServices {
     }
   }
 
-  async getRules() {
-    const response = await axios.get(this.kibanaUrl + '/internal/alerting/rules/_find', {
-      auth: { username: 'elastic', password: 'changeme' },
-      headers: { 'kbn-xsrf': 'true' },
-    });
-    return response.data.data;
-  }
-
   async setupTestConnector() {
     const indexConnector = {
       name: 'test index',
diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/page_objects/synthetics_app.tsx b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/page_objects/synthetics_app.tsx
index f6d5ce45b96c3..931694da554ca 100644
--- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/page_objects/synthetics_app.tsx
+++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/page_objects/synthetics_app.tsx
@@ -393,5 +393,10 @@ export function syntheticsAppPageProvider({
       const isDisabled = await addMonitorBtn.isDisabled();
       return !isDisabled;
     },
+
+    async goToRulesPage() {
+      const rulesPage = '/app/observability/alerts/rules';
+      await page.goto(basePath + rulesPage);
+    },
   };
 }